From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Date: Thu, 23 Jan 2020 14:52:14 +0530 Message-ID: <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , Jon Hunter , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: spujar@nvidia.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com List-Id: linux-tegra@vger.kernel.org On 1/22/2020 9:57 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 22.01.2020 14:52, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 22/01/2020 07:16, Sameer Pujar wrote: >> >> ... >> >>>>>>>>> +static int tegra210_i2s_remove(struct platform_device *pdev) >>>>>>>>> +{ >>>>>>>>> + pm_runtime_disable(&pdev->dev); >>>>>>>>> + if (!pm_runtime_status_suspended(&pdev->dev)) >>>>>>>>> + tegra210_i2s_runtime_suspend(&pdev->dev); >>>>>>>> This breaks device's RPM refcounting if it was disabled in the act= ive >>>>>>>> state. This code should be removed. At most you could warn about t= he >>>>>>>> unxpected RPM state here, but it shouldn't be necessary. >>>>>>> I guess this was added for safety and explicit suspend keeps clock >>>>>>> disabled. >>>>>>> Not sure if ref-counting of the device matters when runtime PM is >>>>>>> disabled and device is removed. >>>>>>> I see few drivers using this way. >>>>>> It should matter (if I'm not missing something) because RPM should >>>>>> be in >>>>>> a wrecked state once you'll try to re-load the driver's module. Like= ly >>>>>> that those few other drivers are wrong. >>>>>> >>>>>> [snip] >>>>> Once the driver is re-loaded and RPM is enabled, I don't think it >>>>> would use >>>>> the same 'dev' and the corresponding ref count. Doesn't it use the ne= w >>>>> counters? >>>>> If RPM is not working for some reason, most likely it would be the ca= se >>>>> for other >>>>> devices. What best driver can do is probably do a force suspend durin= g >>>>> removal if >>>>> already not done. I would prefer to keep, since multiple drivers stil= l >>>>> have it, >>>>> unless there is a real harm in doing so. >>>> I took a closer look and looks like the counter actually should be >>>> reset. Still I don't think that it's a good practice to make changes >>>> underneath of RPM, it may strike back. >>> If RPM is broken, it probably would have been caught during device usag= e. >>> I will remove explicit suspend here if no any concerns from other folks= . >>> Thanks. >> I recall that this was the preferred way of doing this from the RPM >> folks. Tegra30 I2S driver does the same and Stephen had pointed me to >> this as a reference. >> I believe that this is meant to ensure that the >> device is always powered-off regardless of it RPM is enabled or not and >> what the current state is. > Yes, it was kinda actual for the case of unavailable RPM. > Anyways, /I think/ variant like this should have been more preferred: > > if (!pm_runtime_enabled(&pdev->dev)) > tegra210_i2s_runtime_suspend(&pdev->dev); > else > pm_runtime_disable(&pdev->dev); I think it looks to be similar to what is there already. pm_runtime_disable(&pdev->dev); // it would turn out to be a dummy call=20 if !RPM if (!pm_runtime_status_suspended(&pdev->dev)) // it is true always if !RPM =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra210_i2s_runtime_suspend(&p= dev->dev); >> Now for Tegra210 (or actually 64-bit Tegra) RPM is always enabled and so >> we don't need to worry about the !RPM case. However, I still don't see >> the harm in this. > There is no real harm today, but: > > 1. I'd prefer to be very careful with RPM in general, based on > previous experience. > > 2. It should be a bug if device isn't RPM-suspended during > of driver's removal. Thus the real problem needs to be fixed > rather than worked around. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D40C2D0DB for ; Thu, 23 Jan 2020 09:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBB862087E for ; Thu, 23 Jan 2020 09:22:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CnIey0gh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbgAWJWX (ORCPT ); Thu, 23 Jan 2020 04:22:23 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:8095 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbgAWJWX (ORCPT ); Thu, 23 Jan 2020 04:22:23 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 23 Jan 2020 01:21:37 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 23 Jan 2020 01:22:22 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 23 Jan 2020 01:22:22 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 23 Jan 2020 09:22:17 +0000 CC: , , , , , , , , , , , , , Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , Jon Hunter , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> From: Sameer Pujar Message-ID: <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> Date: Thu, 23 Jan 2020 14:52:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579771297; bh=W73gVUmkU4iyhPeM1GjN5RD8ETiMnoanQX2UieDd3Rw=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=CnIey0ghCRC/n4tFmo3bopQyZk5SDOV0BWv3LXEUuReEEwe10a/yb+43qvSNXNPXW 62DxKirTbhxa1nkfJI+Z5pqNSob6hO4l5UzA/6Z9RFRUzes2XdT+VzfJaf3LoaNMgF OCoTqniXGmAp7+9n0IOzEwThzzcFJpruKuO16EtOY9s9bFPRkIUKklDiprGDp/z1BV AM13q7aA72hVd9wla4i4+k75NK157rsT5BfqoPqJPNu2u0sSlenmP8qyXqOGG6G/tm z/3t6CJbNoLeIOOdxP/Ddq5zG4CLB89lgnLtLLhzl2Av2qzPncJEdcMvMLav7U/Ol4 NAHxD8YJxLOqw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/2020 9:57 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 22.01.2020 14:52, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 22/01/2020 07:16, Sameer Pujar wrote: >> >> ... >> >>>>>>>>> +static int tegra210_i2s_remove(struct platform_device *pdev) >>>>>>>>> +{ >>>>>>>>> + pm_runtime_disable(&pdev->dev); >>>>>>>>> + if (!pm_runtime_status_suspended(&pdev->dev)) >>>>>>>>> + tegra210_i2s_runtime_suspend(&pdev->dev); >>>>>>>> This breaks device's RPM refcounting if it was disabled in the act= ive >>>>>>>> state. This code should be removed. At most you could warn about t= he >>>>>>>> unxpected RPM state here, but it shouldn't be necessary. >>>>>>> I guess this was added for safety and explicit suspend keeps clock >>>>>>> disabled. >>>>>>> Not sure if ref-counting of the device matters when runtime PM is >>>>>>> disabled and device is removed. >>>>>>> I see few drivers using this way. >>>>>> It should matter (if I'm not missing something) because RPM should >>>>>> be in >>>>>> a wrecked state once you'll try to re-load the driver's module. Like= ly >>>>>> that those few other drivers are wrong. >>>>>> >>>>>> [snip] >>>>> Once the driver is re-loaded and RPM is enabled, I don't think it >>>>> would use >>>>> the same 'dev' and the corresponding ref count. Doesn't it use the ne= w >>>>> counters? >>>>> If RPM is not working for some reason, most likely it would be the ca= se >>>>> for other >>>>> devices. What best driver can do is probably do a force suspend durin= g >>>>> removal if >>>>> already not done. I would prefer to keep, since multiple drivers stil= l >>>>> have it, >>>>> unless there is a real harm in doing so. >>>> I took a closer look and looks like the counter actually should be >>>> reset. Still I don't think that it's a good practice to make changes >>>> underneath of RPM, it may strike back. >>> If RPM is broken, it probably would have been caught during device usag= e. >>> I will remove explicit suspend here if no any concerns from other folks= . >>> Thanks. >> I recall that this was the preferred way of doing this from the RPM >> folks. Tegra30 I2S driver does the same and Stephen had pointed me to >> this as a reference. >> I believe that this is meant to ensure that the >> device is always powered-off regardless of it RPM is enabled or not and >> what the current state is. > Yes, it was kinda actual for the case of unavailable RPM. > Anyways, /I think/ variant like this should have been more preferred: > > if (!pm_runtime_enabled(&pdev->dev)) > tegra210_i2s_runtime_suspend(&pdev->dev); > else > pm_runtime_disable(&pdev->dev); I think it looks to be similar to what is there already. pm_runtime_disable(&pdev->dev); // it would turn out to be a dummy call=20 if !RPM if (!pm_runtime_status_suspended(&pdev->dev)) // it is true always if !RPM =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra210_i2s_runtime_suspend(&p= dev->dev); >> Now for Tegra210 (or actually 64-bit Tegra) RPM is always enabled and so >> we don't need to worry about the !RPM case. However, I still don't see >> the harm in this. > There is no real harm today, but: > > 1. I'd prefer to be very careful with RPM in general, based on > previous experience. > > 2. It should be a bug if device isn't RPM-suspended during > of driver's removal. Thus the real problem needs to be fixed > rather than worked around. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF6BC2D0DB for ; Thu, 23 Jan 2020 09:23:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC7802087E for ; Thu, 23 Jan 2020 09:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="F0h3ZAjW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CnIey0gh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC7802087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2B8A015E5; Thu, 23 Jan 2020 10:22:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2B8A015E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579771400; bh=H8qROHQHhqa0fxcMu0QOXWyKYGuhkH8DUFIN0oH+0oQ=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F0h3ZAjW3zSUZwxQ7RG9s/RNEd6ytZEv78CWp34h5MmG+OXbYJpEhvAWPN6SlRpS2 hN/ehWRNtiL9C4//q22jeXloYkxcS/Y1uFwS+Fp5RzoAuvZx9gw80yFOHs30ELanw2 hH3BgxTZzInMGruVXMMULUbbj5wRhOu/Uc50pmMU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 93198F8015B; Thu, 23 Jan 2020 10:22:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 668B1F801D9; Thu, 23 Jan 2020 10:22:28 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36407F800E7 for ; Thu, 23 Jan 2020 10:22:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36407F800E7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CnIey0gh" Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 23 Jan 2020 01:21:37 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 23 Jan 2020 01:22:22 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 23 Jan 2020 01:22:22 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 23 Jan 2020 09:22:17 +0000 To: Dmitry Osipenko , Jon Hunter , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> From: Sameer Pujar Message-ID: <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> Date: Thu, 23 Jan 2020 14:52:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579771297; bh=W73gVUmkU4iyhPeM1GjN5RD8ETiMnoanQX2UieDd3Rw=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=CnIey0ghCRC/n4tFmo3bopQyZk5SDOV0BWv3LXEUuReEEwe10a/yb+43qvSNXNPXW 62DxKirTbhxa1nkfJI+Z5pqNSob6hO4l5UzA/6Z9RFRUzes2XdT+VzfJaf3LoaNMgF OCoTqniXGmAp7+9n0IOzEwThzzcFJpruKuO16EtOY9s9bFPRkIUKklDiprGDp/z1BV AM13q7aA72hVd9wla4i4+k75NK157rsT5BfqoPqJPNu2u0sSlenmP8qyXqOGG6G/tm z/3t6CJbNoLeIOOdxP/Ddq5zG4CLB89lgnLtLLhzl2Av2qzPncJEdcMvMLav7U/Ol4 NAHxD8YJxLOqw== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, spujar@nvidia.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" CgpPbiAxLzIyLzIwMjAgOTo1NyBQTSwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IEV4dGVybmFs IGVtYWlsOiBVc2UgY2F1dGlvbiBvcGVuaW5nIGxpbmtzIG9yIGF0dGFjaG1lbnRzCj4KPgo+IDIy LjAxLjIwMjAgMTQ6NTIsIEpvbiBIdW50ZXIg0L/QuNGI0LXRgjoKPj4gT24gMjIvMDEvMjAyMCAw NzoxNiwgU2FtZWVyIFB1amFyIHdyb3RlOgo+Pgo+PiAuLi4KPj4KPj4+Pj4+Pj4+ICtzdGF0aWMg aW50IHRlZ3JhMjEwX2kyc19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+ Pj4+Pj4+ICt7Cj4+Pj4+Pj4+PiArICAgICBwbV9ydW50aW1lX2Rpc2FibGUoJnBkZXYtPmRldik7 Cj4+Pj4+Pj4+PiArICAgICBpZiAoIXBtX3J1bnRpbWVfc3RhdHVzX3N1c3BlbmRlZCgmcGRldi0+ ZGV2KSkKPj4+Pj4+Pj4+ICsgICAgICAgICAgICAgdGVncmEyMTBfaTJzX3J1bnRpbWVfc3VzcGVu ZCgmcGRldi0+ZGV2KTsKPj4+Pj4+Pj4gVGhpcyBicmVha3MgZGV2aWNlJ3MgUlBNIHJlZmNvdW50 aW5nIGlmIGl0IHdhcyBkaXNhYmxlZCBpbiB0aGUgYWN0aXZlCj4+Pj4+Pj4+IHN0YXRlLiBUaGlz IGNvZGUgc2hvdWxkIGJlIHJlbW92ZWQuIEF0IG1vc3QgeW91IGNvdWxkIHdhcm4gYWJvdXQgdGhl Cj4+Pj4+Pj4+IHVueHBlY3RlZCBSUE0gc3RhdGUgaGVyZSwgYnV0IGl0IHNob3VsZG4ndCBiZSBu ZWNlc3NhcnkuCj4+Pj4+Pj4gSSBndWVzcyB0aGlzIHdhcyBhZGRlZCBmb3Igc2FmZXR5IGFuZCBl eHBsaWNpdCBzdXNwZW5kIGtlZXBzIGNsb2NrCj4+Pj4+Pj4gZGlzYWJsZWQuCj4+Pj4+Pj4gTm90 IHN1cmUgaWYgcmVmLWNvdW50aW5nIG9mIHRoZSBkZXZpY2UgbWF0dGVycyB3aGVuIHJ1bnRpbWUg UE0gaXMKPj4+Pj4+PiBkaXNhYmxlZCBhbmQgZGV2aWNlIGlzIHJlbW92ZWQuCj4+Pj4+Pj4gSSBz ZWUgZmV3IGRyaXZlcnMgdXNpbmcgdGhpcyB3YXkuCj4+Pj4+PiBJdCBzaG91bGQgbWF0dGVyIChp ZiBJJ20gbm90IG1pc3Npbmcgc29tZXRoaW5nKSBiZWNhdXNlIFJQTSBzaG91bGQKPj4+Pj4+IGJl IGluCj4+Pj4+PiBhIHdyZWNrZWQgc3RhdGUgb25jZSB5b3UnbGwgdHJ5IHRvIHJlLWxvYWQgdGhl IGRyaXZlcidzIG1vZHVsZS4gTGlrZWx5Cj4+Pj4+PiB0aGF0IHRob3NlIGZldyBvdGhlciBkcml2 ZXJzIGFyZSB3cm9uZy4KPj4+Pj4+Cj4+Pj4+PiBbc25pcF0KPj4+Pj4gT25jZSB0aGUgZHJpdmVy IGlzIHJlLWxvYWRlZCBhbmQgUlBNIGlzIGVuYWJsZWQsIEkgZG9uJ3QgdGhpbmsgaXQKPj4+Pj4g d291bGQgdXNlCj4+Pj4+IHRoZSBzYW1lICdkZXYnIGFuZCB0aGUgY29ycmVzcG9uZGluZyByZWYg Y291bnQuIERvZXNuJ3QgaXQgdXNlIHRoZSBuZXcKPj4+Pj4gY291bnRlcnM/Cj4+Pj4+IElmIFJQ TSBpcyBub3Qgd29ya2luZyBmb3Igc29tZSByZWFzb24sIG1vc3QgbGlrZWx5IGl0IHdvdWxkIGJl IHRoZSBjYXNlCj4+Pj4+IGZvciBvdGhlcgo+Pj4+PiBkZXZpY2VzLiBXaGF0IGJlc3QgZHJpdmVy IGNhbiBkbyBpcyBwcm9iYWJseSBkbyBhIGZvcmNlIHN1c3BlbmQgZHVyaW5nCj4+Pj4+IHJlbW92 YWwgaWYKPj4+Pj4gYWxyZWFkeSBub3QgZG9uZS4gSSB3b3VsZCBwcmVmZXIgdG8ga2VlcCwgc2lu Y2UgbXVsdGlwbGUgZHJpdmVycyBzdGlsbAo+Pj4+PiBoYXZlIGl0LAo+Pj4+PiB1bmxlc3MgdGhl cmUgaXMgYSByZWFsIGhhcm0gaW4gZG9pbmcgc28uCj4+Pj4gSSB0b29rIGEgY2xvc2VyIGxvb2sg YW5kIGxvb2tzIGxpa2UgdGhlIGNvdW50ZXIgYWN0dWFsbHkgc2hvdWxkIGJlCj4+Pj4gcmVzZXQu IFN0aWxsIEkgZG9uJ3QgdGhpbmsgdGhhdCBpdCdzIGEgZ29vZCBwcmFjdGljZSB0byBtYWtlIGNo YW5nZXMKPj4+PiB1bmRlcm5lYXRoIG9mIFJQTSwgaXQgbWF5IHN0cmlrZSBiYWNrLgo+Pj4gSWYg UlBNIGlzIGJyb2tlbiwgaXQgcHJvYmFibHkgd291bGQgaGF2ZSBiZWVuIGNhdWdodCBkdXJpbmcg ZGV2aWNlIHVzYWdlLgo+Pj4gSSB3aWxsIHJlbW92ZSBleHBsaWNpdCBzdXNwZW5kIGhlcmUgaWYg bm8gYW55IGNvbmNlcm5zIGZyb20gb3RoZXIgZm9sa3MuCj4+PiBUaGFua3MuCj4+IEkgcmVjYWxs IHRoYXQgdGhpcyB3YXMgdGhlIHByZWZlcnJlZCB3YXkgb2YgZG9pbmcgdGhpcyBmcm9tIHRoZSBS UE0KPj4gZm9sa3MuIFRlZ3JhMzAgSTJTIGRyaXZlciBkb2VzIHRoZSBzYW1lIGFuZCBTdGVwaGVu IGhhZCBwb2ludGVkIG1lIHRvCj4+IHRoaXMgYXMgYSByZWZlcmVuY2UuCj4+IEkgYmVsaWV2ZSB0 aGF0IHRoaXMgaXMgbWVhbnQgdG8gZW5zdXJlIHRoYXQgdGhlCj4+IGRldmljZSBpcyBhbHdheXMg cG93ZXJlZC1vZmYgcmVnYXJkbGVzcyBvZiBpdCBSUE0gaXMgZW5hYmxlZCBvciBub3QgYW5kCj4+ IHdoYXQgdGhlIGN1cnJlbnQgc3RhdGUgaXMuCj4gWWVzLCBpdCB3YXMga2luZGEgYWN0dWFsIGZv ciB0aGUgY2FzZSBvZiB1bmF2YWlsYWJsZSBSUE0uCgo+IEFueXdheXMsIC9JIHRoaW5rLyB2YXJp YW50IGxpa2UgdGhpcyBzaG91bGQgaGF2ZSBiZWVuIG1vcmUgcHJlZmVycmVkOgo+Cj4gaWYgKCFw bV9ydW50aW1lX2VuYWJsZWQoJnBkZXYtPmRldikpCj4gICAgICAgICAgdGVncmEyMTBfaTJzX3J1 bnRpbWVfc3VzcGVuZCgmcGRldi0+ZGV2KTsKPiBlbHNlCj4gICAgICAgICAgcG1fcnVudGltZV9k aXNhYmxlKCZwZGV2LT5kZXYpOwoKSSB0aGluayBpdCBsb29rcyB0byBiZSBzaW1pbGFyIHRvIHdo YXQgaXMgdGhlcmUgYWxyZWFkeS4KCnBtX3J1bnRpbWVfZGlzYWJsZSgmcGRldi0+ZGV2KTsgLy8g aXQgd291bGQgdHVybiBvdXQgdG8gYmUgYSBkdW1teSBjYWxsIAppZiAhUlBNCmlmICghcG1fcnVu dGltZV9zdGF0dXNfc3VzcGVuZGVkKCZwZGV2LT5kZXYpKSAvLyBpdCBpcyB0cnVlIGFsd2F5cyBp ZiAhUlBNCiDCoMKgwqDCoMKgwqDCoCB0ZWdyYTIxMF9pMnNfcnVudGltZV9zdXNwZW5kKCZwZGV2 LT5kZXYpOwo+PiBOb3cgZm9yIFRlZ3JhMjEwIChvciBhY3R1YWxseSA2NC1iaXQgVGVncmEpIFJQ TSBpcyBhbHdheXMgZW5hYmxlZCBhbmQgc28KPj4gd2UgZG9uJ3QgbmVlZCB0byB3b3JyeSBhYm91 dCB0aGUgIVJQTSBjYXNlLiBIb3dldmVyLCBJIHN0aWxsIGRvbid0IHNlZQo+PiB0aGUgaGFybSBp biB0aGlzLgo+IFRoZXJlIGlzIG5vIHJlYWwgaGFybSB0b2RheSwgYnV0Ogo+Cj4gMS4gSSdkIHBy ZWZlciB0byBiZSB2ZXJ5IGNhcmVmdWwgd2l0aCBSUE0gaW4gZ2VuZXJhbCwgYmFzZWQgb24KPiAg ICAgcHJldmlvdXMgZXhwZXJpZW5jZS4KPgo+IDIuIEl0IHNob3VsZCBiZSBhIGJ1ZyBpZiBkZXZp Y2UgaXNuJ3QgUlBNLXN1c3BlbmRlZCBkdXJpbmcKPiAgICAgb2YgZHJpdmVyJ3MgcmVtb3ZhbC4g VGh1cyB0aGUgcmVhbCBwcm9ibGVtIG5lZWRzIHRvIGJlIGZpeGVkCj4gICAgIHJhdGhlciB0aGFu IHdvcmtlZCBhcm91bmQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5v cmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNh LWRldmVsCg==