All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ziyuan Xu <xzy.xu@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: Rework and correct barrier definitions
Date: Thu, 4 Aug 2016 15:49:52 +0800	[thread overview]
Message-ID: <0fd7c00c-0e01-7a4b-fe7a-314817a92ef2@rock-chips.com> (raw)
In-Reply-To: <20160802003959.GT17970@bill-the-cat>

Hi Tom,


On 2016?08?02? 08:39, Tom Rini wrote:
> On Tue, Aug 02, 2016 at 08:37:19AM +0800, Ziyuan Xu wrote:
>> Hi Tom,
>>
>>
>> On 2016?08?02? 06:54, Tom Rini wrote:
>>> As part of testing booting Linux kernels on Rockchip devices, it was
>>> discovered by Ziyuan Xu and Sandy Patterson that we had multiple and for
>>> some cases incomplete isb definitions.  This was causing a failure to
>>> boot of the Linux kernel.
>>>
>>> In order to solve this problem as well as cover any corner cases that we
>>> may also have had a number of changes are made in order to consolidate
>>> things.  First, <asm/barriers.h> now becomes the source of isb/dsb/dmb
>>> definitions.  This however introduces another complexity.  Due to
>>> needing to build SPL for 32bit tegra with -march=armv4 we need to borrow
>>> the __LINUX_ARM_ARCH__ logic from the Linux Kernel in a more complete
>>> form.  Move this from arch/arm/lib/Makefile to arch/arm/Makefile and add
>>> a comment about it.  Now that we can always know what the target CPU is
>>> capable off we can get always do the correct thing for the barrier.  The
>>> final part of this is that need to be consistent everywhere and call
>>> isb()/dsb()/dmb() and NOT call ISB/DSB/DMB in some cases and the
>>> function names in others.
>>>
>>> Reported-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>> Reported-by: Sandy Patterson <apatterson@sightlogix.com>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>> Great, this rework is similar to linux kernel, and it's better than
>> what I did.  Moreover, it works for my rk3288 boards.
>> Tested-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>
>> But please can you keep things in alpha order? See below.
> Sure, I'll re-work when applying or reposting if there's any other
> comments.  Thanks!
I wonder does this patch could be applied into the 2016.9 release version?
It's imperative for rockchip rk3288.:-)
>

  parent reply	other threads:[~2016-08-04  7:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 22:54 [U-Boot] [PATCH] ARM: Rework and correct barrier definitions Tom Rini
2016-08-02  0:37 ` Ziyuan Xu
2016-08-02  0:39   ` Tom Rini
2016-08-02 12:28     ` Sandy Patterson
2016-08-04  7:49     ` Ziyuan Xu [this message]
2016-08-02 18:13 ` Stephen Warren
2016-08-06  0:57 ` Tom Rini
2016-08-30 21:27   ` york sun
2016-08-30 21:50 ` york sun
2016-09-02 13:00   ` Tom Rini
2016-09-02 16:16     ` york sun
2016-08-30 22:01 ` york sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fd7c00c-0e01-7a4b-fe7a-314817a92ef2@rock-chips.com \
    --to=xzy.xu@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.