From: Ed Tsai <ed.tsai@mediatek.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
<stanley.chu@mediatek.com>, <loda.chou@mediatek.com>
Subject: Re: [PATCH 1/1] sched: remove the redundant 'success' in the sched tracepoint
Date: Fri, 23 Apr 2021 08:38:22 +0800 [thread overview]
Message-ID: <0fd8e103cc2886724979f7d93066b86b773032eb.camel@mediatek.com> (raw)
In-Reply-To: <20210422114629.2b1ea3ad@gandalf.local.home>
On Thu, 2021-04-22 at 11:46 -0400, Steven Rostedt wrote:
> On Thu, 22 Apr 2021 20:22:26 +0800
> Ed Tsai <ed.tsai@mediatek.com> wrote:
>
> > 'success' is left here for a long time and also it is meaningless
> > for the upper user. Just remove it.
>
> Have you tested all userspace code that might use this?
>
> This is the "poster boy" example of why Peter Zijlstra hates trace
> events ;-)
>
> I know I've updated trace-cmd to check to see if this field exits
> before
> depending on it, but there may be some other tools that may not.
> Perhaps
> nothing will break.
>
> I'm all for this change, but be ware, it might be reverted if there's
> some
> tool out that that expects it to exist. This is why it hasn't been
> removed.
>
> -- Steve
It is left here over 5 years. Old userspace code need this entry and
also someone may use it for a new tool. I hate this but it is a problem
should be resolved for the kernel or ignore just fine.
next prev parent reply other threads:[~2021-04-23 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 12:22 [PATCH 1/1] sched: remove the redundant 'success' in the sched tracepoint Ed Tsai
2021-04-22 15:46 ` Steven Rostedt
2021-04-23 0:38 ` Ed Tsai [this message]
2021-04-25 21:54 ` Steven Rostedt
2021-04-26 6:18 ` Ed Tsai
2021-04-26 13:48 ` Steven Rostedt
2021-04-26 8:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd8e103cc2886724979f7d93066b86b773032eb.camel@mediatek.com \
--to=ed.tsai@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loda.chou@mediatek.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.