All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>,
	"'Thomas Gleixner'" <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	"'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>
Subject: RE: [PATCH] provide irq_force_affinity fallback for non-SMP
Date: Tue, 06 May 2014 14:02:20 +0900	[thread overview]
Message-ID: <0fda01cf68e8$5c1364f0$143a2ed0$@samsung.com> (raw)
In-Reply-To: <5619084.0zmrrIUZLV@wuerfel>

Arnd Bergmann wrote:
> 
> Patch 01f8fa4f01d "genirq: Allow forcing cpu affinity of interrupts" added
> an irq_force_affinity() function, and 30ccf03b4a6 "clocksource:
Exynos_mct:
> Use irq_force_affinity() in cpu bringup" subsequently uses it. However,
> the
> driver can be used with CONFIG_SMP disabled, but the function declaration
> is only available for CONFIG_SMP, leading to this build error:
> 
> drivers/clocksource/exynos_mct.c:431:3: error: implicit declaration of
> function 'irq_force_affinity' [-Werror=implicit-function-declaration]
>    irq_force_affinity(mct_irqs[MCT_L0_IRQ + cpu], cpumask_of(cpu));
> 
> This patch introduces a dummy helper function for the non-SMP case
> that always returns success, to get rid of the build error.
> Since the patches causing the problem are marked for stable backports,
> this one should be as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Arnd, thanks for your fix the build error.

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

- Kukjin

> Cc: stable@vger.kernel.org
> ---
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index 0e6b23f..b72a643 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -272,6 +272,11 @@ static inline int irq_set_affinity(unsigned int irq,
> const struct cpumask *m)
>  	return -EINVAL;
>  }
> 
> +static inline int irq_force_affinity(unsigned int irq, const struct
> cpumask *cpumask)
> +{
> +	return 0;
> +}
> +
>  static inline int irq_can_set_affinity(unsigned int irq)
>  {
>  	return 0;


  reply	other threads:[~2014-05-06  5:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 12:49 [PATCH] provide irq_force_affinity fallback for non-SMP Arnd Bergmann
2014-05-06  5:02 ` Kukjin Kim [this message]
2014-05-06 22:46 ` [tip:irq/urgent] genirq: Provide " tip-bot for Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0fda01cf68e8$5c1364f0$143a2ed0$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=arnd@arndb.de \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.