From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DD1CECAAA1 for ; Tue, 6 Sep 2022 05:20:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1681184A0E; Tue, 6 Sep 2022 07:20:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="UM6NzliZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0555C84A13; Tue, 6 Sep 2022 07:20:53 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5633A84A0A for ; Tue, 6 Sep 2022 07:20:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZL5ttcAHisBkoXuEu3HNEIL1Il7s0ZZR+1qWLHfmRuzfRFG4pjV22RtUz3hKwwW9EsYJJCEUCAQYExjLWmnW0vzwprSzmn04VS7bfC2Wa7O+3CPRgOMY54Q69hpKQkET5tO+teEpn+EfABrzh6zzuQ0qDFEObtYBvZtwcf2SKP2Lxh4uHWRHbVSuUti6BFrNSIB1ylCUb4m4deO549VsEnRIxuISJDKHqYbW1f6s0HyNYgfr8gyhdL0m0DuGuephuvQDpI52UN5PJGaHR3CKFwKtlOru6vSwZTj1ZKXP9nfUG9Rtm7af8cax+wp5SVT7IUB5/lA+Q/lLlnYAcaAihA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OK5lXDkHvdVUVWOoDqk+pFSpqZNXv0cnkkhkFvXreWM=; b=YG+gxKzc8NnpiYgbSMCBKXcbz2JKSguQgfkQQxgODs0hVKGcJVSPONoVtb4z/6wJ9SxfpQHlCPlUHjyMfAfAvIfTxmEMuXt2yniB++hNqF1PLdG0oXu/NiZRXtAOSJp+t4fHYGJkG1y+q78aUQPvhBPWnPJkaR2Jr2N9sPIy8Qp7Tjhe7koDGSODBHsILfVYRYiZq4SpRbXJQqCIRk3/ex7z8f0adbRe6fVBNaYua/ISveoeF5SAWM8lPsHKThpE3uT++Ott3m11rDxmk6qxUug+IsSHBT28yHXmO8KUa5B1cI5G9j/S2xBHnwjFilH2+cbHA+ZwC1Lnqtj82FJL1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OK5lXDkHvdVUVWOoDqk+pFSpqZNXv0cnkkhkFvXreWM=; b=UM6NzliZSTuvbuJ+VjuaXozStEWFt1yACDp+INGYmOkh6ZRPqFLwz4iQvZaCwJebQX3ma0D/Y1QoPIoXE/kdNK4DNEizpcBehh1bnVwPzLeSyDEsJnQQ4kOhm/rXWas2cROFjJTQ8TiwOIXCXTafTfUyj6ofVsM1XB53xXydI+c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR04MB6927.eurprd04.prod.outlook.com (2603:10a6:803:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Tue, 6 Sep 2022 05:20:47 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2d22:3315:6f9b:82c7]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2d22:3315:6f9b:82c7%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 05:20:46 +0000 Message-ID: <0ff96168-44f6-c962-bc7b-5fcc39828b3d@oss.nxp.com> Date: Tue, 6 Sep 2022 13:20:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH v2 1/4] board: freescale: p1_p2_rdb_pc: Add workaround for board reset reboot loop Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Tom Rini , u-boot@lists.denx.de References: <20220501122314.32626-1-pali@kernel.org> <20220801133146.11481-1-pali@kernel.org> <20220821103004.y75mrkb3l23jc6um@pali> <20220831120456.qimijikbcepvb7g2@pali> From: Peng Fan In-Reply-To: <20220831120456.qimijikbcepvb7g2@pali> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2P153CA0020.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::7) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8e5dbc5-e975-47fc-0570-08da8fc78d8a X-MS-TrafficTypeDiagnostic: VI1PR04MB6927:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QTVL3serJs/fFkrfoigkY8t4Glvke753r7NoJfopGVW3fD9ARbJiaEe12Gz/txR8zN5JQGFrpC69lpC7lIE+YStU6AGQqF4Jbim9p42TY5IFK5LT4GZoAdfcozGbyAm8kYU1TeeDHEcuFnUudmTK1JPO0Azv5ePr9sGd50mXKwJ8R4JWCn9lSpI/Tzcfy/aRmWSGtWW1j6+2Un/W/7vZEHD4AZOSwU/KDpSzafaDDSVBo+n6EEdMAFPzKCD5NNh8yVpsJWn9FvVvjOlUdsuRySO4PIsT3j0CwSXrfNJ5UUyMc/sfoaS8ENajJ3lZWlvfWuwfy8jweepPBvZ0Zt/E4BT4KleWIf4SoxM69xTZOsjrUOlExDw47M8WGm7b5ONoY+UW1w9kw8x4wkIGmoWstlYT+d4ki6O5FGr3qt+P+/7MG9XFX0RceXdby1+tO63t7Tp23FdVask0+X6BzlNwk17TOnsG6ofcusDbfbJD4LZMf1EmJ/yW5jhVIVn47FtZh1QzQOjiWZoFJ0tOISugrxE0H4uT5ckm7nSwZSmyuXTsHnQoy1KV+Irk+75GHsRnmSuwHtgMDW5Wg6uzoTbE1kcutPLyxnsfvmpoNnHGw/eYg17AlDMBEbU3KNWHPMf1nsCgx9DdpglS8MqwWItudBAo3MvVO0VKvBOuefMghsau/FyceZNHf9IETg94cOp8yIUeJBzqwqxnLBLodo8G45LhDNOz9lSewq5MUwl+usfG174wxEeJ4lOHGrQVRxK+Z31x3ATHRtpj1BkMIwQED1GziRrglSOi5AwtFnnIhn7KbKZNJomR/A2yuRmjDUGU2YG86trVD0nR5T+8qIxSfPBwOTa5XMoBvEI/HyTl6M4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(38350700002)(38100700002)(31686004)(186003)(2616005)(110136005)(316002)(8936002)(966005)(6506007)(6486002)(66476007)(66574015)(478600001)(5660300002)(8676002)(66946007)(86362001)(31696002)(53546011)(52116002)(83380400001)(66556008)(44832011)(6666004)(26005)(2906002)(41300700001)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N010T3lERCtMYmtIdFZRbk9oNWFuTm5UaHJIWjYzUlAwV2Qwb3o0UlkxdGpH?= =?utf-8?B?TExsL1RaRjJTb2t2NVMrZ3VIcHFacitRQXBvZ0t2b2l5dzBTY2tBU1ZRWFZ4?= =?utf-8?B?TUxoMTFtem9Sb3MzZWxvQzgzQklHNHV0UTB6YXFYK2VHMlFKbG1FajhUWTht?= =?utf-8?B?WnhpTHFxaWREN1JWclFNRkNJSlB6TzhRc0JoVVY1WGZvSlNkQUhMeHpJYnY5?= =?utf-8?B?MlBYRVhZam1hMitSOFU0NlBCNXhUSE80QlgyTG13M1JvWFFDS25MT2RYV0JO?= =?utf-8?B?bERRWVBBOUtTU2tYaExQUDJkMXRNOXhhNENHSG9mQTVwMnNVT00wektpaFEx?= =?utf-8?B?TXBFb25rVHVTc3R0d2l5WXFuTUMyODBSOEJoVEk2U2hXQkc2TW1Ob2JrUkE4?= =?utf-8?B?MEpTQVZCN3lXY0wyYU1RVDVDVEMwNkVMVVFuLzljR2NVOFVKeXNRcjZBTGc3?= =?utf-8?B?UTA1RjdkK082VFIzZ3lEajA0VXVWdzJyMWwzTk01UVBVOE81OWdWc3hkOU5j?= =?utf-8?B?ODZ6b0czWXJIaWUwNWdUYzJrUzNkZkdqR1owdzh3eFFjWWtMYW9KejNaaUUx?= =?utf-8?B?UFdWODAvaURDclV0MnBOQ0NDUUFJTVRxKzFKUzRuQ25Dbyt1V2xhZEk5UmJu?= =?utf-8?B?QXpZTjNhVGhpN2tXSmJGbG5jVkR5UEJBK05tQ2tyVkFkOCsyc1VrRDRSd2Ew?= =?utf-8?B?a3Fxa1JLdTJMVVdRL3dTVm1KZEFUSmtlVzRjOXVuWmZJZ3UzRk1FMzZXT2xh?= =?utf-8?B?cHJQSk5rbkpGU1BWYVdVZ212TjVPQW41clROVHZINVduMVgvTEdBMTVMLzlS?= =?utf-8?B?aDVNb0pwK0xrZ1FIRWhDS21COFdlUm1JNVluclBTTitMc05PTTJlQU1kRHZZ?= =?utf-8?B?NEM5cUovLzJYTnY2bDMvUUpHVHYyN3dzVnBJS2t0RUVvQXNEa0MwbkFpTWlP?= =?utf-8?B?SlhyeklGTDUxTTlGK05ieTYyYW5BUmRpczliaEtvdTBRUlM4OExDblNuSEdI?= =?utf-8?B?Tk04MFZrRkhJclZRNnJNcDQyblNscXRXQTFCOUVVcWR2MnVFRjVaRlJJN1hI?= =?utf-8?B?UUFVYnlTTXMwMEpROXJsclNrUDVXeTV4aVpoU1c4MU95TW1mQStZOGdGVkkz?= =?utf-8?B?bWlERUorejROY3puTVRiaU1DM1lFV2wyTnh2MDBiUncwTGdaSEZ3M1p6VGtD?= =?utf-8?B?V0FJVVpHWURUdkdqVjlCMVNNZFdIWUNUNWVXa0tyaTFsUkxySnYrRkRydWZu?= =?utf-8?B?N2VXbjRKcEkzVlJCVFBLdjBBWG00Um12ZzhFTHVydkpoWE9CZnoyampXNTBk?= =?utf-8?B?ZWt5cTczNEMxQTFJWDVLVEo0MXUzWVZoUDVHUnkwWkQwL1VVY1o1UDd6dHRE?= =?utf-8?B?RzZjTHlGenFRYTFpNGVkYmNCVUg4NXdOd2hyZjh3WlVDV2pIWnhsZWlwOEg3?= =?utf-8?B?MXVFcTFhcDFEclJRMzQxM2t3MDlzNzd1K1BKb0VwR3JFQncxUFEyZFVWVU5C?= =?utf-8?B?K0pYVnZGNzBVV1JJWEQxb280cXo0UitvbHZCYWJQeFlmS2JJOWl4SlE4Tkdq?= =?utf-8?B?VWY0SWdnM1g0aXVWSHQ5WFJwTGpzZjY3ZzdzVjhiVElaL2dPdmE1WExCN1Aw?= =?utf-8?B?aWtLaEVGMjRMSUpiZ0FlV01YcEpJQlBvSDNCcGt5ZWczUFU0VjZjbWN4NzQz?= =?utf-8?B?Rm0vWTROcnNOSHh1b1FVb3NwNmJHQ2p1d1pWLzNPa2ZQck4zYituZ2Z1Vy8z?= =?utf-8?B?T2VuOXVJVTVKMWZ1Q1NKQjBWbUh6aktBZnBuMTNIWDRRa3JRSTNQZk1XQlM5?= =?utf-8?B?RTBxM2IyL1E5UzRLckt6Sm1McmNnTTExK2NxdGZqUDk3ODlZVmo3Y3dERU9D?= =?utf-8?B?QWJMWDNRcHFKd003amhKamRsT0I3Q2hJMUdoNnRRQml1K0s0Zjc0aWtZZEFV?= =?utf-8?B?UU44MnRCaktSV1pWcjlsaFRMVGJLZ1FycXNLRmpCR0xObGdpVSt5N002Zjg4?= =?utf-8?B?aDloaUMwYzVya2Z2QzJ2aUROcml0TXRMME0vOHhoL1YwYytEL0xOUWZ2RVBZ?= =?utf-8?B?eEtpN2xFbW4rZERuMVFsamNGenlBSW9YNER4NjBiZit3dXZBQ0U2aldlQnV6?= =?utf-8?Q?QavOQk1AWfhj9aIaC3o0CBFzD?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8e5dbc5-e975-47fc-0570-08da8fc78d8a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 05:20:46.9286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qoSy2GE9/yJhZDHHwQ9nIIu0BB0j30dX4ld2ZdWjczGYGEABfomJHWlr2p/4wyYZHYztsDp0vfKZGs8JBHnIew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6927 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On 8/31/2022 8:04 PM, Pali Rohár wrote: > PING???? Please cc me for freescale ppc boards. The patches not show in my patchwork[freenix]. I will put your patches into CI now. Thanks, Peng. > > On Sunday 21 August 2022 12:30:04 Pali Rohár wrote: >> PING???? I have not received any response for these patches. >> Why you are ignoring me? >> >> You have already merged commit "board: freescale: p1_p2_rdb_pc: >> Implement board_reset()" from v1 of this patch series >> https://source.denx.de/u-boot/u-boot/-/commit/20fb58fc5a1c83ee0085b2e9f7ecda8b761a5592 >> without applying reset workaround commit from v1 (also available in v2) >> which effectively broke reset support in U-Boot. >> >> Why you are continuing breaking P1/P2 boards? >> >> Patches for this are already waiting on the list. >> >> On Monday 01 August 2022 15:31:43 Pali Rohár wrote: >>> CPLD's system reset register on P1/P2 RDB boards is not autocleared after >>> flipping it. If this register is set to one in 100ms after reset starts >>> then CPLD triggers another CPU reset. >>> >>> This means that trying to reset board via CPLD system reset register cause >>> reboot loop. To prevent this reboot loop, the only workaround is to try to >>> clear CPLD's system reset register as early as possible. U-Boot is already >>> doing it in its board_early_init_f() function, which seems to be enough as >>> register is cleared prior CPLD triggers another reset. >>> >>> But board_early_init_f() is not called from SPL and therefore usage of SPL >>> can cause reboot loop. >>> >>> To prevent reboot loop when using SPL, call board_early_init_f() function >>> in SPL too. For accessing CPLD memory space it is needed to have CPLD entry >>> in TLB. >>> >>> With this change it is possible to trigger board reset via CPLD's system >>> reset register on P2020 RDB board. >>> >>> Signed-off-by: Pali Rohár >>> --- >>> Changes in v2: >>> * Resend patch >>> * Update comment about watchdog >>> --- >>> board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 13 +++++++++++++ >>> board/freescale/p1_p2_rdb_pc/spl.c | 6 ++++++ >>> board/freescale/p1_p2_rdb_pc/tlb.c | 2 +- >>> 3 files changed, 20 insertions(+), 1 deletion(-) >>> >>> diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c >>> index 343059c09c36..84e1d65cdb1f 100644 >>> --- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c >>> +++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c >>> @@ -97,6 +97,19 @@ void board_cpld_init(void) >>> out_8(&cpld_data->status_led, CPLD_STATUS_LED); >>> out_8(&cpld_data->fxo_led, CPLD_FXO_LED); >>> out_8(&cpld_data->fxs_led, CPLD_FXS_LED); >>> + >>> + /* >>> + * CPLD's system reset register on P1/P2 RDB boards is not autocleared >>> + * after flipping it. If this register is set to one then CPLD triggers >>> + * reset of CPU in few ms. >>> + * >>> + * CPLD does not trigger reset of CPU for 100ms after the last reset. >>> + * >>> + * This means that trying to reset board via CPLD system reset register >>> + * cause reboot loop. To prevent this reboot loop, the only workaround >>> + * is to try to clear CPLD's system reset register as early as possible >>> + * and it has to be done in 100ms since the last start of reset. >>> + */ >>> out_8(&cpld_data->system_rst, CPLD_SYS_RST); >>> } >>> >>> diff --git a/board/freescale/p1_p2_rdb_pc/spl.c b/board/freescale/p1_p2_rdb_pc/spl.c >>> index 22156f2824ec..def28665960d 100644 >>> --- a/board/freescale/p1_p2_rdb_pc/spl.c >>> +++ b/board/freescale/p1_p2_rdb_pc/spl.c >>> @@ -31,6 +31,12 @@ void board_init_f(ulong bootflag) >>> u32 plat_ratio, bus_clk; >>> ccsr_gur_t *gur = (void *)CONFIG_SYS_MPC85xx_GUTS_ADDR; >>> >>> + /* >>> + * Call board_early_init_f() as early as possible as it workarounds >>> + * reboot loop due to broken CPLD state machine for reset line. >>> + */ >>> + board_early_init_f(); >>> + >>> console_init_f(); >>> >>> /* Set pmuxcr to allow both i2c1 and i2c2 */ >>> diff --git a/board/freescale/p1_p2_rdb_pc/tlb.c b/board/freescale/p1_p2_rdb_pc/tlb.c >>> index 13f3a1edf68d..2d431d6d0d90 100644 >>> --- a/board/freescale/p1_p2_rdb_pc/tlb.c >>> +++ b/board/freescale/p1_p2_rdb_pc/tlb.c >>> @@ -61,11 +61,11 @@ struct fsl_e_tlb_entry tlb_table[] = { >>> MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G, >>> 0, 5, BOOKE_PAGESZ_1M, 1), >>> #endif >>> +#endif /* not SPL */ >>> >>> SET_TLB_ENTRY(1, CONFIG_SYS_CPLD_BASE, CONFIG_SYS_CPLD_BASE_PHYS, >>> MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G, >>> 0, 6, BOOKE_PAGESZ_1M, 1), >>> -#endif /* not SPL */ >>> >>> #ifdef CONFIG_SYS_NAND_BASE >>> /* *I*G - NAND */ >>> -- >>> 2.20.1 >>>