From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:44278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726814AbfACPpB (ORCPT ); Thu, 3 Jan 2019 10:45:01 -0500 From: David Howells In-Reply-To: <9531.1546529229@warthog.procyon.org.uk> References: <9531.1546529229@warthog.procyon.org.uk> <10060.1546522863@warthog.procyon.org.uk> <20190102233118.GA19202@gmail.com> <20181229000400.26333-1-avagin@gmail.com> <20181228235900.21468-1-avagin@gmail.com> <21902.1546467980@warthog.procyon.org.uk> <20190102230655.GA8616@gmail.com> Cc: dhowells@redhat.com, Andrei Vagin , Alexander Viro , linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, Li Zefan Subject: Re: [PATCH vfs/for-next v2] cgroup: fix top cgroup refcnt leak MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <10217.1546530298.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 03 Jan 2019 15:44:58 +0000 Message-ID: <10218.1546530298@warthog.procyon.org.uk> To: unlisted-recipients:; (no To-header on input) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: David Howells wrote: > I'm not sure the refcount is correct after the second block (at the end of the > second mount). Should it have one ref per active sb? No, it shouldn't because there's only one sb. David