From: Thomas Monjalon <thomas@monjalon.net>
To: "Michał Krawczyk" <mk@semihalf.com>,
"Ferruh Yigit" <ferruh.yigit@intel.com>,
andrew.rybchenko@oktetlabs.ru
Cc: dev <dev@dpdk.org>, "Dagan, Noam" <ndagan@amazon.com>,
"Brandes, Shai" <shaibran@amazon.com>,
upstream@semihalf.com, Shay Agroskin <shayagr@amazon.com>,
Amit Bernstein <amitbern@amazon.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration
Date: Fri, 23 Jul 2021 15:19:43 +0200 [thread overview]
Message-ID: <10234991.2QsWa68MMy@thomas> (raw)
In-Reply-To: <1861470.fCPsIMDXia@thomas>
23/07/2021 13:52, Thomas Monjalon:
> 23/07/2021 11:49, Michał Krawczyk:
> > pt., 23 lip 2021 o 11:43 Thomas Monjalon <thomas@monjalon.net> napisał(a):
> > > 23/07/2021 11:39, Michał Krawczyk:
> > > > pt., 23 lip 2021 o 11:22 Thomas Monjalon <thomas@monjalon.net> napisał(a):
> > > > > 14/07/2021 12:43, Michal Krawczyk:
> > > > > > + PMD_DRV_LOG(WARNING,
> > > > > > + "Setting RSS hash fields is not supported. Using default values: 0x%llx\n",
> > > > > > + ENA_ALL_RSS_HF);
> > > > > >
> > > > >
> > > > > checkpatch is returning this warning:
> > > > > Using %l format, prefer %PRI*64 if type is [u]int64_t
> > > > >
> > > > > Indeed rss_hf is uint64_t.
> >
> > Yeah, sure, casting ENA_RSS_HF to uint64_t in this log should do the
> > trick - I'll fix that in the v4.
>
> I think you should declare ENA_RSS_HF with UINT64_C()
The real fix is probably to declare all ETH_RSS_*
and other bits in ethdev with the right RTE_BIT* macro.
Call for volunteers to fix that API in DPDK 21.11...
next prev parent reply other threads:[~2021-07-23 13:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 15:41 [dpdk-dev] [PATCH 0/6] net/ena: v2.4.0 driver update Michal Krawczyk
2021-07-13 15:41 ` [dpdk-dev] [PATCH 1/6] net/ena: adjust driver logs Michal Krawczyk
2021-07-13 15:41 ` [dpdk-dev] [PATCH 2/6] net/ena: make use of the IO debug build option Michal Krawczyk
2021-07-13 15:41 ` [dpdk-dev] [PATCH 3/6] net/ena: trigger reset when Tx prepare fails Michal Krawczyk
2021-07-13 15:41 ` [dpdk-dev] [PATCH 4/6] net/ena: add support for Rx interrupts Michal Krawczyk
2021-07-13 15:41 ` [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration Michal Krawczyk
2021-07-14 8:04 ` Vladimir Medvedkin
2021-07-14 8:20 ` Michał Krawczyk
2021-07-14 11:43 ` Vladimir Medvedkin
2021-07-14 12:07 ` Michał Krawczyk
2021-07-13 15:41 ` [dpdk-dev] [PATCH 6/6] net/ena: update version to v2.4.0 Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 0/6] net/ena: v2.4.0 driver update Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 1/6] net/ena: adjust driver logs Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 2/6] net/ena: make use of the IO debug build option Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 3/6] net/ena: trigger reset when Tx prepare fails Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 4/6] net/ena: add support for Rx interrupts Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 5/6] net/ena: rework RSS configuration Michal Krawczyk
2021-07-14 10:34 ` [dpdk-dev] [PATCH v2 6/6] net/ena: update version to v2.4.0 Michal Krawczyk
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 0/6] net/ena: v2.4.0 driver update Michal Krawczyk
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 1/6] net/ena: adjust driver logs Michal Krawczyk
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 2/6] net/ena: make use of the IO debug build option Michal Krawczyk
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 3/6] net/ena: trigger reset when Tx prepare fails Michal Krawczyk
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 4/6] net/ena: add support for Rx interrupts Michal Krawczyk
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration Michal Krawczyk
2021-07-23 9:23 ` Thomas Monjalon
2021-07-23 9:39 ` Michał Krawczyk
2021-07-23 9:44 ` Thomas Monjalon
2021-07-23 9:49 ` Michał Krawczyk
2021-07-23 11:52 ` Thomas Monjalon
2021-07-23 13:19 ` Thomas Monjalon [this message]
2021-07-14 10:43 ` [dpdk-dev] [PATCH v3 6/6] net/ena: update version to v2.4.0 Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 0/6] net/ena: v2.4.0 driver update Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 1/6] net/ena: adjust driver logs Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 2/6] net/ena: make use of the IO debug build option Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 3/6] net/ena: trigger reset when Tx prepare fails Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 4/6] net/ena: add support for Rx interrupts Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 5/6] net/ena: rework RSS configuration Michal Krawczyk
2021-07-23 10:24 ` [dpdk-dev] [PATCH v4 6/6] net/ena: update version to v2.4.0 Michal Krawczyk
2021-07-23 15:46 ` [dpdk-dev] [PATCH v4 0/6] net/ena: v2.4.0 driver update Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10234991.2QsWa68MMy@thomas \
--to=thomas@monjalon.net \
--cc=amitbern@amazon.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mk@semihalf.com \
--cc=ndagan@amazon.com \
--cc=shaibran@amazon.com \
--cc=shayagr@amazon.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.