From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] mem: store memory mode flags in shared config Date: Thu, 04 Oct 2018 00:05:23 +0200 Message-ID: <102589449.7KdqRJ0jb8@xps> References: <98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, John McNamara , Marko Kovacevic To: Anatoly Burakov Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B1DE31B454 for ; Thu, 4 Oct 2018 00:05:26 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/09/2018 17:41, Anatoly Burakov: > Currently, command-line switches for legacy mem mode or single-file > segments mode are only stored in internal config. This leads to a > situation where these flags have to always match between primary > and secondary, which is bad for usability. > > Fix this by storing these flags in the shared config as well, so > that secondary process can know if the primary was launched in > single-file segments or legacy mem mode. > > This bumps the EAL ABI, however there's an EAL deprecation notice > already in place[1] for a different feature, so that's OK. > > [1] http://patches.dpdk.org/patch/43502/ > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2: > - Added documentation on ABI break > > doc/guides/rel_notes/rel_description.rst | 5 +++++ Removed change in this file (dup of release note). > doc/guides/rel_notes/release_18_11.rst | 6 +++++- > .../common/include/rte_eal_memconfig.h | 4 ++++ > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > lib/librte_eal/linuxapp/eal/eal.c | 20 +++++++++++++++++++ > lib/librte_eal/meson.build | 2 +- > 6 files changed, 36 insertions(+), 3 deletions(-) Applied (without extra note), thanks.