From: Lee Duncan <lduncan@suse.com>
To: Bob Liu <bob.liu@oracle.com>, <open-iscsi@googlegroups.com>
Cc: <cleech@redhat.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>
Subject: Re: [RFC RESEND PATCH v2] scsi: iscsi: register sysfs for iscsi workqueue
Date: Mon, 25 May 2020 07:28:12 -0700 [thread overview]
Message-ID: <102630b7-f126-a478-ba73-06f863438982@suse.com> (raw)
In-Reply-To: <8d830a89-c554-7de9-a33a-987d117e99fb@oracle.com>
On 5/25/20 2:16 AM, Bob Liu wrote:
> friendly ping.
>
> On 5/5/20 9:19 AM, Bob Liu wrote:
>> Motivation:
>> This patch enable setting cpu affinity through "cpumask" for iscsi workqueues
>> (iscsi_q_xx and iscsi_eh), so as to get performance isolation.
>>
>> The max number of active worker was changed form 1 to 2, because "cpumask" of
>> ordered workqueue isn't allowed to change.
>>
>> Notes:
>> - Having 2 workers break the current ordering guarantees, please let me know
>> if anyone depends on this.
>>
>> - __WQ_LEGACY have to be left because of
>> 23d11a5(workqueue: skip flush dependency checks for legacy workqueues)
>>
>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>> ---
>> drivers/scsi/libiscsi.c | 4 +++-
>> drivers/scsi/scsi_transport_iscsi.c | 4 +++-
>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
>> index 70b99c0..adf9bb4 100644
>> --- a/drivers/scsi/libiscsi.c
>> +++ b/drivers/scsi/libiscsi.c
>> @@ -2627,7 +2627,9 @@ struct Scsi_Host *iscsi_host_alloc(struct scsi_host_template *sht,
>> if (xmit_can_sleep) {
>> snprintf(ihost->workq_name, sizeof(ihost->workq_name),
>> "iscsi_q_%d", shost->host_no);
>> - ihost->workq = create_singlethread_workqueue(ihost->workq_name);
>> + ihost->workq = alloc_workqueue("%s",
>> + WQ_SYSFS | __WQ_LEGACY | WQ_MEM_RECLAIM | WQ_UNBOUND,
>> + 2, ihost->workq_name);
>> if (!ihost->workq)
>> goto free_host;
>> }
>> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
>> index dfc726f..bdbc4a2 100644
>> --- a/drivers/scsi/scsi_transport_iscsi.c
>> +++ b/drivers/scsi/scsi_transport_iscsi.c
>> @@ -4602,7 +4602,9 @@ static __init int iscsi_transport_init(void)
>> goto unregister_flashnode_bus;
>> }
>>
>> - iscsi_eh_timer_workq = create_singlethread_workqueue("iscsi_eh");
>> + iscsi_eh_timer_workq = alloc_workqueue("%s",
>> + WQ_SYSFS | __WQ_LEGACY | WQ_MEM_RECLAIM | WQ_UNBOUND,
>> + 2, "iscsi_eh");
>> if (!iscsi_eh_timer_workq) {
>> err = -ENOMEM;
>> goto release_nls;
>>
>
Reviewed-by: Lee Duncan <lduncan@suse.com>
next prev parent reply other threads:[~2020-05-25 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 1:19 [RFC RESEND PATCH v2] scsi: iscsi: register sysfs for iscsi workqueue Bob Liu
2020-05-15 0:09 ` Martin K. Petersen
2020-05-25 9:16 ` Bob Liu
2020-05-25 14:28 ` Lee Duncan [this message]
2020-05-27 2:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102630b7-f126-a478-ba73-06f863438982@suse.com \
--to=lduncan@suse.com \
--cc=bob.liu@oracle.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.