From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A4C02FAF for ; Sat, 22 May 2021 07:29:29 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so8604991wmk.1 for ; Sat, 22 May 2021 00:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BteD19/XIMy7sPKSp1FwggzNL7lWZZ0MvdiM4zhFQzc=; b=Bo15U9Y20Hqb3NlsFgxT3yszVwDyhuDGbpVOBCujpbnsPmteKa/z8y5SpAhnV2Gnyp SoJxCuBigGF+QWO69FsRYTvpvqr7FWs90dhyFheLpGldqzTW7nY2uUZorHFRM35jz/Ug 2VDPS7Y3Kpi6R5XyE06Nad+Jl0DGIO/bkULFA45jO+lT05B+3valBRi5YGeS8CxiQp1Y DljyhPdR+r9+Fugom1ciFE2c1EFKJ5JTOC8Z1h6PySU5NXsaR2yDoi16fQEzD0QNEMuk UsUpF+Jscf0ujBCx3uRiIF34fL45zEDMfy5wp1wOX9RcN6qAFGZlqvWbsYvNXe1JXnWw inNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BteD19/XIMy7sPKSp1FwggzNL7lWZZ0MvdiM4zhFQzc=; b=tKkGpyVq+XuE4Ue0CbiUr+B6MuGPbHu7bEL2vIO+8eoOEZXUlsdU2Ian3Ayk8V3dzd bRjVSiTuYzuzFirp+pwQNYGc22DINf+AuDPqnvrdr4YbAv+BpNwtmYkVoq+TWwnyjm8+ qC3h+9S1wJOQvQuyI6qjWmz/bxkLJW94OUsNHrDTVZ+d+R/8a3YwKv/sg9E/GIlxdhvd qdoi2Cg8/CZwFknuDH8zvUEhIstNId/ohDeZLgRWVYelK4U460ksys6kNTJf9nbeAZRu bWFgR0+HkRoINe930DDSRX1X3mQ/4zzMFWZZ04xOrD1bltfo9NVxOICUQ8DgHrtclc0B p5uQ== X-Gm-Message-State: AOAM531YxUgqdhSVO5Hv+tnCu7o3noAJiYfDL4GjbGDH7VrQbHUP6LQX eKRr2L1bRMCCVCDsxuTPlcoNyKLTYvIwIw== X-Google-Smtp-Source: ABdhPJxdyxnpBOl7HA9WGGTO11eaFSwsnPhX0cbz4gXc8j4i+pmAwPZLypk9MiEz337ZzicvShO/Xg== X-Received: by 2002:a1c:402:: with SMTP id 2mr11902978wme.7.1621668568203; Sat, 22 May 2021 00:29:28 -0700 (PDT) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net. [86.58.17.133]) by smtp.gmail.com with ESMTPSA id r5sm2044992wmh.23.2021.05.22.00.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 May 2021 00:29:27 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Rob Herring , Icenowy Zheng , Samuel Holland , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v6 05/17] rtc: sun6i: Add Allwinner H616 support Date: Sat, 22 May 2021 09:29:26 +0200 Message-ID: <10265315.EKgO2cQaHd@kista> In-Reply-To: <20210519104152.21119-6-andre.przywara@arm.com> References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-6-andre.przywara@arm.com> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Andre! Dne sreda, 19. maj 2021 ob 12:41:40 CEST je Andre Przywara napisal(a): > The H616 RTC changes its day storage to the newly introduced linear day > scheme, so pair the new compatible string with this feature flag. > So far the clock parts seem to be the same as the H6, so combine the > compatible string with the existing H6 support bits. There is one more difference - H616 alarm value is now broken down to days, hours, minutes and seconds. Best regards, Jernej > > Signed-off-by: Andre Przywara > --- > drivers/rtc/rtc-sun6i.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > index 0228e9dfd969..ec0cd0ee539a 100644 > --- a/drivers/rtc/rtc-sun6i.c > +++ b/drivers/rtc/rtc-sun6i.c > @@ -382,6 +382,8 @@ static void __init sun50i_h6_rtc_clk_init(struct device_node *node) > } > CLK_OF_DECLARE_DRIVER(sun50i_h6_rtc_clk, "allwinner,sun50i-h6-rtc", > sun50i_h6_rtc_clk_init); > +CLK_OF_DECLARE_DRIVER(sun50i_h616_rtc_clk, "allwinner,sun50i-h616-rtc", > + sun50i_h6_rtc_clk_init); > > /* > * The R40 user manual is self-conflicting on whether the prescaler is > @@ -773,6 +775,8 @@ static const struct of_device_id sun6i_rtc_dt_ids[] = { > { .compatible = "allwinner,sun8i-v3-rtc" }, > { .compatible = "allwinner,sun50i-h5-rtc" }, > { .compatible = "allwinner,sun50i-h6-rtc" }, > + { .compatible = "allwinner,sun50i-h616-rtc", > + .data = (void *)RTC_LINEAR_DAY }, > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, sun6i_rtc_dt_ids); > -- > 2.17.5 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56593C2B9F2 for ; Sat, 22 May 2021 07:31:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7F8861164 for ; Sat, 22 May 2021 07:31:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7F8861164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hk6E+Uno1EY5BCYzcBmPnH2twkarxMwA64t4qWeEGzE=; b=qzcxkjNqeno300RJybQ2UFj+Fy 7rCGP+vsDe/WCVliAZ2+ClGX8WqED4niluEqxbMoFgPeN/169xjjO04tiF/ncrj9SVqNDnyZUf8G7 w++KUJteKs2EOdLg99FATmEIEtNBk05kR/oWWKQ3OR72Qhy59Hdj94e/57THXCxg1LNfppCQz4W5e A8okItwBtquwuqzc0JiG5utqTgfB47axgwX6vcdDpek+kTXdYSFOWEGX3hnvrHZeEyMWagSFnolFR udYkzJai7fT1YK2KNUwfClfuOc4p9WU9AkT1x0hpvXl23P/id8iuVrEatwxggcybIdKEx+ovW+5qM Bhh9guvw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkM4m-0022ZE-Ce; Sat, 22 May 2021 07:29:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkM4i-0022Yq-5w for linux-arm-kernel@desiato.infradead.org; Sat, 22 May 2021 07:29:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=BteD19/XIMy7sPKSp1FwggzNL7lWZZ0MvdiM4zhFQzc=; b=r0KsGUjl8fItcWGPcdSip22rnu kKu2dTAyHQ+xf+HozGIUkqBKN1OpdjkJmZkSmnhPPzcR2zbkBQRD5QM0esa6jWOvlENTINhTyWlqD muuCey0TTKwQPYhlcta4Efux0kfzVlLcrCHViT4AUqRX4jXX5IHvphlaQNMCrvmesHf4dqRkN310z FLt8Pc1N53ISnFMVNnTkliDCFd5CF8dr2XlsZywr9fU9glrfFpX9TA7ocTEhDzUy23Bl/xxyjjt/m OaMSdThQQe7ou43qD7Wf2pV8nMOZPQ3T2aJ1X33bMMp6YYZxHn1PJLnjjHvvae8Db+YP+9j6WQ6Ra 2yQqyMbA==; Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkM4f-0002F9-IJ for linux-arm-kernel@lists.infradead.org; Sat, 22 May 2021 07:29:30 +0000 Received: by mail-wm1-x330.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso8577935wmh.4 for ; Sat, 22 May 2021 00:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BteD19/XIMy7sPKSp1FwggzNL7lWZZ0MvdiM4zhFQzc=; b=Bo15U9Y20Hqb3NlsFgxT3yszVwDyhuDGbpVOBCujpbnsPmteKa/z8y5SpAhnV2Gnyp SoJxCuBigGF+QWO69FsRYTvpvqr7FWs90dhyFheLpGldqzTW7nY2uUZorHFRM35jz/Ug 2VDPS7Y3Kpi6R5XyE06Nad+Jl0DGIO/bkULFA45jO+lT05B+3valBRi5YGeS8CxiQp1Y DljyhPdR+r9+Fugom1ciFE2c1EFKJ5JTOC8Z1h6PySU5NXsaR2yDoi16fQEzD0QNEMuk UsUpF+Jscf0ujBCx3uRiIF34fL45zEDMfy5wp1wOX9RcN6qAFGZlqvWbsYvNXe1JXnWw inNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BteD19/XIMy7sPKSp1FwggzNL7lWZZ0MvdiM4zhFQzc=; b=uK8kuQ8ERRUe0esQagGCAVi5q3neB2tXrdclrCZxt1Qc5qtNJRUCKwbGA5cpWNfpMm DA+VTKx+MkhWixcWGHMUC6QdTmcLPZrvR1rnrqdEsD7/eY3Toje1YwvfqOwWZw/c5sjB DSR7KbouUGP/LH+G7O4l1PgJHzARbUDyU+hpoNw/0YVD5YLDKDir7NqGh6RK+2+N+GBe nF+cKNL/w5Uxt78kguPNDbRCqlyL/Vx06ZFg+OwVi9sRsGHpxNNkClnVDtg++lJzajAx P5Kuyj6aHiPCmcNYZhOqXmNPwi0006i/REIM6yUUgWMdsWUhSnrvaFYWgLhbEdFdpN6G FC3Q== X-Gm-Message-State: AOAM530R3DsnqSKMz+eazl9ilZRU7lrrWE/VCDQuzNc7CzJ93e0JngFO jlLn8vCu+5vmGNfYWo9bMsQ= X-Google-Smtp-Source: ABdhPJxdyxnpBOl7HA9WGGTO11eaFSwsnPhX0cbz4gXc8j4i+pmAwPZLypk9MiEz337ZzicvShO/Xg== X-Received: by 2002:a1c:402:: with SMTP id 2mr11902978wme.7.1621668568203; Sat, 22 May 2021 00:29:28 -0700 (PDT) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net. [86.58.17.133]) by smtp.gmail.com with ESMTPSA id r5sm2044992wmh.23.2021.05.22.00.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 May 2021 00:29:27 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Rob Herring , Icenowy Zheng , Samuel Holland , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v6 05/17] rtc: sun6i: Add Allwinner H616 support Date: Sat, 22 May 2021 09:29:26 +0200 Message-ID: <10265315.EKgO2cQaHd@kista> In-Reply-To: <20210519104152.21119-6-andre.przywara@arm.com> References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-6-andre.przywara@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210522_002929_636623_6A7A042B X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre! Dne sreda, 19. maj 2021 ob 12:41:40 CEST je Andre Przywara napisal(a): > The H616 RTC changes its day storage to the newly introduced linear day > scheme, so pair the new compatible string with this feature flag. > So far the clock parts seem to be the same as the H6, so combine the > compatible string with the existing H6 support bits. There is one more difference - H616 alarm value is now broken down to days, hours, minutes and seconds. Best regards, Jernej > > Signed-off-by: Andre Przywara > --- > drivers/rtc/rtc-sun6i.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > index 0228e9dfd969..ec0cd0ee539a 100644 > --- a/drivers/rtc/rtc-sun6i.c > +++ b/drivers/rtc/rtc-sun6i.c > @@ -382,6 +382,8 @@ static void __init sun50i_h6_rtc_clk_init(struct device_node *node) > } > CLK_OF_DECLARE_DRIVER(sun50i_h6_rtc_clk, "allwinner,sun50i-h6-rtc", > sun50i_h6_rtc_clk_init); > +CLK_OF_DECLARE_DRIVER(sun50i_h616_rtc_clk, "allwinner,sun50i-h616-rtc", > + sun50i_h6_rtc_clk_init); > > /* > * The R40 user manual is self-conflicting on whether the prescaler is > @@ -773,6 +775,8 @@ static const struct of_device_id sun6i_rtc_dt_ids[] = { > { .compatible = "allwinner,sun8i-v3-rtc" }, > { .compatible = "allwinner,sun50i-h5-rtc" }, > { .compatible = "allwinner,sun50i-h6-rtc" }, > + { .compatible = "allwinner,sun50i-h616-rtc", > + .data = (void *)RTC_LINEAR_DAY }, > { /* sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, sun6i_rtc_dt_ids); > -- > 2.17.5 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel