From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506E8C07E9D for ; Tue, 27 Sep 2022 13:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232777AbiI0N5d (ORCPT ); Tue, 27 Sep 2022 09:57:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbiI0N5S (ORCPT ); Tue, 27 Sep 2022 09:57:18 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A10D4146F9D for ; Tue, 27 Sep 2022 06:57:13 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 10so15862977lfy.5 for ; Tue, 27 Sep 2022 06:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ev3n3HXsdxmctruPXinckwm0/GHt4MhpPRr9m0oOsZc=; b=Bg3/vWwxHWbjWj+yyqdJTk09hhh/aL9pHflbIUI6Lnhex/jdIXnWo97O4rpLarE4k/ YnO54AwZUehrw1kGbcEYJNIhJJDKW8XAM8TSOgpnq2YCbDQctFYJQyJDVT2a+aquyQFF SbXR1A8jHGrzXakcSYBebs6Howdb3o/VWjoPLt9TBqg5QIV9p2O0mxJlzlTWVND7GEwk m1RDnZNEeLkLzoDgHyxN4tuxoxt0MUqaxDuepIm1GzBXdSSkjBspxvoDen3ydYRi9Vuo MWq64ggmaStqY3MpKxYl2xhwwWV5kwhjBX73w8d+heu5r1Mth2kObEPHol9+GksUioYu UN8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ev3n3HXsdxmctruPXinckwm0/GHt4MhpPRr9m0oOsZc=; b=G60B9Khl50aBUvIZCIkfQBDJLHw4G4WeGGSCsfmh1ZfVF55gHuWQUR2s+5b258AUJY j1WYxWUPirzhzWeGc72odk1iRzpTNDx3/SzQI5ty/bDpd4atW35+KV5PHNPC4P/U7oNv xY2BkGbxLRpipsNxvMsNGpTkO8sC5wi7ZJhRL4OOPrwZUx1noj1gKphcqaGq2XB7l2p/ PhZ6Ra9+hvSjbAVNPpZ3S4u/+F9sEt+ddm3/X98B37mMP+mhpHAKdufjDBFbJoxN8J8j tTqCJW72n4GvVwi9SmrFkc2RVHOpZKkJIoJYNtwzGfgSke72Yty5smHc6UISLAeYxHQM Z4+A== X-Gm-Message-State: ACrzQf3ozNyS8NBcUSusUgfd+GriRd5HZDNFyC7szSzm+8lM5BhQ7Qoy bEsbT6+uArHG7aQAW689PD3ofQ== X-Google-Smtp-Source: AMsMyM6M47O8+8lVhBzSBboPo/7X+DVhNqB4VwbBpU1UI/8S5RUtO9VL4jj56EPB413fC/SuD5EwBA== X-Received: by 2002:ac2:464b:0:b0:49e:b29c:2b04 with SMTP id s11-20020ac2464b000000b0049eb29c2b04mr10772069lfo.127.1664287031342; Tue, 27 Sep 2022 06:57:11 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id i18-20020a056512007200b004a1e592837esm170924lfo.140.2022.09.27.06.57.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 06:57:09 -0700 (PDT) Message-ID: <1029e512-02f0-8d08-2994-6440fa9c033d@linaro.org> Date: Tue, 27 Sep 2022 15:57:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 25/32] dt-bindings: pinctrl: qcom,qcm2290: do not require function on non-GPIOs Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Sricharan R , Stephan Gerhold , Shawn Guo , Vinod Koul , krishna Lanka , Sivaprakash Murugesan , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220924080459.13084-1-krzysztof.kozlowski@linaro.org> <20220924080459.13084-26-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 27/09/2022 13:42, Dmitry Baryshkov wrote: > On Sat, 24 Sept 2022 at 11:07, Krzysztof Kozlowski > wrote: >> >> Certain pins, like SDcard related, do not have functions and such should >> not be required. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> index 5324b61eb4f7..89453cb60c12 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> @@ -60,7 +60,6 @@ patternProperties: >> description: >> Pinctrl node's client devices use subnodes for desired pin configuration. >> Client device subnodes use below standard properties. >> - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" >> >> properties: >> pins: >> @@ -116,6 +115,16 @@ patternProperties: >> required: >> - pins >> >> + allOf: > > Nit: I think you can drop allOf here and move the $ref up a few lines. > It's anyway different in v2 - there is no if:then. Best regards, Krzysztof