On 2021-03-22 10:11, kernel test robot wrote:
> Hi Marc,
> 
> FYI, the error/warning still remains.

Please, can you stop emailing be for trees I have no control over?

Yes, this patch is completely broken. But there is nothing I can
do about it as I don't own the tree this is merged on.

Thanks,

         M.

> 
> tree:   https://github.com/frank-w/BPI-R2-4.14 5.12-hnat
> head:   79ba85605b096ebba4359684a0e5d719541e14fb
> commit: 985198ae531b3360e32967e50a2f2a3fc07075ab [3/11] pci: fix MSI
> issue part 2
> config: i386-randconfig-a003-20210322 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         #
> https://github.com/frank-w/BPI-R2-4.14/commit/985198ae531b3360e32967e50a2f2a3fc07075ab
>         git remote add frank-w-bpi-r2-4.14
> https://github.com/frank-w/BPI-R2-4.14
>         git fetch --no-tags frank-w-bpi-r2-4.14 5.12-hnat
>         git checkout 985198ae531b3360e32967e50a2f2a3fc07075ab
>         # save the attached .config to linux build tree
>         make W=1 ARCH=i386
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/pci/probe.c: In function 'pci_register_host_bridge':
>>> drivers/pci/probe.c:930:39: error: 'struct device' has no member 
>>> named 'msi_domain'; did you mean 'pm_domain'?
>      930 |      (bridge->msi_domain && !bus->dev.msi_domain))
>          |                                       ^~~~~~~~~~
>          |                                       pm_domain
> 
> 
> vim +930 drivers/pci/probe.c
> 
>    904
>    905		b = pci_find_bus(pci_domain_nr(bus), bridge->busnr);
>    906		if (b) {
>    907			/* Ignore it if we already got here via a different bridge */
>    908			dev_dbg(&b->dev, "bus already known\n");
>    909			err = -EEXIST;
>    910			goto free;
>    911		}
>    912
>    913		dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(bus),
>    914			     bridge->busnr);
>    915
>    916		err = pcibios_root_bridge_prepare(bridge);
>    917		if (err)
>    918			goto free;
>    919
>    920		err = device_add(&bridge->dev);
>    921		if (err) {
>    922			put_device(&bridge->dev);
>    923			goto free;
>    924		}
>    925		bus->bridge = get_device(&bridge->dev);
>    926		device_enable_async_suspend(bus->bridge);
>    927		pci_set_bus_of_node(bus);
>    928		pci_set_bus_msi_domain(bus);
>    929		if (bridge->no_msi ||
>  > 930		    (bridge->msi_domain && !bus->dev.msi_domain))
>    931			bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI;
>    932
>    933		if (!parent)
>    934			set_dev_node(bus->bridge, pcibus_to_node(bus));
>    935
>    936		bus->dev.class = &pcibus_class;
>    937		bus->dev.parent = bus->bridge;
>    938
>    939		dev_set_name(&bus->dev, "%04x:%02x", pci_domain_nr(bus), 
> bus->number);
>    940		name = dev_name(&bus->dev);
>    941
>    942		err = device_register(&bus->dev);
>    943		if (err)
>    944			goto unregister;
>    945
>    946		pcibios_add_bus(bus);
>    947
>    948		if (bus->ops->add_bus) {
>    949			err = bus->ops->add_bus(bus);
>    950			if (WARN_ON(err < 0))
>    951				dev_err(&bus->dev, "failed to add bus: %d\n", err);
>    952		}
>    953
>    954		/* Create legacy_io and legacy_mem files for this bus */
>    955		pci_create_legacy_files(bus);
>    956
>    957		if (parent)
>    958			dev_info(parent, "PCI host bridge to bus %s\n", name);
>    959		else
>    960			pr_info("PCI host bridge to bus %s\n", name);
>    961
>    962		if (nr_node_ids > 1 && pcibus_to_node(bus) == NUMA_NO_NODE)
>    963			dev_warn(&bus->dev, "Unknown NUMA node; performance will be
> reduced\n");
>    964
>    965		/* Add initial resources to the bus */
>    966		resource_list_for_each_entry_safe(window, n, &resources) {
>    967			list_move_tail(&window->node, &bridge->windows);
>    968			offset = window->offset;
>    969			res = window->res;
>    970
>    971			if (res->flags & IORESOURCE_BUS)
>    972				pci_bus_insert_busn_res(bus, bus->number, res->end);
>    973			else
>    974				pci_bus_add_resource(bus, res, 0);
>    975
>    976			if (offset) {
>    977				if (resource_type(res) == IORESOURCE_IO)
>    978					fmt = " (bus address [%#06llx-%#06llx])";
>    979				else
>    980					fmt = " (bus address [%#010llx-%#010llx])";
>    981
>    982				snprintf(addr, sizeof(addr), fmt,
>    983					 (unsigned long long)(res->start - offset),
>    984					 (unsigned long long)(res->end - offset));
>    985			} else
>    986				addr[0] = '\0';
>    987
>    988			dev_info(&bus->dev, "root bus resource %pR%s\n", res, addr);
>    989		}
>    990
>    991		down_write(&pci_bus_sem);
>    992		list_add_tail(&bus->node, &pci_root_buses);
>    993		up_write(&pci_bus_sem);
>    994
>    995		return 0;
>    996
>    997	unregister:
>    998		put_device(&bridge->dev);
>    999		device_del(&bridge->dev);
>   1000
>   1001	free:
>   1002		kfree(bus);
>   1003		return err;
>   1004	}
>   1005
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

-- 
Jazz is not dead. It just smells funny...