From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbbEAAsu (ORCPT ); Thu, 30 Apr 2015 20:48:50 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:53998 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbbEAAst (ORCPT ); Thu, 30 Apr 2015 20:48:49 -0400 Date: Fri, 1 May 2015 02:48:45 +0200 (CEST) From: Stefan Wahren Reply-To: Stefan Wahren To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Mike Turquette Message-ID: <103216360.783367.1430441325553.JavaMail.open-xchange@oxbaltgw01.schlund.de> In-Reply-To: <20150501003712.GD32407@codeaurora.org> References: <1430325403-2647-1-git-send-email-stefan.wahren@i2se.com> <20150501003712.GD32407@codeaurora.org> Subject: Re: [PATCH RESEND] clk: Fix JSON output in debugfs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.0-Rev38 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:5xb+Wt8G+U23tUf9RGkot8vGuQ/JGkobc2KnKtvMyyVhReygunl LH4mQWfSURr15YduTgMYV6dz33yt85k8GGDt+mTGYmzEfDcNaGKdaXdPL9mtr21cvXtrhxr MnEupRrLcztjru/ofgSzjN6fVg/0P7LxG30rU+5AbwcOeM1BuvdMRTxliuU9vkpEnecS3qE PgtHUcE9ca9z4AcMXT9AA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Stephen Boyd hat am 1. Mai 2015 um 02:37 geschrieben: > > > On 04/29, Stefan Wahren wrote: > > key/value pairs in a JSON object must be separated by a comma. > > After adding the properties "accuracy" and "phase" the JSON output > > of /sys/kernel/debug/clk/clk_dump is invalid. > > > > So add the missing commas to fix it. > > > > Fixes: 5279fc4 ("clk: add clk accuracy retrieval support") > > Signed-off-by: Stefan Wahren > > Hmph, this regression is old, v3.14 days. We probably ought to > have a comment in here stating this should be JSON format. > > Applied to clk-next with the comment below squashed in. Thanks Stefan