All of lore.kernel.org
 help / color / mirror / Atom feed
From: mrybczyn@kalray.eu (Marta Rybczynska)
Subject: [PATCH] nvmet-rdma: Suppress a lockdep complaint
Date: Tue, 25 Jun 2019 07:52:05 +0200 (CEST)	[thread overview]
Message-ID: <1035014818.27150671.1561441925414.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <1554392625.118779.243.camel@acm.org>

----- On 4 Apr, 2019,@17:43, Bart Van Assche bvanassche@acm.org wrote:
> On Wed, 2019-04-03@16:04 -0700, Bart Van Assche wrote:
>> Although the code that waits for controllers that are being teared down
>> in nvmet_rdma_queue_connect() is fine, lockdep complains about that code.
>> Lockdep complains because all release_work instances are assigned the
>> same static lockdep key. Avoid that lockdep complains by using dynamic
>> lockdep keys instead of static lockdep keys. See also the following
>> commits:
>> * 87915adc3f0a ("workqueue: re-add lockdep dependencies for flushing").
>> * 777dc82395de ("nvmet-rdma: occasionally flush ongoing controller teardown").
>> * 108c14858b9e ("locking/lockdep: Add support for dynamic keys").
>> 
>> This patch avoids that lockdep reports the following:
>> 
>> ======================================================
>> WARNING: possible circular locking dependency detected
>> 4.19.0-dbg #1 Not tainted
>> ------------------------------------------------------
>> kworker/u12:0/7 is trying to acquire lock:
> 
> Please drop this patch - it is not sufficient to suppress the lockdep complaint.
> I will see whether I can come up with a better solution.
> 

Bart,
Have you had time to work on this one further? We're seeing the same issue.

Thanks,
Marta

  reply	other threads:[~2019-06-25  5:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 23:04 [PATCH] nvmet-rdma: Suppress a lockdep complaint Bart Van Assche
2019-04-04 15:43 ` Bart Van Assche
2019-06-25  5:52   ` Marta Rybczynska [this message]
2019-06-25 15:18     ` Bart Van Assche
2019-06-25 15:45       ` Marta Rybczynska
2023-05-08 23:34 Bart Van Assche
2023-05-09  5:39 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1035014818.27150671.1561441925414.JavaMail.zimbra@kalray.eu \
    --to=mrybczyn@kalray.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.