From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756508AbbLAOZS (ORCPT ); Tue, 1 Dec 2015 09:25:18 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:56650 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755826AbbLAOZP (ORCPT ); Tue, 1 Dec 2015 09:25:15 -0500 From: Arnd Bergmann To: Peter Ujfalusi Cc: Andy Shevchenko , Vinod Koul , "linux-kernel@vger.kernel.org" , dmaengine , Linux OMAP Mailing List , linux-arm Mailing List , "linux-mmc@vger.kernel.org" , Sekhar Nori , linux-spi Subject: Re: [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel Date: Tue, 01 Dec 2015 15:24:40 +0100 Message-ID: <103520159.g0xhtFsXUi@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <565DA47C.4000308@ti.com> References: <1448891145-10766-1-git-send-email-peter.ujfalusi@ti.com> <565DA47C.4000308@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:8liOKHsq/xithPmMuQChTX1MmKAkDxH/7kb48JXStYq9DrjSLhq PqRdKHMgx2vYlGyDn62cHR5O1z7AJZIeoPXy/8sdBHkbhz0NcVFoqRk1tx7jLFDb1ah4q4G GNYvzflGc9PoHUzX38QzupdMjudPnEMnD6Ek+tUAnwRRZPuwU3mVMwtTzd+0FKUoj95OcQH HnpdyffDub46tZJKX9fvA== X-UI-Out-Filterresults: notjunk:1;V01:K0:rcH1deHQsy4=:6wcE7IUCAeOn8tNLdR2GQu nvpFFlTFRPRUBp8J8XkyAezW0KUihv3rvkZWzSv1CP7m8Loo0e/b8AwY83wX2p2Cv5lZ3F43o N7NHfjXi33QcHNFVP8MXl7vZOOb6e2Q+jUfq5dvfNYfg1tl3xdJ85ra09ZwWoW3VnQypDwV4o C7BSIG5oiz5qiH9VDCuXRkthgYmQyKt3K7xnD7ItbaaDZlClJ7M8L1PqWs1TPR1ksklxTdE0x YGLKdWWXmqbG6gIyR+WGRXz5y+6n1mQuJn45UOfbXRJ9wVgRn6ooaXP222+oi4zpxErU3RbvH Aq/9DE4QKuBaen8yMzBEbT6m+KxZvMcL1iCVcv5/4p5MuzrS8+ha8Ou0f2QjxLUnSuFIAp/XT USMyoP0wM7NzKPbOXSp6Dfj/+TCCaIIvwETOF/eVnmybn8CfBL5xDQIHviBqIG2xXFHreQ9FG DsfzqZUHeGlNw2g7sJ2lLbwRLWKIuGaqdjb79YWVgDw24ZzsFgxEVBOgBP2WldLE3P0Aj2jRD SXrlnnKQlQJBAFZkIL5cU6xyTH2steNz/0KZ4FogdpVSYVWrDxG1T6DiaS1comn+Q43OqopWf xobbwqnB4UvW/f4Adm3NU2XkPXHff2hDB6tzKrM8kEfFPTiHYYcbyinUYmMPq3xujtJBX0r7E OtNES/7fyxvWq9yeerTY9JQPvO75uVx1A1Ukt4OzHaJpQi64gB4HLED00le2/e10AzI7S1ZR2 kiWLmrCrqPCNZ5Px Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 December 2015 15:45:32 Peter Ujfalusi wrote: > >> static struct dma_filter_map da830_edma_map[] = { > >> DMA_FILTER_ENTRY("davinci-mcasp.0", "rx", EDMA_CTLR_CHAN(0, 0)), > >> DMA_FILTER_ENTRY("davinci-mcasp.0", "tx", EDMA_CTLR_CHAN(0, 1)), > >> DMA_FILTER_ENTRY("davinci-mcasp.1", "rx", EDMA_CTLR_CHAN(0, 2)), > >> DMA_FILTER_ENTRY("davinci-mcasp.1", "tx", EDMA_CTLR_CHAN(0, 3)), > >> DMA_FILTER_ENTRY("davinci-mcasp.2", "rx", EDMA_CTLR_CHAN(0, 4)), > >> DMA_FILTER_ENTRY("davinci-mcasp.2", "tx", EDMA_CTLR_CHAN(0, 5)), > >> DMA_FILTER_ENTRY("spi_davinci.0", "rx", EDMA_CTLR_CHAN(0, 14)), > >> DMA_FILTER_ENTRY("spi_davinci.0", "tx", EDMA_CTLR_CHAN(0, 15)), > >> DMA_FILTER_ENTRY("da830-mmc.0", "rx", EDMA_CTLR_CHAN(0, 16)), > >> DMA_FILTER_ENTRY("da830-mmc.0", "tx", EDMA_CTLR_CHAN(0, 17)), > >> DMA_FILTER_ENTRY("spi_davinci.1", "rx", EDMA_CTLR_CHAN(0, 18)), > >> DMA_FILTER_ENTRY("spi_davinci.1", "tx", EDMA_CTLR_CHAN(0, 19)), > > > > Does this ".2" and so prevent driver to use auto ID for platform devices? > > Yes, as all the infra around the traditional board files with platform_device > creation does. Ideally we could have 'phandle' pointing from this table to the > device in question (or other way around), but I'm not aware of anything we can > use. I was thinking that we could use a pointer to the device structure, but if you have that, you can also just read the name from it. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 01 Dec 2015 15:24:40 +0100 Subject: [RFC v02 00/15] dmaengine: New 'universal' API for requesting channel In-Reply-To: <565DA47C.4000308@ti.com> References: <1448891145-10766-1-git-send-email-peter.ujfalusi@ti.com> <565DA47C.4000308@ti.com> Message-ID: <103520159.g0xhtFsXUi@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 01 December 2015 15:45:32 Peter Ujfalusi wrote: > >> static struct dma_filter_map da830_edma_map[] = { > >> DMA_FILTER_ENTRY("davinci-mcasp.0", "rx", EDMA_CTLR_CHAN(0, 0)), > >> DMA_FILTER_ENTRY("davinci-mcasp.0", "tx", EDMA_CTLR_CHAN(0, 1)), > >> DMA_FILTER_ENTRY("davinci-mcasp.1", "rx", EDMA_CTLR_CHAN(0, 2)), > >> DMA_FILTER_ENTRY("davinci-mcasp.1", "tx", EDMA_CTLR_CHAN(0, 3)), > >> DMA_FILTER_ENTRY("davinci-mcasp.2", "rx", EDMA_CTLR_CHAN(0, 4)), > >> DMA_FILTER_ENTRY("davinci-mcasp.2", "tx", EDMA_CTLR_CHAN(0, 5)), > >> DMA_FILTER_ENTRY("spi_davinci.0", "rx", EDMA_CTLR_CHAN(0, 14)), > >> DMA_FILTER_ENTRY("spi_davinci.0", "tx", EDMA_CTLR_CHAN(0, 15)), > >> DMA_FILTER_ENTRY("da830-mmc.0", "rx", EDMA_CTLR_CHAN(0, 16)), > >> DMA_FILTER_ENTRY("da830-mmc.0", "tx", EDMA_CTLR_CHAN(0, 17)), > >> DMA_FILTER_ENTRY("spi_davinci.1", "rx", EDMA_CTLR_CHAN(0, 18)), > >> DMA_FILTER_ENTRY("spi_davinci.1", "tx", EDMA_CTLR_CHAN(0, 19)), > > > > Does this ".2" and so prevent driver to use auto ID for platform devices? > > Yes, as all the infra around the traditional board files with platform_device > creation does. Ideally we could have 'phandle' pointing from this table to the > device in question (or other way around), but I'm not aware of anything we can > use. I was thinking that we could use a pointer to the device structure, but if you have that, you can also just read the name from it. Arnd