From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: change log levels in client mode Date: Thu, 2 Mar 2017 14:33:27 +0100 Message-ID: <1035fba0-89c1-1db5-2e1e-02c691633785@redhat.com> References: <1488447574-6266-1-git-send-email-i.maximets@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Heetae Ahn , stable@dpdk.org To: Ilya Maximets , dev@dpdk.org, Yuanhan Liu Return-path: In-Reply-To: <1488447574-6266-1-git-send-email-i.maximets@samsung.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/02/2017 10:39 AM, Ilya Maximets wrote: > Inability to connect to socket is a normal situation > in client mode because, in common case, server isn't > started yet. RTE_LOG_WARNING should be suitable for > the case of some unusual errors. > Message about reconnection is not an error at all. > > CC: stable@dpdk.org > Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") > > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/socket.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index aaa9c27..6a30a31 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket) > return 0; > } > > - RTE_LOG(ERR, VHOST_CONFIG, > + RTE_LOG(WARNING, VHOST_CONFIG, > "failed to connect to %s: %s\n", > path, strerror(errno)); > > @@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket) > return -1; > } > > - RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path); > + RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path); > reconn = malloc(sizeof(*reconn)); > if (reconn == NULL) { > RTE_LOG(ERR, VHOST_CONFIG, > Reviewed-by: Maxime Coquelin Thanks! Maxime