From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754222AbcK1IDf convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 03:03:35 -0500
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48875 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754035AbcK1ID1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 03:03:27 -0500
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\))
Subject: Re: [PATCH] GenWQE: drop duplicate headers
From: Frank Haverkamp <haver@linux.vnet.ibm.com>
In-Reply-To: <5bf35d8273cb0b4bcdad3f4018c593a157ac6a22.1479905566.git.geliangtang@gmail.com>
Date: Thu, 24 Nov 2016 13:51:57 +0100
Cc: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
References: <906a07a7db3f3d6454236dd10d4082c1d9c78fa6.1479905884.git.geliangtang@gmail.com>
 <5bf35d8273cb0b4bcdad3f4018c593a157ac6a22.1479905566.git.geliangtang@gmail.com>
To: Geliang Tang <geliangtang@gmail.com>
X-Mailer: Apple Mail (2.3251)
X-TM-AS-GCONF: 00
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16112808-0020-0000-0000-0000023B768B
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 16112808-0021-0000-0000-00001E770F41
Message-Id: <103A7FE0-12A9-4C9D-AAEF-43E84A100868@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-28_04:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=3
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000
 definitions=main-1611280138
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Geliang,


> On 23 Nov 2016, at 15:24, Geliang Tang <geliangtang@gmail.com> wrote:
> 
> Drop duplicate headers module.h and delay.h.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/misc/genwqe/card_base.c  | 1 -
> drivers/misc/genwqe/card_ddcb.c  | 1 -
> drivers/misc/genwqe/card_utils.c | 1 -
> 3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a..b6f2edf 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
> #include <linux/wait.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/module.h>
> #include <linux/notifier.h>
> #include <linux/device.h>
> #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
> #include <linux/string.h>
> #include <linux/dma-mapping.h>
> #include <linux/delay.h>
> -#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/crc-itu-t.h>
> 
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 147b830..a1859e5 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -36,7 +36,6 @@
> #include <linux/ctype.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> #include <asm/pgtable.h>
> 
> #include "genwqe_driver.h"
> -- 
> 2.9.3
> 

thanks for the simplification. Did you find those by manual inspection, or did you use a tool?

Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>