All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Sasha Levin <sashal@kernel.org>, Hugh Dickins <hughd@google.com>,
	 llvm@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH 5.4 and earlier only] mm: Fix '.data.once' orphan section warning
Date: Tue, 29 Nov 2022 22:28:33 -0800 (PST)	[thread overview]
Message-ID: <103aa792-661f-396b-82d4-4507df636b9@google.com> (raw)
In-Reply-To: <20221128225345.9383-1-nathan@kernel.org>

On Mon, 28 Nov 2022, Nathan Chancellor wrote:

> Portions of upstream commit a4055888629b ("mm/memcg: warning on !memcg
> after readahead page charged") were backported as commit cfe575954ddd
> ("mm: add VM_WARN_ON_ONCE_PAGE() macro"). Unfortunately, the backport
> did not account for the lack of commit 33def8498fdd ("treewide: Convert
> macro and uses of __section(foo) to __section("foo")") in kernels prior
> to 5.10, resulting in the following orphan section warnings on PowerPC
> clang builds with CONFIG_DEBUG_VM=y:
> 
>   powerpc64le-linux-gnu-ld: warning: orphan section `".data.once"' from `mm/huge_memory.o' being placed in section `".data.once"'
>   powerpc64le-linux-gnu-ld: warning: orphan section `".data.once"' from `mm/huge_memory.o' being placed in section `".data.once"'
>   powerpc64le-linux-gnu-ld: warning: orphan section `".data.once"' from `mm/huge_memory.o' being placed in section `".data.once"'
> 
> This is a difference between how clang and gcc handle macro
> stringification, which was resolved for the kernel by not stringifying
> the argument to the __section() macro. Since that change was deemed not
> suitable for the stable kernels by commit 59f89518f510 ("once: fix
> section mismatch on clang builds"), do that same thing as that change
> and remove the quotes from the argument to __section().
> 
> Fixes: cfe575954ddd ("mm: add VM_WARN_ON_ONCE_PAGE() macro")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Yes indeed: thanks Nathan, sorry about that.

Acked-by: Hugh Dickins <hughd@google.com>

> ---
> 
> As far as I can tell, this should be applied to 5.4 and earlier. It
> should apply cleanly but let me know if not.

I think it should be good for 4.19 also, but I don't know what happens
or would happen in 4.14 and 4.9 trees, since those have no other example
of .data.once or ".data.once" (and I've lost what little I ever knew of
that linker script stuff).

Since we're not hearing complaints about those (or are you?), perhaps
those trees are not clang-ready in other ways, and for gcc it all works
out by itself: I'd be inclined to just leave them as is myself, if there
are no reports of breakage; but you may know better, and prefer to remove
the ' __section(".data.once")' from the 4.14 and 4.9 versions.

> 
>  include/linux/mmdebug.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 5d0767cb424a..4ed52879ce55 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -38,7 +38,7 @@ void dump_mm(const struct mm_struct *mm);
>  		}							\
>  	} while (0)
>  #define VM_WARN_ON_ONCE_PAGE(cond, page)	({			\
> -	static bool __section(".data.once") __warned;			\
> +	static bool __section(.data.once) __warned;			\
>  	int __ret_warn_once = !!(cond);					\
>  									\
>  	if (unlikely(__ret_warn_once && !__warned)) {			\
> 
> base-commit: 4d2a309b5c28a2edc0900542d22fec3a5a22243b
> -- 
> 2.38.1

  reply	other threads:[~2022-11-30  6:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 22:53 [PATCH 5.4 and earlier only] mm: Fix '.data.once' orphan section warning Nathan Chancellor
2022-11-30  6:28 ` Hugh Dickins [this message]
2022-11-30 16:20   ` Nathan Chancellor
2022-12-03 13:34 ` Greg Kroah-Hartman
2022-12-03 17:41   ` Hugh Dickins
2022-12-04 15:38     ` Greg Kroah-Hartman
2022-12-04 15:55       ` Hugh Dickins
2022-12-03 13:54 ` Patch "mm: Fix '.data.once' orphan section warning" has been added to the 4.9-stable tree gregkh
2022-12-03 13:54 ` Patch "mm: Fix '.data.once' orphan section warning" has been added to the 4.14-stable tree gregkh
2022-12-03 13:55 ` Patch "mm: Fix '.data.once' orphan section warning" has been added to the 4.19-stable tree gregkh
2022-12-03 13:55 ` Patch "mm: Fix '.data.once' orphan section warning" has been added to the 5.4-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=103aa792-661f-396b-82d4-4507df636b9@google.com \
    --to=hughd@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.