All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Christian Stewart <christian@paral.in>
Cc: Anisse Astier <anisse@astier.eu>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH-NEXT v2 1/5] support/download/dl-wrapper: add concept of download post-processing
Date: Sun, 19 Sep 2021 13:55:08 +0200	[thread overview]
Message-ID: <103e4d1a-46d8-0639-6f81-d1dc96c6dbdb@mind.be> (raw)
In-Reply-To: <20210919093709.GO1053080@scaer>



On 19/09/2021 11:37, Yann E. MORIN wrote:
> Christian, All,
> 
> Can you fixup the patches as you already noticed, and respin a fixed
> up series, please? In the meantime., I've marked this one Changes
> REquested in Patchwork.
> 
> Also, what was still preventing applying this to Buildroot, was a few
> still open questions, the most prominent one I can remember is about
> BR2_PRIMARY_SITE and BR2_BACKUP_SITE.
> 
> Indeed, what we download from the main site is an un-vendored source,
> but what we will get in primary or backup sites are vendored sources.
> 
> Downloading vendored sources from primary or mirror also means that no
> vendoring should be applied afterward, i.e. vendoring should only occur
> on sources downloaded from the main site.
> 
> Did you try that? Can you report on how that eventually played out?

  I guess that's what this piece of code in go-post-process is about:

# Already vendored tarball, nothing to do
if tar tf ${output} | grep -q "^[^/]*/vendor" ; then
	exit 0
fi


  Regards,
  Arnout


[snip]
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-09-19 11:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19  7:10 [Buildroot] [PATCH-NEXT v2 1/5] support/download/dl-wrapper: add concept of download post-processing Christian Stewart via buildroot
2021-09-19  7:10 ` [Buildroot] [PATCH-NEXT v2 2/5] package/pkg-download.mk: add <pkg>_DOWNLOAD_POST_PROCESS variable Christian Stewart via buildroot
2021-09-19  7:10 ` [Buildroot] [PATCH-NEXT v2 3/5] support/download/post-process-helpers: add helper function for post process scripts Christian Stewart via buildroot
2021-09-19  7:10 ` [Buildroot] [PATCH-NEXT v2 4/5] support/download/go-post-process: implement Go vendoring support Christian Stewart via buildroot
2021-09-19  7:13   ` Christian Stewart via buildroot
2021-09-19  7:10 ` [Buildroot] [PATCH-NEXT v2 5/5] package/embiggen-disk: new package Christian Stewart via buildroot
2021-09-19  7:17   ` Christian Stewart via buildroot
2021-09-19  9:37 ` [Buildroot] [PATCH-NEXT v2 1/5] support/download/dl-wrapper: add concept of download post-processing Yann E. MORIN
2021-09-19 11:55   ` Arnout Vandecappelle [this message]
2021-10-01 22:53     ` Christian Stewart via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=103e4d1a-46d8-0639-6f81-d1dc96c6dbdb@mind.be \
    --to=arnout@mind.be \
    --cc=anisse@astier.eu \
    --cc=buildroot@buildroot.org \
    --cc=christian@paral.in \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.