From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8CDC433F5 for ; Fri, 22 Oct 2021 19:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 814B160F6E for ; Fri, 22 Oct 2021 19:40:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234042AbhJVTmy (ORCPT ); Fri, 22 Oct 2021 15:42:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22590 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232029AbhJVTmy (ORCPT ); Fri, 22 Oct 2021 15:42:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634931635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TXn+dNe02I1e9WL3b+8Rpc7Yy2ZUl284mKuARnxOrKM=; b=Z6qdVq18zN8Ebb4rnjV2X8PXR93cjhN/Jzug8j4vLAmpcOiPQgiwfae8dY1hUTryV5kVQt ZM+3fPnXOeCoNnt3NjjMcxA3xHZaofSvWGDLkOR18HaXyIhCorZVOgq5TamS83JjKAjiEU 9bD92JuQ1t6keOpXuLTAuilL2aXttTw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-zGI3szvNO1-ZuOVh4-qMlA-1; Fri, 22 Oct 2021 15:40:32 -0400 X-MC-Unique: zGI3szvNO1-ZuOVh4-qMlA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1851B806689; Fri, 22 Oct 2021 19:40:30 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 592161346F; Fri, 22 Oct 2021 19:40:17 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <163492911924.1038219.13107463173777870713.stgit@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, Marc Dionne , Eric Van Hensbergen , "Matthew Wilcox (Oracle)" , Dave Wysochanski , CIFS , Dominique Martinet , Steve French , Shyam Prasad N , Jeff Layton , Anna Schumaker , linux-nfs@vger.kernel.org, Latchesar Ionkov , v9fs-developer@lists.sourceforge.net, Trond Myklebust , Trond Myklebust , Jeff Layton , Alexander Viro , Omar Sandoval , ceph-devel@vger.kernel.org, linux-fsdevel , Linux Kernel Mailing List Subject: Re: [PATCH v2 00/53] fscache: Rewrite index API and management system MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1041556.1634931616.1@warthog.procyon.org.uk> Date: Fri, 22 Oct 2021 20:40:16 +0100 Message-ID: <1041557.1634931616@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Linus Torvalds wrote: > Honestly, I don't see the point of this when it ends up just being > dead code basically immediately. > > You don't actually support picking one or the other at build time, > just a hard switch-over. > > That makes the old fscache driver useless. You can't say "use the old > one because I don't trust the new". You just have a legacy > implementation with no users. What's the best way to do this? Is it fine to disable caching in all the network filesystems and then directly remove the fscache and cachefiles drivers and replace them? It won't stop the network filesystems actually working - it'll just mean that they don't do any caching until converted and have caching reenabled. David