From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122C8C432C0 for ; Wed, 20 Nov 2019 21:23:22 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 816AB20855 for ; Wed, 20 Nov 2019 21:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="Ie72pToi"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="pDkfOJim" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816AB20855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C053127D; Wed, 20 Nov 2019 22:23:19 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C534F271 for ; Wed, 20 Nov 2019 22:23:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3AC3421540; Wed, 20 Nov 2019 16:23:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Nov 2019 16:23:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+k3tAQJD92nITFN8D5GQK1tn9XVL5hOfxICRKd19BoI=; b=Ie72pToi19Hc 6SsQoC5sD0MzkqVn1mivWAXf3sCAnw0nQc1cRs79UQRvDsS+QYpb/c6nXMIL9q1W TuOaulPe+rSVdW7pG7f+rrUWzCw1cIMXiXyf0+w6evujOeDk+ofSTlA1NJRG3y6K vQFp+oV+8+e6BYck4BvlpDj649unBQ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+k3tAQJD92nITFN8D5GQK1tn9XVL5hOfxICRKd19B oI=; b=pDkfOJimQGrJljGWmjt66cOO6/Ox7mb4X99maesNTHKO4KnsNpuerJzqj ThHyvxUDWleD4x2o6pvai1CSNrD78ghs/KxsbtvBk5dXzEd60OFHNJXdABVw8FTd /gBnIGLd2nlqtBkNZ6kPIL/kD/los3ian/dimknb2GhE15xjBx0f+0vD4jAyS/4/ I37mi2Q8o4SYjtaPSS19xPOxSgosX15BvRxiZ4fczmAYQGAE+3/RuYMS4hFeEicb nNRCkP2Xh2QZxu9RUAG7R17Uv4e/NqjXcedpjqYnes8/YHIuPWknSsf70nBF8h0S eK50lqBPEeTEcfkLutjU3NyomhA1w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehtddgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF6FA306005F; Wed, 20 Nov 2019 16:23:14 -0500 (EST) From: Thomas Monjalon To: Rosen Xu Cc: dev@dpdk.org, tianfei.zhang@intel.com, andy.pei@intel.com, xiaolong.ye@intel.com, ferruh.yigit@intel.com, david.marchand@redhat.com Date: Wed, 20 Nov 2019 22:23:12 +0100 Message-ID: <10496132.hlKR8GaRvu@xps> In-Reply-To: <1573722187-148846-11-git-send-email-rosen.xu@intel.com> References: <1571917119-149534-2-git-send-email-andy.pei@intel.com> <1573722187-148846-1-git-send-email-rosen.xu@intel.com> <1573722187-148846-11-git-send-email-rosen.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rosen (and most of your colleagues), Please use --in-reply-to when sending a new version. All versions must be a reply to the very first cover letter. 14/11/2019 10:02, Rosen Xu: > + IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx\n", val); Using %lx is usually wrong. val is 64-bit. On 32-bit machines (like some Intel ones), it does not compile. I had to fix it while pulling next-net. The same issue was in "raw/ifpga/base: clean fme errors". Please check 32-bit compilation. Note: we should have such check in the CI.