From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Wed, 20 Nov 2019 15:10:18 +0800 Subject: [U-Boot] [PATCH] power: fan53555: fix fan53555_regulator_set_value In-Reply-To: <20191117184736.507812-1-anarsoul@gmail.com> References: <20191117184736.507812-1-anarsoul@gmail.com> Message-ID: <105407eb-a17b-5195-7004-a8e9af7a1472@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On 2019/11/18 上午2:47, Vasily Khoruzhick wrote: > fan53555_regulator_set_value() passes its own dev to pmic_clrsetbits() > instead of its parent (pmic). As result u-boot crashes when you try to > set voltage on fan53555 regulator > > Signed-off-by: Vasily Khoruzhick Reviewed-by: Kever Yang Thanks, - Kever > --- > drivers/power/regulator/fan53555.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/regulator/fan53555.c b/drivers/power/regulator/fan53555.c > index 9c48b26216..24a9b67586 100644 > --- a/drivers/power/regulator/fan53555.c > +++ b/drivers/power/regulator/fan53555.c > @@ -159,7 +159,7 @@ static int fan53555_regulator_set_value(struct udevice *dev, int uV) > debug("%s: uV=%d; writing volume %d: %02x\n", > __func__, uV, pdata->vol_reg, vol); > > - return pmic_clrsetbits(dev, pdata->vol_reg, GENMASK(6, 0), vol); > + return pmic_clrsetbits(dev->parent, pdata->vol_reg, GENMASK(6, 0), vol); > } > > static int fan53555_voltages_setup(struct udevice *dev)