All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@saftware.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fixed tftp error message output
Date: 20 Jul 2003 00:31:28 +0200	[thread overview]
Message-ID: <1058653888.774.80.camel@localhost> (raw)
In-Reply-To: <20030719220001.B03E6C6D82@atlas.denx.de>

On Sat, 2003-07-19 at 23:59, Wolfgang Denk wrote:
> In message <1058646514.774.55.camel@localhost> you wrote:
> > 
> > Just try to tftp a file which does not exist on the server or which does
> > not have correct permissions (leading to a "file not found" message). I
> > am using atftpd on debian sarge and sid.
> 
> Done - I get this then:
> 
> => tftp 100000 foo
> TFTP from server 10.0.0.14; our IP address is 10.0.0.99
> Filename 'foo'.
> Load address: 0x100000
> Loading: *
> TFTP error: 'File not found' (1)
> Starting again
> 
> 
> Nothing wrong, or am I missing something?

My guess is that your tftp server correctly appends \0 to the error
message and atftpd does not. Strange. Having a look at atftpd source
code I suspect that its use of strncpy for the error message is the
cause, but I think u-boot should not rely on the trailing \0, because
the length of the error message is known anyway. I'll report when I have
been able to test it.

Regards,
Andreas

  reply	other threads:[~2003-07-19 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-19  2:34 [U-Boot-Users] [PATCH] fixed tftp error message output Andreas Oberritter
2003-07-19 19:28 ` Wolfgang Denk
2003-07-19 20:28   ` Andreas Oberritter
2003-07-19 21:59     ` Wolfgang Denk
2003-07-19 22:31       ` Andreas Oberritter [this message]
2003-07-20 12:53         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1058653888.774.80.camel@localhost \
    --to=obi@saftware.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.