All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Dillow <dave@thedillows.org>
To: junkio@cox.net
Cc: linux-kernel@vger.kernel.org,
	Phillip Lougher <phillip@lougher.demon.co.uk>
Subject: Re: [PATCH] Port SquashFS to 2.6
Date: 19 Jul 2003 19:35:38 -0400	[thread overview]
Message-ID: <1058657738.4233.4.camel@ori.thedillows.org> (raw)
In-Reply-To: <7vk7ae15ty.fsf@assigned-by-dhcp.cox.net>

On Sat, 2003-07-19 at 18:59, junkio@cox.net wrote:

> +static int squashfs_symlink_readpage(struct file *file, struct page *page)
> +{
> +	struct inode *inode = page->mapping->host;
> +	struct squashfs_inode_info *sqi = SQUASH_I(inode);
> +	int index = page->index << PAGE_CACHE_SHIFT, length = 0, bytes;
> +	int block = sqi->start_block;
> +	int offset = sqi->offset;
> +
> +	TRACE("Entered squashfs_symlink_readpage, page index %d, start block %x, offset %x\n",
> +		page->index, sqi->start_block, sqi->offset);
> +
> +	while(length < index) {
> +		char buffer[PAGE_CACHE_SIZE];
 
Hmm, isn't that 4K allocated on the stack? Ouch.

  reply	other threads:[~2003-07-19 23:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-19 22:59 [PATCH] Port SquashFS to 2.6 junkio
2003-07-19 23:35 ` David Dillow [this message]
2003-07-20  5:40   ` junkio
2003-07-20  8:22     ` Jörn Engel
2003-07-20 10:16       ` postmaster
2003-07-20 10:38         ` Jörn Engel
2003-07-20  1:50 ` Bernd Eckenfels
     [not found] <fa.k0do8p6.ch6pps@ifi.uio.no>
     [not found] ` <fa.hre90bn.e6k5pf@ifi.uio.no>
2003-07-22  2:52   ` junkio
2003-07-22  3:42     ` Valdis.Kletnieks
2003-07-22 10:20       ` Jörn Engel
2003-07-22 10:16     ` Jörn Engel
2003-07-22 10:36 John Bradford
2003-07-22 10:47 ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1058657738.4233.4.camel@ori.thedillows.org \
    --to=dave@thedillows.org \
    --cc=junkio@cox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@lougher.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.