From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/2] ethdev: add hierarchical scheduler API Date: Wed, 15 Mar 2017 13:43:39 +0100 Message-ID: <106399437.xFH6ZF6NRJ@xps13> References: <1488589820-206947-1-git-send-email-cristian.dumitrescu@intel.com> <26FA93C7ED1EAA44AB77D62FBE1D27BA7231952B@IRSMSX108.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891265275E105@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "O'Driscoll, Tim" , dev@dpdk.org, jerin.jacob@caviumnetworks.com, balasubramanian.manoharan@cavium.com, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, "Wiles, Keith" , "Richardson, Bruce" To: "Dumitrescu, Cristian" Return-path: Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id 212A028F3 for ; Wed, 15 Mar 2017 13:43:41 +0100 (CET) Received: by mail-wr0-f176.google.com with SMTP id u108so10152677wrb.3 for ; Wed, 15 Mar 2017 05:43:41 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891265275E105@IRSMSX108.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-10 18:37, Dumitrescu, Cristian: > From: O'Driscoll, Tim > > > > OK I better understand now. > > > > You should add this level of explanation in your patch. > > > > > > > > However I am reluctant to add an API if there is no user. > > > > I think we should wait to have at least one existing driver > > > implementing > > > > this API before integrating it. > > > > It was the approach of eventdev which has a dedicated next- tree. > > > > > > The next-tree solution could work, but IMO is not the best for this > > > case, as this is purely driver development. This is just a TX offload > > > feature that is well understood, as opposed to a new library with a huge > > > design effort required like eventdev. > > > > > > I think we are reasonably close to get agreement on the API from Cavium, > > > Intel and NXP. When this is done, how about including it in DPDK with > > > the experimental tag attached to it until several drivers implement it? > > > > > > From Intel side, there are solid plans to implement it for ixgbe and > > > i40e drivers in next DPDK releases, I am CC-ing Tim to confirm this. > > > > That's correct. We plan to add support for this in the ixgbe and i40e drivers in > > 17.08. > > Thomas, given Tim's confirmation of Intel's plans to implement this API for the ixgbe and i40e drivers in DPDK release 17.8, are you in favour of including this API in 17.5 with experimental tag (subject to full API agreement being reached)? I think starting a branch in a dedicated "next" repo is a better approach. rte_flow and eventdev were (and will be) integrated only when at least one hardware device is supported. I suggest to follow the same workflow. > IMO this approach has the advantage of showing that API agreement has been reached and driver development is in progress. Having it in DPDK is also a better way to advertise this API to the developers that would otherwise be unaware about this effort. IMO we can advertise a work in progress in a side branch.