Call trace when rmmod'ing saa7134 and error when compiling static

Call trace when rmmod'ing saa7134 and error when compiling static

[Stian Jordet]

Hello,

when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
this call trace:

Device class 'i2c-1' does not have a release() function, it is broken
and must be fixed.
Badness in class_dev_release at drivers/base/class.c:200
Call Trace:
 [<c02be4d5>] kobject_cleanup+0x85/0x90
 [<c03e0040>] i2cdev_detach_adapter+0x0/0x40
 [<c03e0069>] i2cdev_detach_adapter+0x29/0x40
 [<c03dd216>] i2c_del_adapter+0x1c6/0x200
 [<e8a7bb59>] .text.lock.saa7134_tvaudio+0x37/0x3e [saa7134]
 [<e8a77784>] saa7134_i2c_unregister+0x14/0x20 [saa7134]
 [<e8a76a56>] saa7134_finidev+0xa6/0x1d0 [saa7134]
 [<c02cc94b>] pci_device_remove+0x3b/0x40
 [<c031c846>] device_release_driver+0x66/0x70
 [<c031c87b>] driver_detach+0x2b/0x40
 [<c031cace>] bus_remove_driver+0x3e/0x80
 [<c031ced3>] driver_unregister+0x13/0x2a
 [<c02ccb36>] pci_unregister_driver+0x16/0x30
 [<e8a76c0f>] saa7134_fini+0xf/0x11 [saa7134]
 [<c013b36a>] sys_delete_module+0x13a/0x170
 [<c01536a5>] sys_munmap+0x45/0x70
 [<c01095fb>] syscall_call+0x7/0xb

And when I try to build the driver into the kernel (not as a module), I
get this link failure:

drivers/built-in.o(.text+0x89a60): In function `saa7134_initdev':
: undefined reference to `register_sound_dsp'
drivers/built-in.o(.text+0x89aa0): In function `saa7134_initdev':
: undefined reference to `register_sound_mixer'
drivers/built-in.o(.text+0x89b7e): In function `saa7134_initdev':
: undefined reference to `unregister_sound_dsp'
drivers/built-in.o(.text+0x89ea7): In function `saa7134_finidev':
: undefined reference to `unregister_sound_mixer'
drivers/built-in.o(.text+0x89eb2): In function `saa7134_finidev':
: undefined reference to `unregister_sound_dsp'
make: *** [.tmp_vmlinux1] Error 1

But this has never worked.

Best regards,
Stian

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Gerd Knorr]

On Thu, Oct 09, 2003 at 04:08:54PM +0200, Stian Jordet wrote:
> Hello,
> 
> when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
> this call trace:
> 
> Device class 'i2c-1' does not have a release() function, it is broken
> and must be fixed.
> Badness in class_dev_release at drivers/base/class.c:200
> Call Trace:
>  [<c02be4d5>] kobject_cleanup+0x85/0x90
>  [<c03e0040>] i2cdev_detach_adapter+0x0/0x40
>  [<c03e0069>] i2cdev_detach_adapter+0x29/0x40
>  [<c03dd216>] i2c_del_adapter+0x1c6/0x200
>  [<e8a7bb59>] .text.lock.saa7134_tvaudio+0x37/0x3e [saa7134]
>  [<e8a77784>] saa7134_i2c_unregister+0x14/0x20 [saa7134]

Hmm, funny, doesn't happen here ...

Also not sure whenever this is a bug in the i2c core or in the saa7134
driver ...

  Gerd

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Stian Jordet]

tor, 09.10.2003 kl. 17.15 skrev Gerd Knorr:
> On Thu, Oct 09, 2003 at 04:08:54PM +0200, Stian Jordet wrote:
> > Hello,
> > 
> > when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
> > this call trace:
> > 
> > Device class 'i2c-1' does not have a release() function, it is broken
> > and must be fixed.
> > Badness in class_dev_release at drivers/base/class.c:200
> > Call Trace:
> >  [<c02be4d5>] kobject_cleanup+0x85/0x90
> >  [<c03e0040>] i2cdev_detach_adapter+0x0/0x40
> >  [<c03e0069>] i2cdev_detach_adapter+0x29/0x40
> >  [<c03dd216>] i2c_del_adapter+0x1c6/0x200
> >  [<e8a7bb59>] .text.lock.saa7134_tvaudio+0x37/0x3e [saa7134]
> >  [<e8a77784>] saa7134_i2c_unregister+0x14/0x20 [saa7134]
> 
> Hmm, funny, doesn't happen here ...
> 
> Also not sure whenever this is a bug in the i2c core or in the saa7134
> driver ...

Hmm. Weird. 100% reproducable here. Anything I can do to help finding
out what causes it? The same happens with the patch from your page.

Best regards,
Stian

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Gerd Knorr]

> drivers/built-in.o(.text+0x89a60): In function `saa7134_initdev':
> : undefined reference to `register_sound_dsp'

Missing depend on SOUND

  Gerd

-- 
You have a new virus in /var/mail/kraxel

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Greg KH]

On Thu, Oct 09, 2003 at 04:08:54PM +0200, Stian Jordet wrote:
> Hello,
> 
> when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
> this call trace:
> 
> Device class 'i2c-1' does not have a release() function, it is broken
> and must be fixed.

This is when you remove the i2c-dev module, right?  Yeah, I know about
the problem and will fix it.

thanks,

greg k-h

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Stian Jordet]

tor, 09.10.2003 kl. 23.08 skrev Greg KH:
> On Thu, Oct 09, 2003 at 04:08:54PM +0200, Stian Jordet wrote:
> > Hello,
> > 
> > when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
> > this call trace:
> > 
> > Device class 'i2c-1' does not have a release() function, it is broken
> > and must be fixed.
> 
> This is when you remove the i2c-dev module, right?  Yeah, I know about
> the problem and will fix it.

I have no idea, I just "rmmod saa7134" :)

Best regards,
Stian

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Greg KH]

On Thu, Oct 09, 2003 at 11:23:21PM +0200, Stian Jordet wrote:
> tor, 09.10.2003 kl. 23.08 skrev Greg KH:
> > On Thu, Oct 09, 2003 at 04:08:54PM +0200, Stian Jordet wrote:
> > > Hello,
> > > 
> > > when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
> > > this call trace:
> > > 
> > > Device class 'i2c-1' does not have a release() function, it is broken
> > > and must be fixed.
> > 
> > This is when you remove the i2c-dev module, right?  Yeah, I know about
> > the problem and will fix it.
> 
> I have no idea, I just "rmmod saa7134" :)

Sorry, I ment to say, you have the i2c-dev module loaded, or built into
your kernel, right?  That will cause this warning to be printed out.

thanks,

greg k-h

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Stian Jordet]

tor, 09.10.2003 kl. 23.28 skrev Greg KH:
> On Thu, Oct 09, 2003 at 11:23:21PM +0200, Stian Jordet wrote:
> > tor, 09.10.2003 kl. 23.08 skrev Greg KH:
> > > On Thu, Oct 09, 2003 at 04:08:54PM +0200, Stian Jordet wrote:
> > > > Hello,
> > > > 
> > > > when I try to rmmod the saa7134 module from kernel 2.6.0-test7, I get
> > > > this call trace:
> > > > 
> > > > Device class 'i2c-1' does not have a release() function, it is broken
> > > > and must be fixed.
> > > 
> > > This is when you remove the i2c-dev module, right?  Yeah, I know about
> > > the problem and will fix it.
> > 
> > I have no idea, I just "rmmod saa7134" :)
> 
> Sorry, I ment to say, you have the i2c-dev module loaded, or built into
> your kernel, right?  That will cause this warning to be printed out.

You're right. But I don't need it, so one problem solved :-)

Gerd: I still would like to be able to compile the driver static, though
:)

Stian

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Gerd Knorr]

> Gerd: I still would like to be able to compile the driver static, though
> :)

Enable CONFIG_SOUND.  Next saa7134 update will add that dependency to Kconfig.

  Gerd

-- 
You have a new virus in /var/mail/kraxel

Re: Call trace when rmmod'ing saa7134 and error when compiling static

[Stian Jordet]

fre, 10.10.2003 kl. 10.54 skrev Gerd Knorr:
> > Gerd: I still would like to be able to compile the driver static, though
> > :)
> 
> Enable CONFIG_SOUND.  Next saa7134 update will add that dependency to Kconfig.

Ahh, thanks, sorry for the noise. I had CONFIG_SOUND as a module.

Thanks again :)

Best regards,
Stian