From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v2 2/2] octeontx: move mbox to common folder
Date: Tue, 20 Mar 2018 20:31:42 +0530
Message-ID: <10673fa8-fd41-c869-779b-c34459368508@nxp.com>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <20180320144046.15382-1-pbhagavatula@caviumnetworks.com>
 <20180320144046.15382-2-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
 thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com,
 bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com,
 hemant.agrawal@nxp.com
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0071.outbound.protection.outlook.com [104.47.1.71])
 by dpdk.org (Postfix) with ESMTP id 3C0A92BA5
 for <dev@dpdk.org>; Tue, 20 Mar 2018 16:02:00 +0100 (CET)
In-Reply-To: <20180320144046.15382-2-pbhagavatula@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


HI Pavan,
     One quick comment

On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote:
> -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx
> +LDLIBS += -lrte_eal -lrte_eventdev -lrte_octeontx_common -lrte_pmd_octeontx
Typically the naming convention for driver based libraries is 
"rte_type_specific" e.g. rte_mempool_octeontx.
rte_octeontx_common is breaking the tradition.

Regards,
Hemant