From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09 Date: Mon, 24 Sep 2018 00:40:33 +0200 Message-ID: <10679582.IxOl8a41ax@xps> References: <1536045016-32008-1-git-send-email-tdu@semihalf.com> <1536068953-9352-11-git-send-email-tdu@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, mw@semihalf.com To: Ferruh Yigit , Tomasz Duszynski , nsamsono@marvell.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6765D201 for ; Mon, 24 Sep 2018 00:40:36 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/09/2018 19:15, Ferruh Yigit: > On 9/4/2018 2:49 PM, Tomasz Duszynski wrote: > > From: Natalie Samsonov > > --- a/doc/guides/nics/mvpp2.rst > > +++ b/doc/guides/nics/mvpp2.rst > > - git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10 > > + git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09 > > There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older > versions. It is hard to trace this dependency, what do you think having a matrix > in DPDK documentation showing which DPDK version supports which MUSDK? It does not compile even with MUSDK 18.09. With MUSDK 18.09, the error is: drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared The explanation is in MUSDK: commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce Author: Dmitri Epshtein Date: Mon Nov 20 10:38:31 2017 +0200 sam: remove SAM_HW_RING_NUM from APIs Use function: u32 sam_get_num_cios(u32 inst); As a consequence, next-net cannot be pulled!