From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31877C433DB for ; Fri, 26 Mar 2021 09:04:31 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 38CD961A07 for ; Fri, 26 Mar 2021 09:04:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38CD961A07 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FEBD40685; Fri, 26 Mar 2021 10:04:29 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0C1C24067B for ; Fri, 26 Mar 2021 10:04:28 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 616F75C0189; Fri, 26 Mar 2021 05:04:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 26 Mar 2021 05:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= LmT/rKi3LgN8bn2q+3prwBuZ00nUPuV53fFkcDBqTUo=; b=fS5lAKinzb7K4p8c jEhITbgGzX8FRZGDAmhJF+kVDb2jSvZKuDZS49pbC9BXXvCrBZEml8dwjKRtCetk Mvm6VBsQggW2h2JqeG/6ikOGApYpNzO8b9V32s4qD2RWdjc0xGo5SXO6QEU9IKMm 9xkp2Z4OhSRm0GvcWiAuWf2kM/h8Xh36PbxIaUlDcSrzi3cka7g/+Wbnrq9Ws/lY Vdq3UfTrNJPQWqm7uL89FQd/hStQP/wCdLUWmoPcRiRKu0TeWGU9vsDqF1QtXao4 kclCnctM3US4zI4qHisJoTscbF5YNLnjbAJCDmpt7NZo9ymSp5pWijSDyLUo/sEG B1E5bQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LmT/rKi3LgN8bn2q+3prwBuZ00nUPuV53fFkcDBqT Uo=; b=MuTxmUaM5hF876eRL3SyMvKqyKCrXIzzfvf6N0JbHwtPbq5z0dJfXslYI BCelEQhYcUqmKnGvMpSjlDZG/L6z+Xc+WCc3Qqkm/Q/uLema6exj+5OXdvmQc6nK SSvPSjp0HdkB9H2JRFClGYr+9V7CpYvvM2qNrEuyUoI1uNLYSmlpktzWnM+1p4nq 6TBd4KU2vMBpTP3cLSvMCPlhhw8h5dilzpV31u+7v/hFQCRRJ76hzdFBzLdiwWAd SJ00QE+cDMuQZYAY3dkGnog/VPW9M9XOKEZDYOs/y2PfWPTReMRJ5J4UNa05KOq1 8t98XbOfMl//yy7wJPU755XQVJGLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvdcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueeiiedv ffegheenucfkphepkedurddukeehrdduieehrddukedtnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: from xps.localnet (180.165.185.81.rev.sfr.net [81.185.165.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 9946E24005A; Fri, 26 Mar 2021 05:04:22 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Tyler Retzlaff , Jie Zhou , Dmitry Kozlyuk , Khoa To , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Date: Fri, 26 Mar 2021 10:04:19 +0100 Message-ID: <10728399.QNcMtu5X8E@thomas> In-Reply-To: <20210320130525.16452-3-dmitry.kozliuk@gmail.com> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/5] eal/windows: hide asprintf() shim X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2021 14:05, Dmitry Kozlyuk: > Make asprintf(3) implementation for Windows private to EAL, so that it's > hidden from external consumers. It is not exposed to internal consumers > either, because they don't need asprintf() and also because callers from > other modules would have no reliable way to free allocated memory. > > Signed-off-by: Dmitry Kozlyuk > Acked-by: Khoa To > --- > lib/librte_eal/common/eal_private.h | 11 +++++++++++ > lib/librte_eal/windows/eal.c | 30 +++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+) It would be logic to remove the asprintf implementation from rte_os.h in this patch.