From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14354C43334 for ; Tue, 5 Jul 2022 19:09:42 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EC7640223; Tue, 5 Jul 2022 21:09:42 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id CF2CC400D7 for ; Tue, 5 Jul 2022 21:09:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 9112032008FB; Tue, 5 Jul 2022 15:09:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 05 Jul 2022 15:09:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657048179; x= 1657134579; bh=o2TgJGjqNmgB5+ewOhqu6m4GFj4S0DCjdqEZX6u2IOI=; b=H p6prD6T0aM/CqW1QmshBZrNwxeeH5seTIWowbpEryRbPjlcfpGyUsTyvPac3OCzu Bldv5rxCEkLVpOXm/ezbaqiUglJhI1E/rkm1Uc1D8XMrYC6ZmrQpbYJHGdboSVhB kuHtI2aYwbup3VkdERJK226Y3M9fdfeZ0B1Nmav47Qk/g6UoGqOeeyzQfjrkecgS ZpdXR4k53JfiEOReGfJuHcQiGbTNC36XFhcZqlIcVUNeGqi90o0Zw+p5nOObOpW9 PFGvHkTmo4Ev4vbtMP+i4yNL+e9k9DrzjDI0e1p/C8dGFuQylW5I4uEYjZv7oGPm 5R/DXwZOXxNZ5Mq2EHesQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1657048179; x= 1657134579; bh=o2TgJGjqNmgB5+ewOhqu6m4GFj4S0DCjdqEZX6u2IOI=; b=A SXk2XHpBhEC7VMOxK/aM3n3sSifAsQaryEZRdsti3zZNy5V84/JRCmDr1m6o2wF9 nMXqfId7ojd5mg1tOGPHkteeTW5zUg6mHnD6XvUCuOwphwej/3WaNBcvRt48DCea 30vO2hlEwh56cZIRNZvFsC4Zwa2UDNElcBPBYRGJFgZLnh4mLHnYIYo1I4+BW4r6 1fwrCYEGnKnsz/p3Nrqb6i/CUKudIbJUXK9MfkNf+XgNfrq837QDYTPA2aDWz8Qv 8mhnwZPtbc4LgsJySpTZxW/TuDG50komZdET9HMvxTC1s3zb96QFD/0gIghZg8qS GoxnU2LewJXU2Km5ET/bQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiuddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Jul 2022 15:09:38 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, bruce.richardson@intel.com Subject: Re: [PATCH v3 0/3] Fix IDXD PCI device close Date: Tue, 05 Jul 2022 21:09:36 +0200 Message-ID: <10775985.uMvqGB8zbg@thomas> In-Reply-To: <20220704152751.943965-1-kevin.laatz@intel.com> References: <20220408141504.1319913-1-kevin.laatz@intel.com> <20220704152751.943965-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/07/2022 17:27, Kevin Laatz: > This patchset addresses the device close for IDXD PCI devices. > Initially, there was a memory leak reported by ASAN for the 'pci' member > of the 'idxd_dmadev' struct due to a missing free. In addition, this > patch set corrects the behaviour of the device close function to ensure > the cleanup is completed correctly. > > Depends-on: patch-112376 ("eal: add device removal in rte cleanup") I assume it is not a real dependency. We can fix closing without calling the close function in EAL cleanup. Applied, thanks.