From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932230AbdJJOgU (ORCPT ); Tue, 10 Oct 2017 10:36:20 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40984 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbdJJOgT (ORCPT ); Tue, 10 Oct 2017 10:36:19 -0400 Subject: Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt To: Joonas Lahtinen , Jani Nikula , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171010134733.17516-1-colin.king@canonical.com> <1507646100.7677.24.camel@linux.intel.com> From: Colin Ian King Message-ID: <107fa0b9-11ac-11cc-f6e8-35640430bd6f@canonical.com> Date: Tue, 10 Oct 2017 15:36:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507646100.7677.24.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/17 15:35, Joonas Lahtinen wrote: > On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: >> From: Colin Ian King >> >> There is a previous check to on has_aliasing_ppgtt that returns >> 0 if it is false, so it is impossible for has_aliasing_ppgtt to >> be false on the final return of function intel_sanitize_enable_ppgtt, >> so final return in the function always will return 1. Hence the >> redundant ternary operator can be replaced with a return 1. >> >> Detected by CoverityScan, CID#1357136 ("Logically dead code") >> >> Signed-off-by: Colin Ian King > > Thanks, I took it a few steps further and removed the variable > altogether. I Cc'd you on the patch. Yep, it's an improvement on my fix. Thanks for sorting that out. Colin > > Regards, Joonas > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Date: Tue, 10 Oct 2017 14:36:16 +0000 Subject: Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt Message-Id: <107fa0b9-11ac-11cc-f6e8-35640430bd6f@canonical.com> List-Id: References: <20171010134733.17516-1-colin.king@canonical.com> <1507646100.7677.24.camel@linux.intel.com> In-Reply-To: <1507646100.7677.24.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joonas Lahtinen , Jani Nikula , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 10/10/17 15:35, Joonas Lahtinen wrote: > On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: >> From: Colin Ian King >> >> There is a previous check to on has_aliasing_ppgtt that returns >> 0 if it is false, so it is impossible for has_aliasing_ppgtt to >> be false on the final return of function intel_sanitize_enable_ppgtt, >> so final return in the function always will return 1. Hence the >> redundant ternary operator can be replaced with a return 1. >> >> Detected by CoverityScan, CID#1357136 ("Logically dead code") >> >> Signed-off-by: Colin Ian King > > Thanks, I took it a few steps further and removed the variable > altogether. I Cc'd you on the patch. Yep, it's an improvement on my fix. Thanks for sorting that out. Colin > > Regards, Joonas > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Subject: Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt Date: Tue, 10 Oct 2017 15:36:16 +0100 Message-ID: <107fa0b9-11ac-11cc-f6e8-35640430bd6f@canonical.com> References: <20171010134733.17516-1-colin.king@canonical.com> <1507646100.7677.24.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1507646100.7677.24.camel@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joonas Lahtinen , Jani Nikula , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMTAvMTAvMTcgMTU6MzUsIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKPiBPbiBUdWUsIDIwMTct MTAtMTAgYXQgMTQ6NDcgKzAxMDAsIENvbGluIEtpbmcgd3JvdGU6Cj4+IEZyb206IENvbGluIElh biBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4+Cj4+IFRoZXJlIGlzIGEgcHJldmlv dXMgY2hlY2sgdG8gb24gaGFzX2FsaWFzaW5nX3BwZ3R0IHRoYXQgcmV0dXJucwo+PiAwIGlmIGl0 IGlzIGZhbHNlLCBzbyBpdCBpcyBpbXBvc3NpYmxlIGZvciBoYXNfYWxpYXNpbmdfcHBndHQgdG8K Pj4gYmUgZmFsc2Ugb24gdGhlIGZpbmFsIHJldHVybiBvZiBmdW5jdGlvbiBpbnRlbF9zYW5pdGl6 ZV9lbmFibGVfcHBndHQsCj4+IHNvIGZpbmFsIHJldHVybiBpbiB0aGUgZnVuY3Rpb24gYWx3YXlz IHdpbGwgcmV0dXJuIDEuICBIZW5jZSB0aGUKPj4gcmVkdW5kYW50IHRlcm5hcnkgb3BlcmF0b3Ig Y2FuIGJlIHJlcGxhY2VkIHdpdGggYSByZXR1cm4gMS4KPj4KPj4gRGV0ZWN0ZWQgYnkgQ292ZXJp dHlTY2FuLCBDSUQjMTM1NzEzNiAoIkxvZ2ljYWxseSBkZWFkIGNvZGUiKQo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IAo+IFRo YW5rcywgSSB0b29rIGl0IGEgZmV3IHN0ZXBzIGZ1cnRoZXIgYW5kIHJlbW92ZWQgdGhlIHZhcmlh YmxlCj4gYWx0b2dldGhlci4gSSBDYydkIHlvdSBvbiB0aGUgcGF0Y2guCgpZZXAsIGl0J3MgYW4g aW1wcm92ZW1lbnQgb24gbXkgZml4LiBUaGFua3MgZm9yIHNvcnRpbmcgdGhhdCBvdXQuCgpDb2xp bgoKPiAKPiBSZWdhcmRzLCBKb29uYXMKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=