From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v5 00/12] introduce fail-safe PMD Date: Thu, 8 Jun 2017 15:25:03 +0100 Message-ID: <10800fbf-40ba-d3a2-d0c9-277980f44cd9@intel.com> References: <85d051e9-626a-9228-3ee0-a098be2586f4@intel.com> <20170608133004.GE18840@bidouze.vm.6wind.com> <971db9c7-8ea9-3e79-a4f5-cf391226c83d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2E8AC2BB9 for ; Thu, 8 Jun 2017 16:25:06 +0200 (CEST) In-Reply-To: <971db9c7-8ea9-3e79-a4f5-cf391226c83d@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/8/2017 3:20 PM, Ferruh Yigit wrote: > On 6/8/2017 2:30 PM, Gaëtan Rivet wrote: >> On Thu, Jun 08, 2017 at 11:56:37AM +0100, Ferruh Yigit wrote: >>> On 6/8/2017 12:59 AM, Gaetan Rivet wrote: >>>> eal: complete attach / detach support >>>> http://dpdk.org/ml/archives/dev/2017-May/066366.html >>>> http://dpdk.org/dev/patchwork/patch/24522/ >>>> >>>> ethdev: add flow API rule copy function >>>> http://dpdk.org/ml/archives/dev/2017-May/066145.html >>>> http://dpdk.org/dev/patchwork/patch/24406/ >>>> >>>> ethdev: add isolated mode to flow API >>>> http://dpdk.org/ml/archives/dev/2017-April/064327.html >>>> http://dpdk.org/dev/patchwork/patch/23741/ >>> >>> Hi Gaetan, >>> >>> Above dependencies are not enough to apply the PMD, it seems above ones >>> also has dependencies to other patchsets, specially eal one that I am >>> not able trace its dependencies from mails. >>> >>> Since most of the eal patches are also from you, can you please list >>> dependency tree to apply the PMD? >>> >>> Thanks, >>> ferruh >>> >> >> Hi Ferruh, >> >> here is the full list of patchsets that I have currently in my tree, in >> order, up until the fail-safe PMD: >> >> --- >> >> [0] ethdev: add isolated mode to flow API >> http://dpdk.org/ml/archives/dev/2017-April/064327.html >> >> [1] ethdev: add flow API rule copy function >> http://dpdk.org/ml/archives/dev/2017-May/066145.html >> >> [2] Remove PCI and VDEV dependency from eventdev library >> http://dpdk.org/ml/archives/dev/2017-June/067402.html >> >> [3] Remove cryptodev driver >> http://dpdk.org/ml/archives/dev/2017-May/066382.html >> >> [4] bus: attach / detach API >> http://dpdk.org/ml/archives/dev/2017-June/067474.html >> >> [5] pci: implement find_device bus operation >> http://dpdk.org/ml/archives/dev/2017-June/067485.html >> >> [6] rte_bus parse API >> http://dpdk.org/ml/archives/dev/2017-June/067486.html >> >> [7] Generic devargs parsing >> http://dpdk.org/ml/archives/dev/2017-June/067496.html >> >> [8] eal: complete attach / detach support >> http://dpdk.org/ml/archives/dev/2017-June/067516.html >> >> [9] bus/pci: remove PCI bus from EAL >> http://dpdk.org/ml/archives/dev/2017-June/067520.html >> >> [10] introduce fail-safe PMD >> http://dpdk.org/ml/archives/dev/2017-June/067533.html >> >> --- >> >> [2] has a slight compilation issue that I fixed with >> https://github.com/grivet/dpdk/commit/1af1272bd3129e90ae7c4ab005e85d5f8a2f95fe >> However Jerin has not yet answered to this issue (see: >> http://dpdk.org/ml/archives/dev/2017-June/067412.html ) >> >> The failsafe PMD only depends on 0, 1, 4, 5, 6, 7, 8. All others are >> left there for consistency. > > Thanks Gaetan, > > I did able to apply the patchset, I think it is good idea to wait for > PMD until things settle down in dependent patches side. btw, first three patches of the failsafe patchset are more generic ethdev layer patches. I think they shouldn't be merged as part of PMD patchset. What do you think separating them into separate patchset (or perhaps individual patches, since they looks independent from eachother)? Thanks, ferruh > > > btw,getting build error [1], CFLAGS += -D_DEFAULT_SOURCE may help. > > [1] > /usr/include/features.h:148:3: error: #warning "_BSD_SOURCE and > _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp] > # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use > _DEFAULT_SOURCE" >