From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Skripkin <paskripkin@gmail.com>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Laight <David.Laight@aculab.com>
Subject: Re: [PATCH v3 3/3] staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N()
Date: Thu, 09 Sep 2021 10:11:10 +0200 [thread overview]
Message-ID: <10808398.E1SmXddD8m@localhost.localdomain> (raw)
In-Reply-To: <5a359f20e80341c9910ecc6286eb0aec@AcuMS.aculab.com>
On Tuesday, September 7, 2021 12:10:19 PM CEST David Laight wrote:
> From: Fabio M. De Francesco
> > Sent: 04 September 2021 23:01
> >
> > Shorten the calls chain of rtw_write8/16/32() down to the actual writes.
> > For this purpose unify the four usb_write8/16/32/N() into the new
> > usb_write(); make the latter parameterizable with 'size'; embed most of
> > the code of usbctrl_vendorreq() into usb_write() and use in it the new
> > usb_control_msg_send() API of USB Core.
> >
> ...
> > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/
staging/r8188eu/hal/usb_ops_linux.c
> > index f9c4fd5a2c53..e31d1b1fdb12 100644
> > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> > @@ -8,76 +8,51 @@
> > #include "../include/recv_osdep.h"
> > #include "../include/rtl8188e_hal.h"
> >
> > -static int usbctrl_vendorreq(struct intf_hdl *pintfhdl, u16 value, void
*pdata, u16 len, u8
> > requesttype)
> > +static int usb_read(struct intf_hdl *intfhdl, u32 addr, void *data, u8
size)
> > {
> > - struct adapter *adapt = pintfhdl->padapter;
> > - struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt);
> > + u16 value = (u16)(addr & 0x0000ffff);
> > + struct adapter *adapt = intfhdl->padapter;
> > + struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt);
> > struct usb_device *udev = dvobjpriv->pusbdev;
> > - unsigned int pipe;
> > - int status = 0;
> > - u8 *pIo_buf;
> > + int status;
> > + u8 *io_buf;
>
> Some of these changes are whitespace or renames.
> They ought to be in a different patch.
Dear David,
No, they are not.
I guess you were misled by the structure of the patches. There is nothing I
can do about it. Please notice that usb_read() is created in 2/3, and I'm
free to use the name of the variables I like in new functions. Furthermore,
usb_read() is untouched in 3/3. I can see why you thought they are renames :)
>
> I think you'll need 'reverse xmas tree' ordering as well.
>
I didn't know this rule, but I must agree that this style is horrible. I'll
change the order of variables declaration for the purpose of fixing this
ugly "reverse Xmas tree".
Thanks for your review.
Regards,
Fabio
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1
1PT, UK
> Registration No: 1397386 (Wales)
>
>
next prev parent reply other threads:[~2021-09-09 8:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 22:00 [PATCH v3 0/3] staging: r8188eu: Shorten and simplify calls chain Fabio M. De Francesco
2021-09-04 22:00 ` [PATCH v3 1/3] staging: r8188eu: remove _io_ops structure Fabio M. De Francesco
2021-09-06 13:56 ` Greg Kroah-Hartman
2021-09-06 14:01 ` Pavel Skripkin
2021-09-06 14:08 ` Greg Kroah-Hartman
2021-09-06 17:19 ` Pavel Skripkin
2021-09-07 5:01 ` Greg Kroah-Hartman
2021-09-04 22:00 ` [PATCH v3 2/3] staging: r8188eu: Shorten calls chain of rtw_read8/16/32() Fabio M. De Francesco
2021-09-06 14:07 ` Greg Kroah-Hartman
2021-09-06 14:22 ` Pavel Skripkin
2021-09-09 7:53 ` Fabio M. De Francesco
2021-09-10 15:19 ` Fabio M. De Francesco
2021-09-10 19:05 ` Fabio M. De Francesco
2021-09-04 22:00 ` [PATCH v3 3/3] staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N() Fabio M. De Francesco
2021-09-07 10:10 ` David Laight
2021-09-07 10:17 ` Pavel Skripkin
2021-09-09 8:11 ` Fabio M. De Francesco [this message]
2021-09-09 8:21 ` David Laight
2021-09-09 8:31 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10808398.E1SmXddD8m@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=David.Laight@aculab.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.