From: Thomas Monjalon <thomas@monjalon.net>
To: John Griffin <john.griffin@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Deepak Kumar Jain <deepak.k.jain@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Herbert Guan <herbert.guan@arm.com>
Cc: stable@dpdk.org, dev@dpdk.org, david.marchand@redhat.com,
nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] crypto/qat: fix uninitilized compiler warning
Date: Wed, 19 May 2021 09:56:11 +0200 [thread overview]
Message-ID: <10811692.tepGkDS67r@thomas> (raw)
In-Reply-To: <20210517090709.4078-1-feifei.wang2@arm.com>
17/05/2021 11:07, Feifei Wang:
> In Arm platform, when "RTE_ARCH_ARM64_MEMCPY" is set as true, compiler
> will report variable uninitilized warning:
>
> ../drivers/crypto/qat/qat_sym_session.c:
> In function ‘partial_hash_compute’:
> ../lib/eal/include/generic/rte_byteorder.h:241:24: warning:
> ‘<U35a0>’ may be used uninitialized in this function
> [-Wmaybe-uninitialized]
> 241 | #define rte_bswap32(x) __builtin_bswap32(x)
> ...
>
> This is because "digest" will be initialized by "rte_memcpy" function
> rather than "memcpy" if "RTE_ARCH_ARM64_MEMCPY" is set as true. However,
> compiler cannot know it is initialized by the function.
>
> To fix this, use "calloc" to initialize "digest".
>
> Fixes: cd7fc8a84b48 ("eal/arm64: optimize memcpy")
> Cc: stable@dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> v2: add check and free for memory dynamic allocation (David Marchand)
> v3: fix compiler error
I am not confortable applying this patch without PMD maintainers ack.
next prev parent reply other threads:[~2021-05-19 7:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 7:41 [dpdk-dev] [PATCH] crypto/qat: fix uninitilized compiler warning Feifei Wang
2021-05-14 7:49 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-05-14 8:01 ` [dpdk-dev] 回复: " Feifei Wang
2021-05-14 8:13 ` [dpdk-dev] " David Marchand
2021-05-14 8:30 ` [dpdk-dev] 回复: " Feifei Wang
2021-05-17 9:07 ` [dpdk-dev] [PATCH v3] " Feifei Wang
2021-05-19 7:56 ` Thomas Monjalon [this message]
2021-05-19 8:11 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-05-20 5:44 ` [dpdk-dev] 回复: " Feifei Wang
2021-05-20 8:08 ` Ferruh Yigit
2021-05-19 13:13 ` [dpdk-dev] " Dybkowski, AdamX
2021-05-19 13:16 ` Dybkowski, AdamX
2021-05-20 5:47 ` [dpdk-dev] 回复: " Feifei Wang
2021-05-20 8:43 ` [dpdk-dev] [PATCH v4] crypto/qat: fix uninitilized gcc " Feifei Wang
2021-05-20 9:06 ` Dybkowski, AdamX
2021-05-21 2:00 ` [dpdk-dev] [PATCH v5] crypto/qat: fix uninitialized " Feifei Wang
2021-06-29 20:04 ` [dpdk-dev] [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10811692.tepGkDS67r@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=fiona.trahe@intel.com \
--cc=herbert.guan@arm.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.griffin@intel.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.