From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B528C433F5 for ; Tue, 14 Dec 2021 19:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbhLNT5n (ORCPT ); Tue, 14 Dec 2021 14:57:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:46284 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbhLNT5n (ORCPT ); Tue, 14 Dec 2021 14:57:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639511863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lWNXdC7c4/QvF14/ly2qEacx83h1zt3femW1UptwI/g=; b=W68miiB0pHR1rHb3w9Xh7ypAdKwuYKvffl+FiMwP6MKbLNW5cTyGep4vAbEqui+VDIkyHg 0jlhtpnv6xZFoBeJpVos+31IqCd2Pw5uwH3YDgcUxAZPqOAV8VfFcACs5omyJUFFa+oeze 4uvrG1Scon+Z4b4lXvjPevt5pwXqT44= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-LJ_2iVCRNWO_4MGxCIm4rg-1; Tue, 14 Dec 2021 14:57:39 -0500 X-MC-Unique: LJ_2iVCRNWO_4MGxCIm4rg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C884F1926DA0; Tue, 14 Dec 2021 19:57:36 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D3C41017E27; Tue, 14 Dec 2021 19:57:27 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87e6960c660eaa883d6ee81c25449cf6fa3c9c19.camel@kernel.org> References: <87e6960c660eaa883d6ee81c25449cf6fa3c9c19.camel@kernel.org> <163906878733.143852.5604115678965006622.stgit@warthog.procyon.org.uk> <163906890630.143852.13972180614535611154.stgit@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, linux-cachefs@redhat.com, Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Matthew Wilcox , Alexander Viro , Omar Sandoval , JeffleXu , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/67] fscache: Implement volume registration MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1082028.1639511847.1@warthog.procyon.org.uk> Date: Tue, 14 Dec 2021 19:57:27 +0000 Message-ID: <1082029.1639511847@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Jeff Layton wrote: > > Do we need the last two parameters to fscache_acquire_volume? I'll note > that all of the callers in the current set just pass "NULL, 0" for them. cifs wants to set it. I have a patch to make cachefiles store this. afs should use it also. David