From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D005C6FD1C for ; Sun, 26 Mar 2023 09:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbjCZJhZ (ORCPT ); Sun, 26 Mar 2023 05:37:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbjCZJhV (ORCPT ); Sun, 26 Mar 2023 05:37:21 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A13901723 for ; Sun, 26 Mar 2023 02:37:19 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id i5so24530774eda.0 for ; Sun, 26 Mar 2023 02:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=GHkGxIaUDHD9EVehc6ie2OQuCwM40c0Sa/sF8VYs8OH+m5MpI3q68BwrNW2YOW+ipo cr8ES+JlIAq13MyMuLYnUBFfN4xtMwH0x+BZO/eD5KI//izd5SSS38fr7Qx44Q47Osf2 wx3toJdDGo5LVoFftdIU24vVQIn8RpVXMhDydizeu2K+WBADhg4BQNQWFubeMA6aaztF KbNI93cdJebCDYh1WgyGa0VIw1YzUdWOeGLBlbOmv6u+uf3zDtGkgxXqcjiT/BdkBipL R5X8U6f7aLAJxgX0s6M2UAxge20lJpE3eyn0H9NF1XHvtJV0pqA9jASBh5tFolIMR0nF Qh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=sbLa1s2gL9w6kPn0hxNbAnTvtNmOPu08Y56kVWC+5n/ffiFi05VDM4v+wZrvOIzyCg kbyqpk7iuj42hQMf9gh9yL0X4kevlzAWMUiRWHk/81SugD9vAkPG4D0iz5wIEQfJDl1P xP/ku0lRNJMNYxxcZBXHg8S3SiOi9nPe0EyZqx2pLedd8wssS4OHXXRBEorg3qLHNimP 36paMvQnrZd3Ajd0158K5EyQUBwKChdhdQxjfv22VPhimFeu/4H2i86yGMnBtY/DZT5n ktazSiAJ+5mOvaHYkaasYCNzvMqN/hbo02kZEeQU9XFqrbwc1notNeXDDE6RyQVGzui/ v9YA== X-Gm-Message-State: AAQBX9fjyPAl7UCaxzCnSwQbByW52MrCSyT7Em0qcieBBFKkGseGW6Kp 1vr5uCZEEkcnimWyVu8pFb09Hg== X-Google-Smtp-Source: AKy350aR88wKTInMhM2+4A7tNI6V5uRWI3jQ2Pt0sIPnZuOvt7Cl/gcLtj4c8VsNeo0rbho+lF/46A== X-Received: by 2002:a05:6402:8d6:b0:502:2953:8ecb with SMTP id d22-20020a05640208d600b0050229538ecbmr5138565edz.13.1679823438181; Sun, 26 Mar 2023 02:37:18 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:6cac:926d:a4f2:aa09? ([2a02:810d:15c0:828:6cac:926d:a4f2:aa09]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004af70c546dasm13284309edj.87.2023.03.26.02.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 02:37:17 -0700 (PDT) Message-ID: <10930783-e1dd-5e75-a2cc-a09af862d949@linaro.org> Date: Sun, 26 Mar 2023 11:37:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Content-Language: en-US To: Shane Francis Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230326001535.149539-1-bigbeeshane@gmail.com> <20230326001535.149539-2-bigbeeshane@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230326001535.149539-2-bigbeeshane@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/03/2023 01:15, Shane Francis wrote: > Some vendor uboot bootloaders use the target kernels > DTB image to determine the target clock speeds for > some PLLs, currently this can cause uboot to set the > clock rate for gpll incorrectly on to cpll (breaking) Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > RGMII. > > This change starts the PLL clock definitions from 1 > to correct this miss-match Unfortunately the reason is not good enough for ABI break. Replace vendor boot uboots with open-source one or just correct them (it's still U-Boot so even for vendor one you have the source). > > Signed-off-by: Shane Francis > --- > .../dt-bindings/clock/rockchip,rk3588-cru.h | 1442 ++++++++--------- > 1 file changed, 721 insertions(+), 721 deletions(-) > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h > index b5616bca7b44..d63b07d054b7 100644 > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h > @@ -12,727 +12,727 @@ > > /* cru-clocks indices */ > > -#define PLL_B0PLL 0 Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 517F4C7619A for ; Sun, 26 Mar 2023 09:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7P+nAEEn5jpC9dkTCIjbSOuk74NzLCcrYmKqW51jpEI=; b=v3tiSkakJfZv9Z 5eBThAzM26I7IuLnvzrGlOrBhghAlhmAZqoDeChBdCF7lhoir2BWCWNVgJrrqpb0mkDIgD+MvATwh c1l8WJhT4YoI8vajG51JGdUHW8T/Y5rFvdyZjMa8pq1fYAZY22TPy0pGKn58Y3eT4+SOSJODZEcXT 1ylZGelwMUnkD3cfiInYbj4Dm7nK6Wt4TYPhJDs+kKzObknBBYFLh0DsOhDdbvZTTU/WOwNVdkPBC cr47CUxVNHjv/Aci5MpS3O7ihNkQPdCFQgkSOzl0Drm5FJM3GZuvnYeqO31VgtN242BhopWgz3wq6 cK7qR0aagK+hJyOVMz+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgMoV-008FEC-2L; Sun, 26 Mar 2023 09:37:23 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgMoS-008FDV-2b for linux-rockchip@lists.infradead.org; Sun, 26 Mar 2023 09:37:22 +0000 Received: by mail-ed1-x536.google.com with SMTP id b20so24410711edd.1 for ; Sun, 26 Mar 2023 02:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=GHkGxIaUDHD9EVehc6ie2OQuCwM40c0Sa/sF8VYs8OH+m5MpI3q68BwrNW2YOW+ipo cr8ES+JlIAq13MyMuLYnUBFfN4xtMwH0x+BZO/eD5KI//izd5SSS38fr7Qx44Q47Osf2 wx3toJdDGo5LVoFftdIU24vVQIn8RpVXMhDydizeu2K+WBADhg4BQNQWFubeMA6aaztF KbNI93cdJebCDYh1WgyGa0VIw1YzUdWOeGLBlbOmv6u+uf3zDtGkgxXqcjiT/BdkBipL R5X8U6f7aLAJxgX0s6M2UAxge20lJpE3eyn0H9NF1XHvtJV0pqA9jASBh5tFolIMR0nF Qh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=XmkdPhoFUSSxMbyPiCRK4ouCyJvGmUie9+48w4Hnqht+7pRmGiaqsDkF5jj1K6KeiC AvwISo8mwdmU3f4BCCQphR/Y96ueGow3ta/ujwkaPOmMGZq5125adsAFV9VPW6nQpxgR m8hOBCupTN/YDoLxRI5vhec65RsD8njaKX0/C3H3JXdR4MZw1O7j+canZmbNTF68Es43 qEycbvxSeZBUOHGoU8QhylcSLkavzAw9Q8jMEN4a0xp7cm3lXm3YvIoV70N/XNogM8E1 V+XLuDY1kupeRa6U7NFblg8lJa56sIa7G6UMbMg4p36DPtqq/BNiHf8q3E/+zuP16ahI hKYA== X-Gm-Message-State: AAQBX9fwumHiy5cUjRFKYC/QWl4NlP139zbeEmHtNGZ+JI0e2HMCIEVN nwANUoDMhLukj15//sXDtCjTOA== X-Google-Smtp-Source: AKy350aR88wKTInMhM2+4A7tNI6V5uRWI3jQ2Pt0sIPnZuOvt7Cl/gcLtj4c8VsNeo0rbho+lF/46A== X-Received: by 2002:a05:6402:8d6:b0:502:2953:8ecb with SMTP id d22-20020a05640208d600b0050229538ecbmr5138565edz.13.1679823438181; Sun, 26 Mar 2023 02:37:18 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:6cac:926d:a4f2:aa09? ([2a02:810d:15c0:828:6cac:926d:a4f2:aa09]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004af70c546dasm13284309edj.87.2023.03.26.02.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 02:37:17 -0700 (PDT) Message-ID: <10930783-e1dd-5e75-a2cc-a09af862d949@linaro.org> Date: Sun, 26 Mar 2023 11:37:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Content-Language: en-US To: Shane Francis Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230326001535.149539-1-bigbeeshane@gmail.com> <20230326001535.149539-2-bigbeeshane@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230326001535.149539-2-bigbeeshane@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_023720_872450_81CF24F8 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 26/03/2023 01:15, Shane Francis wrote: > Some vendor uboot bootloaders use the target kernels > DTB image to determine the target clock speeds for > some PLLs, currently this can cause uboot to set the > clock rate for gpll incorrectly on to cpll (breaking) Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > RGMII. > > This change starts the PLL clock definitions from 1 > to correct this miss-match Unfortunately the reason is not good enough for ABI break. Replace vendor boot uboots with open-source one or just correct them (it's still U-Boot so even for vendor one you have the source). > > Signed-off-by: Shane Francis > --- > .../dt-bindings/clock/rockchip,rk3588-cru.h | 1442 ++++++++--------- > 1 file changed, 721 insertions(+), 721 deletions(-) > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h > index b5616bca7b44..d63b07d054b7 100644 > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h > @@ -12,727 +12,727 @@ > > /* cru-clocks indices */ > > -#define PLL_B0PLL 0 Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0882C6FD1C for ; Sun, 26 Mar 2023 09:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cnUIjli9NUD98eGlAwjb33oAzHGi5EpJlzlZw2HKht8=; b=E2/yaFJtrHnl0L J+W4qnu2DWqAsH0olDhKGrtiJ2bCrLxN9XV9lIkofje3VQ6HSKDvWN4QQT6QMKOVr9B1TmRCyJdsa gVIwmMQhWEAqWXgIj0t6hulIFSfs+JguLIzI/GyZ3eATP03sC5PtXlDMgwfkhO+cnPLQNAt1rFulZ WDpq5qPPe+OK0s043gRtVj2YZH9kIURBKJENMV/0xmHDjZ3eCcWICtEuUtaF5P44bUVdSqYUCfODF S7CIs0VTiodmHThNzlKlLvdaKVPqGlSAtUrSdtjsui1VV443E8WhvXIdt3wzfPEo3f+ZcTY06JZnG h4PErVNCNRzVPCZYbJeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgMoW-008FEL-0Y; Sun, 26 Mar 2023 09:37:24 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgMoS-008FDW-2b for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 09:37:22 +0000 Received: by mail-ed1-x529.google.com with SMTP id w9so24389827edc.3 for ; Sun, 26 Mar 2023 02:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=GHkGxIaUDHD9EVehc6ie2OQuCwM40c0Sa/sF8VYs8OH+m5MpI3q68BwrNW2YOW+ipo cr8ES+JlIAq13MyMuLYnUBFfN4xtMwH0x+BZO/eD5KI//izd5SSS38fr7Qx44Q47Osf2 wx3toJdDGo5LVoFftdIU24vVQIn8RpVXMhDydizeu2K+WBADhg4BQNQWFubeMA6aaztF KbNI93cdJebCDYh1WgyGa0VIw1YzUdWOeGLBlbOmv6u+uf3zDtGkgxXqcjiT/BdkBipL R5X8U6f7aLAJxgX0s6M2UAxge20lJpE3eyn0H9NF1XHvtJV0pqA9jASBh5tFolIMR0nF Qh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679823438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=womt1sTjj98HBWC12qs0rQLizgn/XM7va5jl8pNY4ac=; b=IfaSTXY18OjLJkxrawiLeTgnUVBRmlD+blACGGyqMr2qV9h4189Q6xw6Prx/xXrKYJ rJcP90+TrbkfCXitfzicttO8INLJ9zsqGaRu7Zk18SNPkFTtmqXpRrHt+PngFt20aJ4Y 5CfMG6BtRpEc8cJpnxKLCw7CXBAhuR8AJqs4alljGjrhbv1+8dr1F2hqTg+fVtiP5vc/ SXqV+sOsoXQtM8uHqhfEUi+B06wWqsKe6iGdHgu412FWf60wWRu3gNYS9GjGfp+OW6to LYZnZwfQ1B8Es7W76B6v0oM9HJCI4wvJotM/fSoskASywCMTn13e9Uj2eXpQO4sBMzkN dN9w== X-Gm-Message-State: AAQBX9c8qFhy8Y/Y4aZbKJlV38tLYgCtslNN+lRCSs43EOUpecbrlO9x jj4SgW9VxPO8bCpgSL2fZ/sMcw== X-Google-Smtp-Source: AKy350aR88wKTInMhM2+4A7tNI6V5uRWI3jQ2Pt0sIPnZuOvt7Cl/gcLtj4c8VsNeo0rbho+lF/46A== X-Received: by 2002:a05:6402:8d6:b0:502:2953:8ecb with SMTP id d22-20020a05640208d600b0050229538ecbmr5138565edz.13.1679823438181; Sun, 26 Mar 2023 02:37:18 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:6cac:926d:a4f2:aa09? ([2a02:810d:15c0:828:6cac:926d:a4f2:aa09]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004af70c546dasm13284309edj.87.2023.03.26.02.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 02:37:17 -0700 (PDT) Message-ID: <10930783-e1dd-5e75-a2cc-a09af862d949@linaro.org> Date: Sun, 26 Mar 2023 11:37:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Content-Language: en-US To: Shane Francis Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230326001535.149539-1-bigbeeshane@gmail.com> <20230326001535.149539-2-bigbeeshane@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230326001535.149539-2-bigbeeshane@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_023720_872308_452B2385 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/03/2023 01:15, Shane Francis wrote: > Some vendor uboot bootloaders use the target kernels > DTB image to determine the target clock speeds for > some PLLs, currently this can cause uboot to set the > clock rate for gpll incorrectly on to cpll (breaking) Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > RGMII. > > This change starts the PLL clock definitions from 1 > to correct this miss-match Unfortunately the reason is not good enough for ABI break. Replace vendor boot uboots with open-source one or just correct them (it's still U-Boot so even for vendor one you have the source). > > Signed-off-by: Shane Francis > --- > .../dt-bindings/clock/rockchip,rk3588-cru.h | 1442 ++++++++--------- > 1 file changed, 721 insertions(+), 721 deletions(-) > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h > index b5616bca7b44..d63b07d054b7 100644 > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h > @@ -12,727 +12,727 @@ > > /* cru-clocks indices */ > > -#define PLL_B0PLL 0 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel