All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roy Spliet <nouveau-NQbd8FSOZ1kdnm+yROfE0A@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 0/5] GPU-DRM-nouveau: Fine-tuning for five function implementations
Date: Wed, 21 Sep 2016 09:09:50 +0100	[thread overview]
Message-ID: <1094e314-f465-43ba-65d0-32ec5ed55d67@spliet.org> (raw)
In-Reply-To: <5bcff2ec-f3bd-ab9c-e13d-3a4f5cf7c73b-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1165 bytes --]

Thanks for these style fixes. Patches 1 and 2 seem good at first sight. 
Not acking because I haven't tested the patches and the implementation 
of kmalloc_array() appears to slightly differ from kmalloc(). This 
difference *should* only affect allocations larger than the ones in 
patch 1 and 2, but I'd like to see these changes tested before I can 
sleep soundly!

Patches 4 and 5 are:

Reviewed-by: Roy Spliet <nouveau-NQbd8FSOZ1kdnm+yROfE0A@public.gmane.org>


Op 21-09-16 om 08:23 schreef SF Markus Elfring:
> From: Markus Elfring<elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> Date: Wed, 21 Sep 2016 09:09:09 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (5):
>    Use kmalloc_array() in nvbios_iccsense_parse()
>    Use kmalloc_array() in gt215_link_train()
>    Delete unnecessary braces
>    Adjust a kzalloc() call in gt215_ram_new()
>    Add space after an "if"
>
>   drivers/gpu/drm/nouveau/nvkm/subdev/bios/iccsense.c |  4 +++-
>   drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c   | 21 +++++++++------------
>   2 files changed, 12 insertions(+), 13 deletions(-)
>


[-- Attachment #1.2: Type: text/html, Size: 1903 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2016-09-21  8:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  7:23 [PATCH 0/5] GPU-DRM-nouveau: Fine-tuning for five function implementations SF Markus Elfring
2016-09-21  7:23 ` SF Markus Elfring
2016-09-21  7:23 ` SF Markus Elfring
2016-09-21  7:24 ` [PATCH 1/5] GPU-DRM-nouveau: Use kmalloc_array() in nvbios_iccsense_parse() SF Markus Elfring
2016-09-21  7:24   ` SF Markus Elfring
2016-09-21  7:24   ` SF Markus Elfring
2016-09-21  7:25 ` [PATCH 2/5] GPU-DRM-nouveau: Use kmalloc_array() in gt215_link_train() SF Markus Elfring
2016-09-21  7:25   ` SF Markus Elfring
2016-09-21  7:25   ` SF Markus Elfring
2016-09-21  7:26 ` [PATCH 3/5] GPU-DRM-nouveau: Delete unnecessary braces SF Markus Elfring
2016-09-21  7:26   ` SF Markus Elfring
2016-09-21  7:26   ` SF Markus Elfring
     [not found]   ` <74cc2e34-cb5f-e3c9-e6cd-aa24ed3529e3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2016-09-21  7:49     ` Roy Spliet
2016-09-21  8:47   ` Dan Carpenter
2016-09-21  8:47     ` Dan Carpenter
2016-09-21 13:20     ` SF Markus Elfring
2016-09-21 13:20       ` SF Markus Elfring
2016-09-21  7:28 ` [PATCH 4/5] GPU-DRM-nouveau: Adjust a kzalloc() call in gt215_ram_new() SF Markus Elfring
2016-09-21  7:28   ` SF Markus Elfring
2016-09-21  7:28   ` SF Markus Elfring
2016-09-21  7:29 ` [PATCH 5/5] GPU-DRM-nouveau: Add space after an "if" SF Markus Elfring
2016-09-21  7:29   ` SF Markus Elfring
2016-09-21  7:29   ` SF Markus Elfring
     [not found] ` <5bcff2ec-f3bd-ab9c-e13d-3a4f5cf7c73b-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2016-09-21  8:09   ` Roy Spliet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094e314-f465-43ba-65d0-32ec5ed55d67@spliet.org \
    --to=nouveau-nqbd8fsoz1kdnm+yrofe0a@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.