From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Latimer Subject: Re: freemem-slack and large memory environments Date: Thu, 26 Feb 2015 13:45:16 -0700 Message-ID: <10963636.bJrCl8V3JU@mlatimer1.dnsdhcp.provo.novell.com> References: <4321015.nah3j6dvJq@mlatimer1.dnsdhcp.provo.novell.com> <4455263.R3RfNP62EE@mlatimer1.dnsdhcp.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thursday, February 26, 2015 05:53:06 PM Stefano Stabellini wrote: > What is the return value of libxl_set_memory_target and > libxl_wait_for_free_memory in that case? Isn't it just a matter of > properly handle the return values? The return from libxl_set_memory_target is 0, as the assignment works just fine. I don't have the return from libxl_wait_for_free_memory in my notes, so I'll spin up another test and track that down. > Or maybe we just need to change the libxl_set_memory_target call to use > an absolute memory target to avoid restricting dom0 memory more than > necessary at each iteration. Also increasing the timeout argument passed > to the libxl_wait_for_free_memory call could help. Using an absolute target would help, and would obviously only have to be set once - which is similar to what my patch did. Increasing the timeout would help, but if the timeout were insufficient (say when dealing with very large guests), it wouldn't solve the problem. -Mike