From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 10 May 2019 14:01:31 +0200 Subject: [U-Boot] [PATCH 10/14] ddr: altera: agilex: Add SDRAM driver for Agilex In-Reply-To: <1557467688-73706-11-git-send-email-ley.foon.tan@intel.com> References: <1557467688-73706-1-git-send-email-ley.foon.tan@intel.com> <1557467688-73706-11-git-send-email-ley.foon.tan@intel.com> Message-ID: <109b5a4d-df8c-b195-0a30-ff2b1752014c@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 5/10/19 7:54 AM, Ley Foon Tan wrote: > Add SDRAM driver for Agilex SoC. > > Signed-off-by: Tien Fong Chee > Signed-off-by: Ley Foon Tan > --- > drivers/ddr/altera/Kconfig | 6 +- > drivers/ddr/altera/Makefile | 1 + > drivers/ddr/altera/sdram_agilex.c | 158 ++++++++++++++++++++++++++++++ > drivers/ddr/altera/sdram_common.c | 1 + > drivers/ddr/altera/sdram_common.h | 1 + > 5 files changed, 164 insertions(+), 3 deletions(-) > create mode 100644 drivers/ddr/altera/sdram_agilex.c [...] > + /* This enables nonsecure access to DDR */ > + /* mpuregion0addr_limit */ > + FW_MPU_DDR_SCR_WRITEL(gd->ram_size - 1, > + FW_MPU_DDR_SCR_MPUREGION0ADDR_LIMIT); > + FW_MPU_DDR_SCR_WRITEL(0x1F, FW_MPU_DDR_SCR_MPUREGION0ADDR_LIMITEXT); Why is the function name in caps? > + > + /* nonmpuregion0addr_limit */ > + FW_MPU_DDR_SCR_WRITEL(gd->ram_size - 1, > + FW_MPU_DDR_SCR_NONMPUREGION0ADDR_LIMIT); > + > + /* Enable mpuregion0enable and nonmpuregion0enable */ > + FW_MPU_DDR_SCR_WRITEL(MPUREGION0_ENABLE | NONMPUREGION0_ENABLE, > + FW_MPU_DDR_SCR_EN_SET); > + > + u32 ctrlcfg1 = hmc_readl(plat, CTRLCFG1); Doesn't the C compiler warn about variable defined in the middle of code ? [...] -- Best regards, Marek Vasut