Re: [meta-networking][PATCH 2/2 v2] ncp: add v1.2.4

[Khem Raj <raj.khem@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2095 bytes --]



On 11/16/16 1:02 AM, André Draszik wrote:
> Signed-off-by: André Draszik <git@andred.net>
> ---
>  meta-networking/recipes-support/ncp/ncp_1.2.4.bb | 32 ++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 meta-networking/recipes-support/ncp/ncp_1.2.4.bb
> 
> diff --git a/meta-networking/recipes-support/ncp/ncp_1.2.4.bb b/meta-networking/recipes-support/ncp/ncp_1.2.4.bb
> new file mode 100644
> index 0000000..7bbaaad
> --- /dev/null
> +++ b/meta-networking/recipes-support/ncp/ncp_1.2.4.bb
> @@ -0,0 +1,32 @@
> +SUMMARY = "a fast file copy tool for LANs"
> +DESCRIPTION = "ncp is a utility for copying files in a LAN. It has absolutely no \
> +security or integrity checking, no throttling, no features, except \
> +one: you don't have to type the coordinates of your peer."
> +HOMEPAGE = "http://www.fefe.de/ncp"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
> +DEPENDS = "libowfat"
> +
> +SRC_URI = "https://dl.fefe.de/${BP}.tar.bz2"
> +SRC_URI[md5sum] = "421c4855bd3148b7d0a4342942b4bf13"
> +SRC_URI[sha256sum] = "6cfa72edd5f7717bf7a4a93ccc74c4abd89892360e2e0bb095a73c24b9359b88"
> +
> +EXTRA_OEMAKE = "\
> +    DIET= \
> +    DEBUG=nostrip \
> +    CC='${CC}' CFLAGS='${CFLAGS} -I${STAGING_INCDIR}/libowfat' LDFLAGS='${LDFLAGS}' \
> +"

Is setting CC etc. on make cmdline really needed ?
may be just adding the -I flags to CPPFLAGS is enough ?

> +
> +do_install() {
> +    install -d -m0755 ${D}${bindir}

not needed if you can just do

install -D -m 0755 ncp ${D}${bindir}/ncp

and avoid two calls to install ( one for dir and another for file )

> +    install -d -m0755 ${D}${mandir}/man1
> +
> +    install -m0755 ncp ${D}${bindir}


> +    ln -sf ncp ${D}${bindir}/npoll
> +    ln -sf ncp ${D}${bindir}/npush
> +
> +    install -m0644 ncp.1 npush.1 ${D}${mandir}/man1

same here not needed.

> +    ln -sf npush.1 ${D}${mandir}/man1/npoll.1
> +}
> +
> +BBCLASSEXTEND = "native nativesdk"
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 211 bytes --]