From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_DISCARD, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4C9C07E95 for ; Wed, 7 Jul 2021 14:13:14 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 62BF161CC3 for ; Wed, 7 Jul 2021 14:13:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62BF161CC3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8C78413C8; Wed, 7 Jul 2021 16:13:12 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 9D09E413A8 for ; Wed, 7 Jul 2021 16:13:11 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3572C7F528; Wed, 7 Jul 2021 17:13:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3572C7F528 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625667191; bh=VlD539yrMKxN9SYSex8bi5xV4crvAcGZPXxD3QqwnQc=; h=Subject:To:References:From:Date:In-Reply-To; b=phbGbt8NoYwypeWQEjf4ABdlNi8c3IwBAD5Odsu//0MHSay8cg2NrhWV/sChXou9/ pu3Ep3ic/rA5gWXPGZPepOG9M48H4YXMTUGwvEYyw8bT1OhfqDUd8fyW+F1X3DNKhR rbwOcUMGQHwb+XbLGmQx30UL6IbxNY/0ZdOEh+DM= To: Jiawen Wu , dev@dpdk.org References: <20210706095545.10776-1-jiawenwu@trustnetic.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <109ea936-11f0-8f67-9fb4-55194ab3a0f7@oktetlabs.ru> Date: Wed, 7 Jul 2021 17:13:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210706095545.10776-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 00/19] net: ngbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/6/21 12:55 PM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. Hopefully final review. $ ./devtools/check-meson.py Error: Incorrect indent at drivers/net/meson.build:43 Error: Incorrect indent at drivers/net/ngbe/meson.build:14 Error: Incorrect indent at drivers/net/ngbe/meson.build:15 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:5 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:6 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:7 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:8 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:9 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:10 Error: Incorrect indent at drivers/net/ngbe/base/meson.build:11 Please, run it after each patch which changes meson.build and fix errors. I'm not sure about __rte_cold markup in the patches. Do you really need it? I'll keep it up to you, but I'd recommend to remove it if you don't really see a measurable performance drop.