From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amd/amdgpu: remove vram_page_split kernel option Date: Tue, 4 Jun 2019 15:59:15 +0200 Message-ID: <10ad3c78-9539-d135-d38f-bcbb3e6e5ca1@gmail.com> References: <20190604134905.9172-1-tom.stdenis@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190604134905.9172-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "StDenis, Tom" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMDQuMDYuMTkgdW0gMTU6NDkgc2NocmllYiBTdERlbmlzLCBUb206Cj4gVGhpcyBvcHRpb24g aXMgbm8gbG9uZ2VyIG5lZWRlZC4gIFRoZSBkZWZhdWx0IGNvZGUgcGF0aHMKPiBhcmUgbm93IHRo ZSBvbmx5IG9wdGlvbi4KCk5BSywgd2Ugc3RpbGwgbmVlZCB0aGUgZnVuY3Rpb25hbGl0eS4gSXQg anVzdCBkb2Vzbid0IG5lZWRzIHRvIGJlIApjb25maWd1cmFibGUsIGJ1dCByYXRoZXIgdXNlIHRo ZSBDUFUgZGVmYXVsdHMuCgpDaHJpc3RpYW4uCgo+Cj4gU2lnbmVkLW9mZi1ieTogVG9tIFN0IERl bmlzIDx0b20uc3RkZW5pc0BhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1LmggICAgICAgICAgfCAxIC0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9kZXZpY2UuYyAgIHwgNyAtLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZHJ2LmMgICAgICB8IDggLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jIHwgNyArLS0tLS0tCj4gICA0IGZpbGVzIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdS5oCj4gaW5kZXggMTlhMDAyODJlMzRjLi5lNTRmMzE4NjVmNjAgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+IEBAIC0xNDIsNyArMTQyLDYgQEAgZXh0 ZXJuIHVpbnQgYW1kZ3B1X3NkbWFfcGhhc2VfcXVhbnR1bTsKPiAgIGV4dGVybiBjaGFyICphbWRn cHVfZGlzYWJsZV9jdTsKPiAgIGV4dGVybiBjaGFyICphbWRncHVfdmlydHVhbF9kaXNwbGF5Owo+ ICAgZXh0ZXJuIHVpbnQgYW1kZ3B1X3BwX2ZlYXR1cmVfbWFzazsKPiAtZXh0ZXJuIGludCBhbWRn cHVfdnJhbV9wYWdlX3NwbGl0Owo+ICAgZXh0ZXJuIGludCBhbWRncHVfbmdnOwo+ICAgZXh0ZXJu IGludCBhbWRncHVfcHJpbV9idWZfcGVyX3NlOwo+ICAgZXh0ZXJuIGludCBhbWRncHVfcG9zX2J1 Zl9wZXJfc2U7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ IGluZGV4IGQwMGZkNWRkMzA3YS4uZWY3ZDk5ZWJlOTJkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IEBAIC05NzMsMTMgKzk3Myw2IEBAIHN0YXRp YyBpbnQgYW1kZ3B1X2RldmljZV9jaGVja19hcmd1bWVudHMoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYpCj4gICAKPiAgIAlhbWRncHVfZGV2aWNlX2NoZWNrX2Jsb2NrX3NpemUoYWRldik7Cj4g ICAKPiAtCWlmIChhbWRncHVfdnJhbV9wYWdlX3NwbGl0ICE9IC0xICYmIChhbWRncHVfdnJhbV9w YWdlX3NwbGl0IDwgMTYgfHwKPiAtCSAgICAhaXNfcG93ZXJfb2ZfMihhbWRncHVfdnJhbV9wYWdl X3NwbGl0KSkpIHsKPiAtCQlkZXZfd2FybihhZGV2LT5kZXYsICJpbnZhbGlkIFZSQU0gcGFnZSBz cGxpdCAoJWQpXG4iLAo+IC0JCQkgYW1kZ3B1X3ZyYW1fcGFnZV9zcGxpdCk7Cj4gLQkJYW1kZ3B1 X3ZyYW1fcGFnZV9zcGxpdCA9IDEwMjQ7Cj4gLQl9Cj4gLQo+ICAgCXJldCA9IGFtZGdwdV9kZXZp Y2VfZ2V0X2pvYl90aW1lb3V0X3NldHRpbmdzKGFkZXYpOwo+ICAgCWlmIChyZXQpIHsKPiAgIAkJ ZGV2X2VycihhZGV2LT5kZXYsICJpbnZhbGlkIGxvY2t1cF90aW1lb3V0IHBhcmFtZXRlciBzeW50 YXhcbiIpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf ZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZHJ2LmMKPiBpbmRleCAx ZjM4ZDZmYzFmZTMuLmVmMjJhMmEyNTQ0OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfZHJ2LmMKPiBAQCAtMTA4LDcgKzEwOCw2IEBAIGludCBhbWRncHVfdm1fZnJhZ21l bnRfc2l6ZSA9IC0xOwo+ICAgaW50IGFtZGdwdV92bV9ibG9ja19zaXplID0gLTE7Cj4gICBpbnQg YW1kZ3B1X3ZtX2ZhdWx0X3N0b3AgPSAwOwo+ICAgaW50IGFtZGdwdV92bV9kZWJ1ZyA9IDA7Cj4g LWludCBhbWRncHVfdnJhbV9wYWdlX3NwbGl0ID0gNTEyOwo+ICAgaW50IGFtZGdwdV92bV91cGRh dGVfbW9kZSA9IC0xOwo+ICAgaW50IGFtZGdwdV9leHBfaHdfc3VwcG9ydCA9IDA7Cj4gICBpbnQg YW1kZ3B1X2RjID0gLTE7Cj4gQEAgLTM0MiwxMyArMzQxLDYgQEAgbW9kdWxlX3BhcmFtX25hbWVk KHZtX2RlYnVnLCBhbWRncHVfdm1fZGVidWcsIGludCwgMDY0NCk7Cj4gICBNT0RVTEVfUEFSTV9E RVNDKHZtX3VwZGF0ZV9tb2RlLCAiVk0gdXBkYXRlIHVzaW5nIENQVSAoMCA9IG5ldmVyIChkZWZh dWx0IGV4Y2VwdCBmb3IgbGFyZ2UgQkFSKExCKSksIDEgPSBHcmFwaGljcyBvbmx5LCAyID0gQ29t cHV0ZSBvbmx5IChkZWZhdWx0IGZvciBMQiksIDMgPSBCb3RoIik7Cj4gICBtb2R1bGVfcGFyYW1f bmFtZWQodm1fdXBkYXRlX21vZGUsIGFtZGdwdV92bV91cGRhdGVfbW9kZSwgaW50LCAwNDQ0KTsK PiAgIAo+IC0vKioKPiAtICogRE9DOiB2cmFtX3BhZ2Vfc3BsaXQgKGludCkKPiAtICogT3ZlcnJp ZGUgdGhlIG51bWJlciBvZiBwYWdlcyBhZnRlciB3ZSBzcGxpdCBWUkFNIGFsbG9jYXRpb25zIChk ZWZhdWx0IDUxMiwgLTEgPSBkaXNhYmxlKS4gVGhlIGRlZmF1bHQgaXMgNTEyLgo+IC0gKi8KPiAt TU9EVUxFX1BBUk1fREVTQyh2cmFtX3BhZ2Vfc3BsaXQsICJOdW1iZXIgb2YgcGFnZXMgYWZ0ZXIg d2Ugc3BsaXQgVlJBTSBhbGxvY2F0aW9ucyAoZGVmYXVsdCA1MTIsIC0xID0gZGlzYWJsZSkiKTsK PiAtbW9kdWxlX3BhcmFtX25hbWVkKHZyYW1fcGFnZV9zcGxpdCwgYW1kZ3B1X3ZyYW1fcGFnZV9z cGxpdCwgaW50LCAwNDQ0KTsKPiAtCj4gICAvKioKPiAgICAqIERPQzogZXhwX2h3X3N1cHBvcnQg KGludCkKPiAgICAqIEVuYWJsZSBleHBlcmltZW50YWwgaHcgc3VwcG9ydCAoMSA9IGVuYWJsZSku IFRoZSBkZWZhdWx0IGlzIDAgKGRpc2FibGVkKS4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdnJhbV9tZ3IuYwo+IGluZGV4IGVjOWVhM2ZkYmI0YS4uNGY3N2E2MDU2YTNi IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21n ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMK PiBAQCAtMjg0LDE0ICsyODQsOSBAQCBzdGF0aWMgaW50IGFtZGdwdV92cmFtX21ncl9uZXcoc3Ry dWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4sCj4gICAJaWYgKCFscGZuKQo+ICAgCQlscGZu ID0gbWFuLT5zaXplOwo+ICAgCj4gLQlpZiAocGxhY2UtPmZsYWdzICYgVFRNX1BMX0ZMQUdfQ09O VElHVU9VUyB8fAo+IC0JICAgIGFtZGdwdV92cmFtX3BhZ2Vfc3BsaXQgPT0gLTEpIHsKPiArCWlm IChwbGFjZS0+ZmxhZ3MgJiBUVE1fUExfRkxBR19DT05USUdVT1VTKSB7Cj4gICAJCXBhZ2VzX3Bl cl9ub2RlID0gfjB1bDsKPiAgIAkJbnVtX25vZGVzID0gMTsKPiAtCX0gZWxzZSB7Cj4gLQkJcGFn ZXNfcGVyX25vZGUgPSBtYXgoKHVpbnQzMl90KWFtZGdwdV92cmFtX3BhZ2Vfc3BsaXQsCj4gLQkJ CQkgICAgIG1lbS0+cGFnZV9hbGlnbm1lbnQpOwo+IC0JCW51bV9ub2RlcyA9IERJVl9ST1VORF9V UChtZW0tPm51bV9wYWdlcywgcGFnZXNfcGVyX25vZGUpOwo+ICAgCX0KPiAgIAo+ICAgCW5vZGVz ID0ga3ZtYWxsb2NfYXJyYXkobnVtX25vZGVzLCBzaXplb2YoKm5vZGVzKSwKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0 CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==