* [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data
@ 2017-06-28 10:33 Abdiel Janulgue
2017-06-28 11:06 ` Arkadiusz Hiler
0 siblings, 1 reply; 3+ messages in thread
From: Abdiel Janulgue @ 2017-06-28 10:33 UTC (permalink / raw)
To: intel-gfx
Doing this tends to takes forever.
Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
---
tests/debugfs_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
index 3f0eaae..3d973d9 100644
--- a/tests/debugfs_test.c
+++ b/tests/debugfs_test.c
@@ -40,7 +40,8 @@ static void read_and_discard_sysfs_entries(int path_fd)
while ((dirent = readdir(dir))) {
if (!strcmp(dirent->d_name, ".") ||
- !strcmp(dirent->d_name, ".."))
+ !strcmp(dirent->d_name, "..") ||
+ !strcmp(dirent->d_name, "crc"))
continue;
if (dirent->d_type == DT_DIR) {
int sub_fd = -1;
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data
2017-06-28 10:33 [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data Abdiel Janulgue
@ 2017-06-28 11:06 ` Arkadiusz Hiler
2017-06-29 8:05 ` Abdiel Janulgue
0 siblings, 1 reply; 3+ messages in thread
From: Arkadiusz Hiler @ 2017-06-28 11:06 UTC (permalink / raw)
To: Abdiel Janulgue; +Cc: intel-gfx
On Wed, Jun 28, 2017 at 01:33:16PM +0300, Abdiel Janulgue wrote:
> Doing this tends to takes forever.
>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> ---
> tests/debugfs_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
> index 3f0eaae..3d973d9 100644
> --- a/tests/debugfs_test.c
> +++ b/tests/debugfs_test.c
> @@ -40,7 +40,8 @@ static void read_and_discard_sysfs_entries(int path_fd)
>
> while ((dirent = readdir(dir))) {
> if (!strcmp(dirent->d_name, ".") ||
> - !strcmp(dirent->d_name, ".."))
> + !strcmp(dirent->d_name, "..") ||
> + !strcmp(dirent->d_name, "crc"))
Do we have one that actually is named just "crc"?
IIRC 'i915_something_crc_something' was the format, and the check won't
catch them.
--
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data
2017-06-28 11:06 ` Arkadiusz Hiler
@ 2017-06-29 8:05 ` Abdiel Janulgue
0 siblings, 0 replies; 3+ messages in thread
From: Abdiel Janulgue @ 2017-06-29 8:05 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: intel-gfx
On 28.06.2017 14:06, Arkadiusz Hiler wrote:
> On Wed, Jun 28, 2017 at 01:33:16PM +0300, Abdiel Janulgue wrote:
>> Doing this tends to takes forever.
>>
>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>> ---
>> tests/debugfs_test.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
>> index 3f0eaae..3d973d9 100644
>> --- a/tests/debugfs_test.c
>> +++ b/tests/debugfs_test.c
>> @@ -40,7 +40,8 @@ static void read_and_discard_sysfs_entries(int path_fd)
>>
>> while ((dirent = readdir(dir))) {
>> if (!strcmp(dirent->d_name, ".") ||
>> - !strcmp(dirent->d_name, ".."))
>> + !strcmp(dirent->d_name, "..") ||
>> + !strcmp(dirent->d_name, "crc"))
>
> Do we have one that actually is named just "crc"?
>
> IIRC 'i915_something_crc_something' was the format, and the check won't
> catch them.
Hi,
I was referring to crc capture data at crtc-*/crc/data which is an
unlimited stream of bytes when read outright (tests for this are already
covered by kms_pipe_crc_basic).
How about just checking for "crtc-"?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-29 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 10:33 [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data Abdiel Janulgue
2017-06-28 11:06 ` Arkadiusz Hiler
2017-06-29 8:05 ` Abdiel Janulgue
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.