From: Kamil Konieczny <k.konieczny@partner.samsung.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
davem@davemloft.net, thomas.petazzoni@free-electrons.com,
gregory.clement@free-electrons.com,
miquel.raynal@free-electrons.com, oferh@marvell.com,
igall@marvell.com, nadavh@marvell.com,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 3/4] crypto: inside-secure - only update the result buffer when provided
Date: Fri, 01 Dec 2017 12:24:26 +0100 [thread overview]
Message-ID: <10b81ab7-ba16-602c-2df0-a0462ccae416@partner.samsung.com> (raw)
In-Reply-To: <20171201103648.GB320@gondor.apana.org.au>
Hi Herbert,
On 01.12.2017 11:36, Herbert Xu wrote:
> On Fri, Dec 01, 2017 at 11:18:30AM +0100, Kamil Konieczny wrote:
>>
>> Herbert, is it possible for every init/update that areq->result can be NULL,
>> and only for final/update/digit user set it to actual memory ?
>> testmgr.c can check if hash update writes into areq->result and if yes,
>> then test fails ?
>
> Yes we should modify testmgr to check that.
I can write patch for it. Should it WARN_ON or treat it as error ?
--
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland
next prev parent reply other threads:[~2017-12-01 11:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 15:42 [PATCH v2 0/4] crypto: inside-secure - set of fixes Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 1/4] crypto: inside-secure - per request invalidation Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 2/4] crypto: inside-secure - free requests even if their handling failed Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 3/4] crypto: inside-secure - only update the result buffer when provided Antoine Tenart
2017-11-30 9:19 ` Kamil Konieczny
2017-11-30 9:29 ` Antoine Tenart
2017-11-30 11:52 ` Kamil Konieczny
2017-11-30 12:41 ` Antoine Tenart
2017-11-30 14:10 ` Kamil Konieczny
2017-11-30 14:30 ` Antoine Tenart
2017-12-01 0:31 ` Herbert Xu
2017-12-01 8:11 ` Antoine Tenart
2017-12-01 10:18 ` Kamil Konieczny
2017-12-01 10:24 ` Antoine Tenart
2017-12-01 10:43 ` Kamil Konieczny
2017-12-01 10:55 ` Antoine Tenart
2017-12-01 10:36 ` Herbert Xu
2017-12-01 11:24 ` Kamil Konieczny [this message]
2017-12-01 10:35 ` Herbert Xu
2017-12-01 10:52 ` Antoine Tenart
2017-11-28 15:42 ` [PATCH v2 4/4] crypto: inside-secure - fix request allocations in invalidation path Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10b81ab7-ba16-602c-2df0-a0462ccae416@partner.samsung.com \
--to=k.konieczny@partner.samsung.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=igall@marvell.com \
--cc=linux-crypto@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=nadavh@marvell.com \
--cc=oferh@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.