From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 789E2ECAAD8 for ; Tue, 20 Sep 2022 15:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbiITP7x (ORCPT ); Tue, 20 Sep 2022 11:59:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231540AbiITP7s (ORCPT ); Tue, 20 Sep 2022 11:59:48 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5954564CB for ; Tue, 20 Sep 2022 08:59:47 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id a8so4492043lff.13 for ; Tue, 20 Sep 2022 08:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=QMYsP28bPSxiuVehnUkq9TPK8zyTroEstE6jb5tgTaI=; b=n+AtSohyyJIp32sHBo57AZXXa9T8x1CpBYXcbLur2iNqWsjX86/ihr9MnLKwNgYyMU GX9N2pZkMEFhQPl5ZlxgTeHD1n8+BlFjeRBzYXYiZCKlcV8qGgCAS3d6oMd+EWQPrrhM 1GvoqjjI2oLhq7zDxpcx+A9APdo/yShIyhz0Lmt0q6zLIHsOu5Awg5HdG4Z5sMtO/U7u ApAdEV+RKdeShp7eyK3o7adbqHxXJuU/0yG7rucfjVihMwKgdGSiXxju9YI8u6fAGHgm 3XIZl1mAlsVHRToObmHU9YsmdfsePs24ygAC7ZBi3+7hEUj0vBbSh7XPprr5QasfCBzr L8cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=QMYsP28bPSxiuVehnUkq9TPK8zyTroEstE6jb5tgTaI=; b=aSl5Xb83BkfkDGkxc7W9PCA4kv2O5BkMJNDJaI9DKb14R+WzYF9Mh4GJq1/YA3iKgy f1hdHteeIRZ7WcdGQJhuz42LwmPHD2B2PZ6MSRHSYyFhsgGA5MNPjqJWp8hcX1hzpzkh DxDILMCeYSh4Bjt3FOacQXGgX27yqa6KUlgq78Z5wO/07CrThZTLupkGZsBW8Vzq/8H+ 2U+gY2Gpr0AgBmOm0EPxXt0IhpPznlAP/BY05FA698wjhPISjskSDx/YqiYW6po7E9ag mZtGr0wTLk55rKdCKJ2Q3ngC8h9sRX95FdnDR8aCVYmVIwp7ZNC8uyJKHAPtMNqqu1Bf gZEQ== X-Gm-Message-State: ACrzQf38LHlYvOAA57iIDcvTq9hkYN8stAHTvEtPcafnWNI/VUpbdT9Z oEVsQHy2/aUAmklQm/zGCdJnBw== X-Google-Smtp-Source: AMsMyM4wZ4bHQzY1QM+2MvHkJrH6aFzjE1xLqU7NFFllPA01l1cq/QNVqFQhjz6U4JGkLgammgllmQ== X-Received: by 2002:a05:6512:2210:b0:499:d710:9c0d with SMTP id h16-20020a056512221000b00499d7109c0dmr9097083lfu.325.1663689585682; Tue, 20 Sep 2022 08:59:45 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l17-20020a2e8691000000b0026b2094f6fcsm19677lji.73.2022.09.20.08.59.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 08:59:44 -0700 (PDT) Message-ID: <10bd1f39-3971-90ee-5fe4-c44005cdfcc8@linaro.org> Date: Tue, 20 Sep 2022 17:59:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0 Content-Language: en-US To: Viorel Suman Cc: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Viorel Suman , Shenwei Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220919132236.264382-1-viorel.suman@oss.nxp.com> <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116> From: Krzysztof Kozlowski In-Reply-To: <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2022 20:06, Viorel Suman wrote: 43 >>> #define IMX_SC_R_SECVIO 44 >>> #define IMX_SC_R_DC_1_VIDEO0 45 >>> #define IMX_SC_R_DC_1_VIDEO1 46 >>> #define IMX_SC_R_DC_1_FRAC0 47 >>> +#define IMX_SC_R_V2X 48 >>> #define IMX_SC_R_DC_1 49 >>> +#define IMX_SC_R_UNUSED14 50 >>> #define IMX_SC_R_DC_1_PLL_0 51 >>> #define IMX_SC_R_DC_1_PLL_1 52 >>> #define IMX_SC_R_SPI_0 53 >>> @@ -151,10 +154,10 @@ >>> #define IMX_SC_R_DMA_1_CH29 137 >>> #define IMX_SC_R_DMA_1_CH30 138 >>> #define IMX_SC_R_DMA_1_CH31 139 >>> -#define IMX_SC_R_UNUSED1 140 >> >> This one disappears... > > Hi Krzysztof, > > Right, it was renamed in the subsequent SCFW kit > versions to IMX_SC_R_V2X_PID0, thus - this patch > rename it in include/dt-bindings/firmware/imx/rsrc.h > file in order to have this file and SCFW kit defines > synchronized. > > IMX_SC_R_UNUSED1 is not referenced somehow in kernel, > thus - no compilation issues if renamed to IMX_SC_R_V2X_PID0, > IMHO it does not make sense to me to add the related > backward compatibility define like below: > > #define IMX_SC_R_UNUSED1 IMX_SC_R_V2X_PID0 The bindings are used by other people (other Linux kernel forks) and by other projects (like bootloaders and other operating systems). This is why once set, we do not change them, with some exceptions. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4690BECAAD8 for ; Tue, 20 Sep 2022 16:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d75Nz0Xg+A4FsWyQE/P7lls1YiodbeE5X/vKqtUG068=; b=UcO9WPwG+ccrQs ENa6dmfg0Wsm9Bw3Ko2nARvYf8LASo5eeWoVZGCP1g+VABz/46e30QeW562H+CsEBDFDJPLvIEgwq t4R6CM7h+p+TeMeVknTEZnG/yoesgwfjXqmHACj4n73ZDM7G0BDi9HhY36wCLk9z7ggrFSgiryiv7 INub6189Wp1QJ7fxxUFkGQafpca6WXUM7p1oUN6Y6uNaIUnMfFACuBRnt8WQCsZthpaYmAcrvtOuQ rwajXUIqexkBIr/ScrieorOP9fE4ne+MDJtpgXWPQecppc2oGDY2BPaggsIrvnmlY6J/nuGN2GEeC NLcsuL6WTDe1ybTzRJdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaff7-0051vT-9C; Tue, 20 Sep 2022 15:59:53 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaff4-0051u1-9f for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 15:59:51 +0000 Received: by mail-lf1-x12a.google.com with SMTP id f9so4566058lfr.3 for ; Tue, 20 Sep 2022 08:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=QMYsP28bPSxiuVehnUkq9TPK8zyTroEstE6jb5tgTaI=; b=n+AtSohyyJIp32sHBo57AZXXa9T8x1CpBYXcbLur2iNqWsjX86/ihr9MnLKwNgYyMU GX9N2pZkMEFhQPl5ZlxgTeHD1n8+BlFjeRBzYXYiZCKlcV8qGgCAS3d6oMd+EWQPrrhM 1GvoqjjI2oLhq7zDxpcx+A9APdo/yShIyhz0Lmt0q6zLIHsOu5Awg5HdG4Z5sMtO/U7u ApAdEV+RKdeShp7eyK3o7adbqHxXJuU/0yG7rucfjVihMwKgdGSiXxju9YI8u6fAGHgm 3XIZl1mAlsVHRToObmHU9YsmdfsePs24ygAC7ZBi3+7hEUj0vBbSh7XPprr5QasfCBzr L8cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=QMYsP28bPSxiuVehnUkq9TPK8zyTroEstE6jb5tgTaI=; b=fQ8PDCdX3kFm/bk47XcbpxjEyfeozAPYqWhyPcsA4dkpT+G9mEMoc/aUMNAnPaQz6N 8gtgWHPpQfNmO80n+wwxvPl2A1eDvmM77RcWomVlvKeILMlDLbZELMbdsnqCzgXnqWJk fCD55noHnoXea+uB26uzkohdlz9LgH9xFjsesO4lcHTX/9f7TPHu6uxSy10d+Rc64gln 3gmeZxdPZG11WOj9ShKJJsO7P/Am1UE2gtyM+HDY7c169JtsP/Tf6XOSlTLcHp9Z3KWj j272SsKIASc4RdinO9yyXl7KUWjiJSHVunU8vg6ziY1YEe7wWadqj3Wp1fVEHDdCDjJb Ratw== X-Gm-Message-State: ACrzQf2WdYhgHTibjfIQSUd51uwBIF+BLAUOjjwT1lvvibhZEp55BPpM j0+jbaF/vA8mla3Ht8vF3RP68A== X-Google-Smtp-Source: AMsMyM4wZ4bHQzY1QM+2MvHkJrH6aFzjE1xLqU7NFFllPA01l1cq/QNVqFQhjz6U4JGkLgammgllmQ== X-Received: by 2002:a05:6512:2210:b0:499:d710:9c0d with SMTP id h16-20020a056512221000b00499d7109c0dmr9097083lfu.325.1663689585682; Tue, 20 Sep 2022 08:59:45 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l17-20020a2e8691000000b0026b2094f6fcsm19677lji.73.2022.09.20.08.59.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 08:59:44 -0700 (PDT) Message-ID: <10bd1f39-3971-90ee-5fe4-c44005cdfcc8@linaro.org> Date: Tue, 20 Sep 2022 17:59:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0 Content-Language: en-US To: Viorel Suman Cc: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Viorel Suman , Shenwei Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220919132236.264382-1-viorel.suman@oss.nxp.com> <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116> From: Krzysztof Kozlowski In-Reply-To: <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_085950_391609_97007E2C X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/09/2022 20:06, Viorel Suman wrote: 43 >>> #define IMX_SC_R_SECVIO 44 >>> #define IMX_SC_R_DC_1_VIDEO0 45 >>> #define IMX_SC_R_DC_1_VIDEO1 46 >>> #define IMX_SC_R_DC_1_FRAC0 47 >>> +#define IMX_SC_R_V2X 48 >>> #define IMX_SC_R_DC_1 49 >>> +#define IMX_SC_R_UNUSED14 50 >>> #define IMX_SC_R_DC_1_PLL_0 51 >>> #define IMX_SC_R_DC_1_PLL_1 52 >>> #define IMX_SC_R_SPI_0 53 >>> @@ -151,10 +154,10 @@ >>> #define IMX_SC_R_DMA_1_CH29 137 >>> #define IMX_SC_R_DMA_1_CH30 138 >>> #define IMX_SC_R_DMA_1_CH31 139 >>> -#define IMX_SC_R_UNUSED1 140 >> >> This one disappears... > > Hi Krzysztof, > > Right, it was renamed in the subsequent SCFW kit > versions to IMX_SC_R_V2X_PID0, thus - this patch > rename it in include/dt-bindings/firmware/imx/rsrc.h > file in order to have this file and SCFW kit defines > synchronized. > > IMX_SC_R_UNUSED1 is not referenced somehow in kernel, > thus - no compilation issues if renamed to IMX_SC_R_V2X_PID0, > IMHO it does not make sense to me to add the related > backward compatibility define like below: > > #define IMX_SC_R_UNUSED1 IMX_SC_R_V2X_PID0 The bindings are used by other people (other Linux kernel forks) and by other projects (like bootloaders and other operating systems). This is why once set, we do not change them, with some exceptions. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel