All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bixuan Cui <cuibixuan@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, leon@kernel.org, w@1wt.eu,
	keescook@chromium.org
Subject: Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls
Date: Thu, 2 Dec 2021 12:05:15 +0800	[thread overview]
Message-ID: <10cb0382-012b-5012-b664-c29461ce4de8@linux.alibaba.com> (raw)
In-Reply-To: <20211201192643.ecb0586e0d53bf8454c93669@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]


在 2021/12/2 上午11:26, Andrew Morton 写道:
>> Delete the WARN_ON() and return NULL directly for oversized parameter
>> in kvmalloc() calls.
>> Also add unlikely().
>>
>> Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls")
>> Signed-off-by: Bixuan Cui<cuibixuan@linux.alibaba.com>
>> ---
>> There are a lot of oversize warnings and patches about kvmalloc() calls
>> recently. Maybe these warnings are not very necessary.
> Or maybe they are.  Please let's take a look at these warnings, one at
> a time.  If a large number of them are bogus then sure, let's disable
> the runtime test.  But perhaps it's the case that calling code has
> genuine issues and should be repaired.
Such as：

https://syzkaller.appspot.com/bug?id=24452f89446639c901ac07379ccc702808471e8e

https://syzkaller.appspot.com/bug?id=f7c5a86e747f9b7ce333e7295875cd4ede2c7a0d

https://syzkaller.appspot.com/bug?id=8f306f3db150657a1f6bbe1927467084531602c7

https://syzkaller.appspot.com/bug?id=6f30adb592d476978777a1125d1f680edfc23e00

https://syzkaller.appspot.com/bug?id=4c9ab8c7d0f8b551950db06559dc9cde4119ac83


[-- Attachment #2: Type: text/html, Size: 2584 bytes --]

  reply	other threads:[~2021-12-02  4:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  2:06 [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls Bixuan Cui
2021-12-02  2:53 ` Tang Yizhou
2021-12-02  3:26 ` Andrew Morton
2021-12-02  4:05   ` Bixuan Cui [this message]
2021-12-02  4:29     ` Andrew Morton
2021-12-02 10:38       ` Jeremy Sowden
2021-12-02 15:34         ` Alexei Starovoitov
2021-12-02 21:16           ` Jeremy Sowden
2021-12-02 11:49       ` Bixuan Cui
2021-12-03 19:37       ` Sean Christopherson
2021-12-02 15:23   ` Leon Romanovsky
2021-12-02 15:29     ` Matthew Wilcox
2021-12-02 16:08       ` Leon Romanovsky
2021-12-02 19:08         ` Kees Cook
2021-12-02 19:24           ` Leon Romanovsky
2021-12-02 21:23             ` Kees Cook
2021-12-02 22:03               ` Andrew Morton
2021-12-03  4:39                 ` Matthew Wilcox
2021-12-02 17:00       ` Jason Gunthorpe
2021-12-02  3:46 ` Kees Cook
2021-12-02  4:44   ` Bixuan Cui
2021-12-02 17:03   ` Jason Gunthorpe
2021-12-05 11:59 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10cb0382-012b-5012-b664-c29461ce4de8@linux.alibaba.com \
    --to=cuibixuan@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.