From: Eric Blake <eblake@redhat.com>
To: Ben Warren <ben@skyportsystems.com>
Cc: qemu-devel@nongnu.org, Gal Hammer <ghammer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] docs: vm generation id device's description
Date: Mon, 16 Jan 2017 15:20:55 -0600 [thread overview]
Message-ID: <10cf4cb6-b775-54d0-12db-4d2336b6fbaa@redhat.com> (raw)
In-Reply-To: <EE421B2A-48D8-40AE-B6A2-0261F4B1524E@skyportsystems.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On 01/16/2017 02:08 PM, Ben Warren wrote:
>>>
>>> Signed-off-by: Ben Warren <ben@skyportsystems.com <mailto:ben@skyportsystems.com>>
>>> Cc: Gal Hammer <ghammer@redhat.com <mailto:ghammer@redhat.com>>
>>
>> If you are basing this patch off of earlier work (for example, you
>> mentioned Igor's work), you may need additional S-o-b lines for work you
>> copied from the earlier versions.
>>
> yes, I used a previous patch set as a baseline and want to make sure credit goes to whoever did the real work. In this case, Gal Hammer was the original author, so I CC’d Him (or her) hoping to get an SOB. Should that be handled out-of-band?
If Gal already had S-o-b on the version you started with, then the most
common two approaches are:
1) Use Gal's commit message verbatim, including his S-o-b, then add
another paragraph about your changes, with your S-o-b.
2) Rewrite the commit message, but state that you are basing on Gal's
work, then list S-o-b for both content contributors next to one another.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-16 21:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 19:20 [Qemu-devel] [PATCH v2 0/6] Add support for VM Generation ID ben
[not found] ` <cover.1484594095.git.ben@skyportsystems.com>
2017-01-16 19:20 ` [Qemu-devel] [PATCH v2 1/6] docs: vm generation id device's description ben
2017-01-16 19:51 ` Eric Blake
2017-01-16 20:08 ` Ben Warren
2017-01-16 21:20 ` Eric Blake [this message]
2017-01-16 19:20 ` [Qemu-devel] [PATCH v2 2/6] ACPI: Add a function for building named qword entries ben
2017-01-16 19:20 ` [Qemu-devel] [PATCH v2 3/6] ACPI: Add Virtual Machine Generation ID support ben
2017-01-17 13:00 ` Igor Mammedov
2017-01-17 13:18 ` Laszlo Ersek
2017-01-17 14:41 ` Michael S. Tsirkin
2017-01-17 16:37 ` Laszlo Ersek
2017-01-18 0:23 ` Ben Warren
2017-01-16 19:20 ` [Qemu-devel] [PATCH v2 4/6] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands ben
2017-01-16 19:20 ` [Qemu-devel] [PATCH v2 5/6] qmp/hmp: add set-vm-generation-id commands ben
2017-01-18 8:55 ` Igor Mammedov
2017-01-18 22:14 ` Ben Warren
2017-01-16 19:20 ` [Qemu-devel] [PATCH v2 6/6] PC: Support dynamic sysbus on pc_i440fx ben
2017-01-18 8:46 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10cf4cb6-b775-54d0-12db-4d2336b6fbaa@redhat.com \
--to=eblake@redhat.com \
--cc=ben@skyportsystems.com \
--cc=ghammer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.