From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52080 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbeDXJJO (ORCPT ); Tue, 24 Apr 2018 05:09:14 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3O99AFF141360 for ; Tue, 24 Apr 2018 05:09:12 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hj1hb0me6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 24 Apr 2018 05:09:12 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Apr 2018 10:09:09 +0100 Subject: Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2) To: "Martin K. Petersen" , Hannes Reinecke Cc: Sreekanth Reddy , Igor Rybak , Andrey Grodzovsky , Ezra Kohavi , PDL-MPT-FUSIONLINUX , "linux-scsi@vger.kernel.org" , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "stable@vger.kernel.org" References: <2179ecb8-183f-a500-4d65-10f64f0f43cc@suse.de> <1478045394-19536-1-git-send-email-andrey2805@gmail.com> <30w645ulbhlofxrk1h4a9q3s.1478144944778@email.android.com> <38e3e634-6e08-58bd-bc11-8a0a470b78d9@suse.de> From: Steffen Maier Date: Tue, 24 Apr 2018 11:09:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8BIT Message-Id: <10db11e2-1e15-2b16-f5e6-81fbf2581683@linux.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On 11/04/2016 05:35 PM, Martin K. Petersen wrote: >>>>>> "Hannes" == Hannes Reinecke writes: > > Hannes> Checking with SAT-3 (section 6.2.4: Commands the SATL queues > Hannes> internally) the implemented behaviour is standards conformant, > Hannes> although the standard also allows for returning 'TASK SET FULL' > Hannes> or 'BUSY' in these cases. Doing so would nicely solve this > Hannes> issue. > > I agree with Hannes that it would be appropriate for the SATL to report > busy when it makes an non-queued command queueable. Wouldn't this potentially still cause problems if the secure erase takes longer than max_retries * scmd_tmo. I.e. the command timing out by default after 180 seconds as in https://www.spinics.net/lists/linux-block/msg24837.html ? The fix approach here seems to also handle this gracefully. -- Mit freundlichen Grüßen / Kind regards Steffen Maier Linux on z Systems Development IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294