From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E49C433E9 for ; Mon, 11 Jan 2021 10:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47BC8221ED for ; Mon, 11 Jan 2021 10:53:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729566AbhAKKxX (ORCPT ); Mon, 11 Jan 2021 05:53:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23417 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729306AbhAKKxV (ORCPT ); Mon, 11 Jan 2021 05:53:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610362314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dw2Go3odg3xQMi8oKZf9V/+2r4MBnUAd+QSYJ2Ro4mk=; b=VFEF7adGCxt5rRD3DiV6/2isRp278+qFdI+tbiI4JgMtOVhNEMjPPu7ou0f1q3aAt4AVOr OQ6lqqGoPLknSraCae98xMuJkSI729nqAzclD+/AwEwCUdar5K/iQVG7TeFzgD/XX9DIrR g7yfE9Dqsb9X+AfIizE/TElCiH1OUhQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-94NqtCM0NF23H57DTgUYyg-1; Mon, 11 Jan 2021 05:51:52 -0500 X-MC-Unique: 94NqtCM0NF23H57DTgUYyg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E87FF180A09F; Mon, 11 Jan 2021 10:51:50 +0000 (UTC) Received: from [10.36.115.103] (ovpn-115-103.ams2.redhat.com [10.36.115.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94DC274AAC; Mon, 11 Jan 2021 10:51:48 +0000 (UTC) Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> Date: Mon, 11 Jan 2021 11:51:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.12.20 16:28, Anshuman Khandual wrote: > This introduces memhp_range_allowed() which can be called in various memory > hotplug paths to prevalidate the address range which is being added, with > the platform. Then memhp_range_allowed() calls memhp_get_pluggable_range() > which provides applicable address range depending on whether linear mapping > is required or not. For ranges that require linear mapping, it calls a new > arch callback arch_get_mappable_range() which the platform can override. So > the new callback, in turn provides the platform an opportunity to configure > acceptable memory hotplug address ranges in case there are constraints. > > This mechanism will help prevent platform specific errors deep down during > hotplug calls. This drops now redundant check_hotplug_memory_addressable() > check in __add_pages() but instead adds a VM_BUG_ON() check which would > ensure that the range has been validated with memhp_range_allowed() earlier > in the call chain. Besides memhp_get_pluggable_range() also can be used by > potential memory hotplug callers to avail the allowed physical range which > would go through on a given platform. > > This does not really add any new range check in generic memory hotplug but > instead compensates for lost checks in arch_add_memory() where applicable > and check_hotplug_memory_addressable(), with unified memhp_range_allowed(). > Subject s/mm\/hotplug/mm\/memory_hotplug/ Everywhere in this patch: Use "true/false" for boolean values. > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Suggested-by: David Hildenbrand > Signed-off-by: Anshuman Khandual > --- > include/linux/memory_hotplug.h | 10 +++++ > mm/memory_hotplug.c | 79 +++++++++++++++++++++++++--------- > mm/memremap.c | 6 +++ > 3 files changed, 75 insertions(+), 20 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 551093b74596..8d72354758c8 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -70,6 +70,9 @@ typedef int __bitwise mhp_t; > */ > #define MEMHP_MERGE_RESOURCE ((__force mhp_t)BIT(0)) > > +bool memhp_range_allowed(u64 start, u64 size, bool need_mapping); > +struct range memhp_get_pluggable_range(bool need_mapping); AFAIKs, all memhp_get_pluggable_range() users pass "1". What about the "add_pages()-only" path? -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 278B3C433E0 for ; Mon, 11 Jan 2021 10:53:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3C2A221ED for ; Mon, 11 Jan 2021 10:53:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3C2A221ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sd+9nGurdpULLhN4QIUIkvOn0d51gy4s3fVSr4hNg4Q=; b=fqFvxiviWShAb2wgcRFZTJp4l Mt2WWziT515bxYydbqcxL5YG75D0XT1Grb8X2LCYEZ4KhzBl893f6EqscMlcCWOHRTf4GlXHo6QEz XiyI4q4irEEmXL45T57kUIqfNlelG1zh4C9lRdLypMQZwC15XM7T7U1E+Q+T6XGuTwIr5kkSJ9Lf4 zrKGJfqYU2QOQehMwB+shrQmhk1pGca0tgnK/2f1fTG5Oea/gcNmbGY+CHkP5IW0KH1t6Z7yBxV5A CgFd+nsi2s+itbhHbnPrypBWgvThwheqNIv2COR6WkYNxyEFLhk1i3nLMhy5HLgC46DMpZo3vBipg 00IOehIlA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyunr-0006QJ-My; Mon, 11 Jan 2021 10:52:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyunm-0006OR-D6 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 10:52:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610362316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dw2Go3odg3xQMi8oKZf9V/+2r4MBnUAd+QSYJ2Ro4mk=; b=XvoWbWgUbiREjj5/mNKvpUsXsRj2SX505xCjpT385EdbBuK+1B7r3OpMl2vA5lmJ8lzcO6 ekEFZh/j/Gza7Bib5oZw1oO/Qd61rwdhUwc6ixVDRlSiSUyPGk4tUl4sBdantbv3JT9I8+ BYuVdab+A1sacAayRE90sS/Ltn6Xqq8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-94NqtCM0NF23H57DTgUYyg-1; Mon, 11 Jan 2021 05:51:52 -0500 X-MC-Unique: 94NqtCM0NF23H57DTgUYyg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E87FF180A09F; Mon, 11 Jan 2021 10:51:50 +0000 (UTC) Received: from [10.36.115.103] (ovpn-115-103.ams2.redhat.com [10.36.115.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94DC274AAC; Mon, 11 Jan 2021 10:51:48 +0000 (UTC) Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> Date: Mon, 11 Jan 2021 11:51:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_055159_124817_E0FDAEFB X-CRM114-Status: GOOD ( 26.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-s390@vger.kernel.org, Vasily Gorbik , linux-kernel@vger.kernel.org, Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17.12.20 16:28, Anshuman Khandual wrote: > This introduces memhp_range_allowed() which can be called in various memory > hotplug paths to prevalidate the address range which is being added, with > the platform. Then memhp_range_allowed() calls memhp_get_pluggable_range() > which provides applicable address range depending on whether linear mapping > is required or not. For ranges that require linear mapping, it calls a new > arch callback arch_get_mappable_range() which the platform can override. So > the new callback, in turn provides the platform an opportunity to configure > acceptable memory hotplug address ranges in case there are constraints. > > This mechanism will help prevent platform specific errors deep down during > hotplug calls. This drops now redundant check_hotplug_memory_addressable() > check in __add_pages() but instead adds a VM_BUG_ON() check which would > ensure that the range has been validated with memhp_range_allowed() earlier > in the call chain. Besides memhp_get_pluggable_range() also can be used by > potential memory hotplug callers to avail the allowed physical range which > would go through on a given platform. > > This does not really add any new range check in generic memory hotplug but > instead compensates for lost checks in arch_add_memory() where applicable > and check_hotplug_memory_addressable(), with unified memhp_range_allowed(). > Subject s/mm\/hotplug/mm\/memory_hotplug/ Everywhere in this patch: Use "true/false" for boolean values. > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Suggested-by: David Hildenbrand > Signed-off-by: Anshuman Khandual > --- > include/linux/memory_hotplug.h | 10 +++++ > mm/memory_hotplug.c | 79 +++++++++++++++++++++++++--------- > mm/memremap.c | 6 +++ > 3 files changed, 75 insertions(+), 20 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 551093b74596..8d72354758c8 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -70,6 +70,9 @@ typedef int __bitwise mhp_t; > */ > #define MEMHP_MERGE_RESOURCE ((__force mhp_t)BIT(0)) > > +bool memhp_range_allowed(u64 start, u64 size, bool need_mapping); > +struct range memhp_get_pluggable_range(bool need_mapping); AFAIKs, all memhp_get_pluggable_range() users pass "1". What about the "add_pages()-only" path? -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel