From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A41AC10F27 for ; Tue, 10 Mar 2020 11:29:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F72424681 for ; Tue, 10 Mar 2020 11:29:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VHZNqwjT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F72424681 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBd4s-0006Yv-98 for qemu-devel@archiver.kernel.org; Tue, 10 Mar 2020 07:29:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39130) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBd3x-0005Jg-NO for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:28:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBd3w-0002CQ-BR for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:28:41 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:56204) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBd3w-00026y-0e for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:28:40 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02ABSbNv189439; Tue, 10 Mar 2020 11:28:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=R5qcNaii7uWZ/YptnLFqFguudbMOwUOm6DonSZ7HAas=; b=VHZNqwjT9mTIH8SMiOmclwSTHnkTT2+YMfEVuu1/t0KHv3e17iha8W3XoUTif00FfaDL KWBxQO2pLxq53DZGOGlE0Q/dR6R3MkeTgevUptyNLt6zNOv5gECu0b4UN954m//GZEAQ tzBMHN023jgtaB/vaToLQoWr/r5NEgcJzrdihIVW/c1TJTbc2QsdtLGEC8A0KUTyb2I8 w475gKpE/FOo3AhiGhFvjJMNUDkV3zRfevxKsToTOPWoVKxeWl8uS3x/qFQvqbwABni3 0FqmFF75SBrzYZUXsPz4jlqMUZPi1iNMufzyvzHY6+zlsEMikj54gtXxGj/fHjfGmuVN xQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2yp9v601q6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 11:28:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02ABS6Be169862; Tue, 10 Mar 2020 11:28:37 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2yp8pr1ukd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 11:28:37 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02ABSaiL031223; Tue, 10 Mar 2020 11:28:36 GMT Received: from [192.168.14.112] (/79.181.212.171) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Mar 2020 04:28:36 -0700 Subject: Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property To: "Michael S. Tsirkin" References: <20200309235411.76587-1-liran.alon@oracle.com> <20200309235411.76587-5-liran.alon@oracle.com> <20200310053210-mutt-send-email-mst@kernel.org> <0dd22d9c-e1d2-db1e-372e-5009be705dab@oracle.com> <20200310071453-mutt-send-email-mst@kernel.org> From: Liran Alon Message-ID: <10ffd04f-30f9-6333-26ef-169cd1615341@oracle.com> Date: Tue, 10 Mar 2020 13:28:32 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200310071453-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9555 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100077 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9555 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100077 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Nikita Leshenko , pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/03/2020 13:18, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote: >> On 10/03/2020 11:32, Michael S. Tsirkin wrote: >>> On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: >>>> Instead of hard-coding the VMX version, make it a VMPORT object property. >>>> This would allow user to control it's value via "-global vmport.vmx-version=X". >>>> >>>> Reviewed-by: Nikita Leshenko >>>> Signed-off-by: Liran Alon >>> More detail on why this is useful? >> It's more useful than returning a hard-coded "6" as the vmx-version... > > Maybe default should be 6 (a bit of explanation why 6 could be nice). The default is indeed defined as 6. As it was before this patch. There is not much to explain besides the fact that recent VMware products returns 6 here. I don't recall any mapping between the returned version here and the supported set of VMPort commands. There is a separate mechanism (which we implement in another patch) to signal that a command is unsupported / failed. The term "vmx-version" refers to the version of the Userspace-VMM of VMware which is called (confusingly) "vmx". >> We have used it to preserve compatibility for some VMware guests that we run >> as-is on top of QEMU/KVM which expects specific vmx-version or else they >> fail to run properly. >> >> -Liran > Any detail on which guest it is? I will need to dig in production history to find it... They are usually proprietary appliances specially made to run as VMware VMs. > Pretending to be a very advanced version has its pitfalls if we > then don't behave the way vmware does, right? In all those cases, we have taken the version number backwards, not forward. > Figuring out the version number is I suspect a bit much to ask of users. Most users will indeed not need to touch this. This is for advanced users, such as Ravello. We usually figured this out by reverse-engineering the failed guest and/or examining the original VMware environment it used to run on. -Liran